From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> To: "Joyce Kong (Arm Technology China)" <Joyce.Kong@arm.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "jerinj@marvell.com" <jerinj@marvell.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "ravi1.kumar@amd.com" <ravi1.kumar@amd.com>, "rmody@marvell.com" <rmody@marvell.com>, "shshaikh@marvell.com" <shshaikh@marvell.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH v2 1/6] lib/eal: implement the family of rte bit operation APIs Date: Wed, 23 Oct 2019 03:09:55 +0000 Message-ID: <VE1PR08MB51492E7284D1C913890B9991986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw) In-Reply-To: <1571799298-18873-2-git-send-email-joyce.kong@arm.com> Hi Joyce, Thanks for the patch, few comments. <snip> > > There are a lot functions of bit operations scattered and duplicated in PMDs, > consolidating them into a common API family is necessary. Furthermore, the > bit operation is mostly applied to the IO devices, so use __ATOMIC_ACQ_REL > to ensure the ordering. The APIs are not taking memory ordering as a parameter. This presents the same problem as the rte_atomic_xxx APIs. IMO, the APIs should take memory ordering as a parameter. > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > --- > lib/librte_eal/common/Makefile | 1 + > lib/librte_eal/common/include/rte_io_bitops.h | 112 > ++++++++++++++++++++++++++ > lib/librte_eal/common/meson.build | 1 + > 3 files changed, 114 insertions(+) > create mode 100644 lib/librte_eal/common/include/rte_io_bitops.h > > diff --git a/lib/librte_eal/common/Makefile > b/lib/librte_eal/common/Makefile index a00d4fc..3831313 100644 > --- a/lib/librte_eal/common/Makefile > +++ b/lib/librte_eal/common/Makefile > @@ -18,6 +18,7 @@ INC += rte_malloc.h rte_keepalive.h rte_time.h INC += > rte_service.h rte_service_component.h INC += rte_bitmap.h rte_vfio.h > rte_hypervisor.h rte_test.h INC += rte_reciprocal.h rte_fbarray.h rte_uuid.h > +INC += rte_io_bitops.h > > GENERIC_INC := rte_atomic.h rte_byteorder.h rte_cycles.h rte_prefetch.h > GENERIC_INC += rte_memcpy.h rte_cpuflags.h diff --git > a/lib/librte_eal/common/include/rte_io_bitops.h > b/lib/librte_eal/common/include/rte_io_bitops.h > new file mode 100644 > index 0000000..5f778b8 > --- /dev/null > +++ b/lib/librte_eal/common/include/rte_io_bitops.h > @@ -0,0 +1,112 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2019 Arm Limited > + */ > + > +#ifndef _RTE_IO_BITOPS_H_ > +#define _RTE_IO_BITOPS_H_ > + > +/** > + * @file > + * Bit Operations > + * > + * This file defines a generic API for bit operations. > + */ > + > +#include <rte_lcore.h> > + > +/** > + * Get a bit. > + * > + * @param nr > + * The bit to get. > + * @param addr > + * The address to count from. > + * @return > + * The value of the bit. > + */ > +static inline int32_t > +rte_io_get_bit(uint32_t nr, uint64_t *addr) { > + return __atomic_load_n(addr, __ATOMIC_ACQUIRE) & (1UL << nr); } Some use cases might need 'relaxed' memory order for this API. So, the user of this API should be able to provide the memory order. > + > +/** > + * Set a bit to 1. > + * > + * @param nr > + * The bit to set. > + * @param addr > + * The address to count from. > + */ > +static inline void > +rte_io_set_bit(uint32_t nr, uint64_t *addr) { > + __atomic_fetch_or(addr, (1UL << nr), __ATOMIC_ACQ_REL); } Some use cases might need 'release' or 'relaxed' memory order. Similar requirements apply to other APIs too. > + > +/** > + * Set a bit to 0. > + * > + * @param nr > + * The bit to set. > + * @param addr > + * The address to count from. > + */ > +static inline void > +rte_io_clear_bit(int32_t nr, uint64_t *addr) { > + __atomic_fetch_and(addr, ~(1UL << nr), __ATOMIC_ACQ_REL); } > + > +/** > + * Test if a bit is 1. > + * > + * @param nr > + * The bit to test. > + * @param addr > + * The address to count from. > + * @return > + * 1 if the bit is 1; else 0. > + */ > +static inline int32_t > +rte_io_test_bit(int32_t nr, uint64_t *addr) { > + return (__atomic_load_n(addr, __ATOMIC_ACQUIRE) & (1UL << > nr)) != 0; } > + > +/** > + * Set a bit to 1 and return its old value. > + * > + * @param nr > + * The bit to set. > + * @param addr > + * The address to count from. > + * @return > + * The old value of the bit. > + */ > +static inline int32_t > +rte_io_test_and_set_bit(int32_t nr, uint64_t *addr) { > + unsigned long mask = (1UL << nr); > + > + return __atomic_fetch_or(addr, mask, __ATOMIC_ACQ_REL) & > mask; } > + > +/** > + * Set a bit to 0 and return its old value. > + * > + * @param nr > + * The bit to set. > + * @param addr > + * The address to count from. > + * @return > + * The old value of the bit. > + */ > +static inline int32_t > +rte_io_test_and_clear_bit(int32_t nr, uint64_t *addr) { > + unsigned long mask = (1UL << nr); > + > + return __atomic_fetch_and(addr, ~mask, __ATOMIC_ACQ_REL) & > mask; } > +#endif /* _RTE_IO_BITOPS_H_ */ > diff --git a/lib/librte_eal/common/meson.build > b/lib/librte_eal/common/meson.build > index 386577c..0a65d04 100644 > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > @@ -52,6 +52,7 @@ common_headers = files( > 'include/rte_alarm.h', > 'include/rte_branch_prediction.h', > 'include/rte_bus.h', > + 'include/rte_io_bitops.h', > 'include/rte_bitmap.h', > 'include/rte_class.h', > 'include/rte_common.h', > -- > 2.7.4
next prev parent reply index Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 7:49 [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs Joyce Kong 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-10-15 16:53 ` Stephen Hemminger 2019-10-18 9:00 ` Joyce Kong (Arm Technology China) 2019-10-16 7:54 ` Jerin Jacob 2019-10-18 9:02 ` Joyce Kong (Arm Technology China) 2019-10-23 3:12 ` Joyce Kong (Arm Technology China) 2019-10-16 19:05 ` Stephen Hemminger 2019-10-17 13:32 ` [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-10-18 8:58 ` Joyce Kong (Arm Technology China) 2019-10-23 3:07 ` Joyce Kong (Arm Technology China) 2019-10-23 7:45 ` Morten Brørup 2019-10-23 17:30 ` Honnappa Nagarahalli 2019-10-24 3:38 ` Gavin Hu (Arm Technology China) 2019-11-01 13:48 ` Honnappa Nagarahalli 2019-11-03 15:45 ` Gavin Hu (Arm Technology China) 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 2/5] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 3/5] net/bnx2x: " Joyce Kong 2019-10-15 7:50 ` [dpdk-dev] [PATCH v1 4/5] net/hinic: " Joyce Kong 2019-10-15 7:50 ` [dpdk-dev] [PATCH v1 5/5] net/qede: " Joyce Kong 2019-10-15 16:51 ` [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs Stephen Hemminger 2019-10-18 9:01 ` Joyce Kong (Arm Technology China) 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 0/6] " Joyce Kong 2019-10-25 13:14 ` David Marchand 2019-10-29 16:42 ` Thomas Monjalon 2019-10-30 9:55 ` Gavin Hu (Arm Technology China) 2019-10-30 10:17 ` Thomas Monjalon 2019-10-30 12:32 ` Jerin Jacob 2019-10-30 13:02 ` Morten Brørup 2019-10-31 10:39 ` Gavin Hu (Arm Technology China) 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-10-23 3:09 ` Honnappa Nagarahalli [this message] 2019-10-23 4:56 ` Jerin Jacob 2019-10-23 7:46 ` Morten Brørup 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 2/6] test/iobitops: add io bit operation test case Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-10-23 3:16 ` Honnappa Nagarahalli 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 4/6] net/bnx2x: " Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 5/6] net/hinic: " Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 6/6] net/qede: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-18 10:52 ` [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-11-19 9:22 ` Joyce Kong (Arm Technology China) 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 4/6] net/bnx2x: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 5/6] net/qede: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 6/6] net/hinic: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-20 13:40 ` [dpdk-dev] [PATCH v4 1/6] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 4/6] net/bnx2x: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 5/6] net/qede: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 6/6] net/hinic: " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-12-02 6:09 ` Gavin Hu (Arm Technology China) 2019-12-02 9:12 ` Thomas Monjalon 2019-12-02 9:24 ` [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation " Morten Brørup 2019-12-02 9:30 ` Thomas Monjalon 2019-12-02 16:53 ` Stephen Hemminger 2019-12-03 6:52 ` Gavin Hu (Arm Technology China) 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 4/6] net/bnx2x: use common rte bit operation " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 5/6] net/qede: " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 6/6] net/hinic: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-12-18 6:55 ` Gavin Hu 2020-01-17 13:03 ` David Marchand 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-12-20 6:52 ` Honnappa Nagarahalli 2019-12-21 16:07 ` Honnappa Nagarahalli 2019-12-21 18:07 ` Stephen Hemminger 2019-12-23 5:04 ` Honnappa Nagarahalli 2019-12-23 16:36 ` Stephen Hemminger 2019-12-30 3:02 ` Gavin Hu 2020-01-07 0:44 ` Honnappa Nagarahalli 2020-01-07 1:26 ` Stephen Hemminger 2020-01-07 4:41 ` Honnappa Nagarahalli 2020-01-07 0:41 ` Honnappa Nagarahalli 2019-12-21 18:08 ` Stephen Hemminger 2019-12-23 5:45 ` Honnappa Nagarahalli 2019-12-23 8:59 ` Jerin Jacob 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 2/6] test/bitops: add bit operation test case Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 4/6] net/bnx2x: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 5/6] net/qede: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 6/6] net/hinic: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs Joyce Kong 2020-03-09 15:50 ` Stephen Hemminger 2020-03-31 22:35 ` Thomas Monjalon 2020-04-01 8:27 ` Gavin Hu 2020-04-01 9:45 ` Thomas Monjalon 2020-04-02 7:20 ` Gavin Hu 2020-04-02 8:07 ` Thomas Monjalon 2020-04-02 8:11 ` Jerin Jacob 2020-04-02 9:02 ` Gavin Hu 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 2/6] test/pmdbitops: add PMD bit operation test case Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 4/6] net/bnx2x: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 5/6] net/qede: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 6/6] net/hinic: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 0/6] implement common bit operation APIs Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-16 18:55 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of commonbit " Morten Brørup 2020-04-17 8:18 ` Joyce Kong 2020-04-17 9:38 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of common bit " Jerin Jacob 2020-04-20 2:46 ` Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 4/6] net/bnx2x: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 5/6] net/qede: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 6/6] net/hinic: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 0/6] implement common bit operation APIs Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-24 8:08 ` Thomas Monjalon 2020-04-26 2:07 ` Joyce Kong 2020-04-25 19:59 ` Thomas Monjalon 2020-04-26 7:18 ` Joyce Kong 2020-04-26 9:23 ` Thomas Monjalon 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 4/6] net/bnx2x: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 5/6] net/qede: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 6/6] net/hinic: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 0/6] implement common bit operation APIs Joyce Kong 2020-06-16 12:36 ` Thomas Monjalon 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 4/6] net/bnx2x: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 5/6] net/qede: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 6/6] net/hinic: " Joyce Kong 2020-06-16 12:31 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR08MB51492E7284D1C913890B9991986B0@VE1PR08MB5149.eurprd08.prod.outlook.com \ --to=honnappa.nagarahalli@arm.com \ --cc=Gavin.Hu@arm.com \ --cc=Joyce.Kong@arm.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=mb@smartsharesystems.com \ --cc=nd@arm.com \ --cc=ravi1.kumar@amd.com \ --cc=rmody@marvell.com \ --cc=shshaikh@marvell.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=xuanziyang2@huawei.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git