From: Andrew Rybchenko <arybchenko@solarflare.com> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, John McNamara <john.mcnamara@intel.com>, "Marko Kovacevic" <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 3/7] ethdev: add flow action type update as an offload Date: Sun, 18 Aug 2019 12:46:55 +0300 Message-ID: <e1f884b3-9d92-b417-f628-a5abb2356572@solarflare.com> (raw) In-Reply-To: <CY4PR1801MB186343CAD07C1D59443165D8DEAE0@CY4PR1801MB1863.namprd18.prod.outlook.com> On 8/17/19 5:23 PM, Pavan Nikhilesh Bhagavatula wrote: >>> enable/disable PMDs write to `rte_mbuf::hash::fdir::hi`. >> Notes similar to RSS hash. >> >> It requires better motivation why. It lets Rx queue know that >> it will be used as flow action MARK target and the queue should >> be configured to deliver the mark from NIC to PMD and processed >> in the driver. >> >> Also I think that flow API action MARK documentation should be >> updated to mentioned the offload. > Ack will reword the commit log and update the documentation. >>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> >>> --- >>> doc/guides/nics/features.rst | 12 ++++++++++++ >>> lib/librte_ethdev/rte_ethdev.h | 1 + >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/doc/guides/nics/features.rst >> b/doc/guides/nics/features.rst >>> index f79b69b38..d67430d90 100644 >>> --- a/doc/guides/nics/features.rst >>> +++ b/doc/guides/nics/features.rst >>> @@ -594,6 +594,18 @@ application to set ptypes it is interested in. >>> * **[provides] mbuf**: ``mbuf.packet_type``. >>> >>> >>> +.. _nic_features_flow_action_type_update: >> May be _nic_features_flow_mark ? >> >>> + >>> +Flow type update >> May be "Flow mark delivery" ? > I named it flow action type update because we use the same flag to represent two different > flow types i.e. RTE_FLOW_ACTION_TYPE_FLAG and RTE_FLOW_ACTION_TYPE_MARK. > > I'm not so sure about the name RX_OFFLOAD_FLOW_MARK too because mbuf might have ol_flags > marked for ACTION_TYPE_FLAG. Let me know your thoughts on this. I forgot about RTE_FLOW_ACTION_TYPE_FLAG and really care about mark only since it is 32-bit vs one. Anyway may be it is more correct to care about both. If so, may be _nic_features_flow_flag_mark and "Flow flag/mark update"? > I will modify the name once we come to an agreement. > >>> +---------------- >>> + >>> +Supports flow action type update to ``mbuf.ol_flags`` and >> ``mbuf.hash.fdir.hi``. >>> + >>> +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: >> ``offloads:DEV_RX_OFFLOAD_FLOW_TYPE``. >> >> DEV_RX_OFFLOAD_FLOW_MARK, not TYPE. > Ack, will fix in v2. > >> >> >>> +* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_FDIR``, >> ``mbuf.ol_flags:PKT_RX_FDIR_ID;``, >>> + ``mbuf.hash.fdir.hi`` >>> + >>> + >>> .. _nic_features_timesync: >>> >>> Timesync >>> diff --git a/lib/librte_ethdev/rte_ethdev.h >> b/lib/librte_ethdev/rte_ethdev.h >>> index 889486a11..4a0cff830 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -1014,6 +1014,7 @@ struct rte_eth_conf { >>> #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 >>> #define DEV_RX_OFFLOAD_OUTER_Udrivers/net/sfc/base/rhead_ev.c.origDP_CKSUM 0x00040000 >>> #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 >>> +#define DEV_RX_OFFLOAD_FLOW_MARK 0x00100000 >>> >>> #define DEV_RX_OFFLOAD_CHECKSUM >> (DEV_RX_OFFLOAD_IPV4_CKSUM | \ >>> DEV_RX_OFFLOAD_UDP_CKSUM | \ >> Add to rte_rx_offload_names
next prev parent reply index Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-16 5:55 [dpdk-dev] [PATCH 0/7] ethdev: add new Rx offload flags pbhagavatula 2019-08-16 5:55 ` [dpdk-dev] [PATCH 1/7] ethdev: add set ptype function pbhagavatula 2019-08-16 8:22 ` Andrew Rybchenko 2019-08-17 16:27 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2019-08-16 5:55 ` [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload pbhagavatula 2019-08-16 7:48 ` Andrew Rybchenko 2019-08-17 11:47 ` Pavan Nikhilesh Bhagavatula 2019-08-18 4:52 ` Shahaf Shuler 2019-08-18 5:38 ` Andrew Rybchenko 2019-08-18 6:18 ` Shahaf Shuler 2019-08-18 7:00 ` Andrew Rybchenko 2019-08-18 12:11 ` Shahaf Shuler 2019-08-16 5:55 ` [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as an offload pbhagavatula 2019-08-16 8:05 ` Andrew Rybchenko 2019-08-17 14:23 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2019-08-18 9:46 ` Andrew Rybchenko [this message] 2019-08-18 4:59 ` [dpdk-dev] " Shahaf Shuler 2019-08-18 5:57 ` Andrew Rybchenko 2019-08-18 6:20 ` Shahaf Shuler 2019-08-18 7:08 ` Andrew Rybchenko 2019-08-16 5:55 ` [dpdk-dev] [PATCH 4/7] net: update Rx RSS hash offload capabilities pbhagavatula 2019-08-16 7:49 ` Andrew Rybchenko 2019-08-17 12:26 ` Pavan Nikhilesh Bhagavatula 2019-08-16 5:55 ` [dpdk-dev] [PATCH 5/7] net: update Rx flow action " pbhagavatula 2019-08-16 7:50 ` Andrew Rybchenko 2019-08-16 5:55 ` [dpdk-dev] [PATCH 6/7] net: add ptype set default functionality pbhagavatula 2019-08-16 8:30 ` Andrew Rybchenko 2019-08-17 17:24 ` Pavan Nikhilesh Bhagavatula 2019-08-16 5:55 ` [dpdk-dev] [PATCH 7/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula 2019-08-16 6:01 ` Jerin Jacob Kollanukkaran 2019-08-16 6:02 ` [dpdk-dev] [PATCH 0/7] ethdev: add new Rx offload flags Jerin Jacob Kollanukkaran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e1f884b3-9d92-b417-f628-a5abb2356572@solarflare.com \ --to=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jerinj@marvell.com \ --cc=john.mcnamara@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=pbhagavatula@marvell.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git