* [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2 [not found] <1437478142-416-1-git-send-email-maarten.lankhorst@linux.intel.com> @ 2015-07-21 11:28 ` Maarten Lankhorst 2015-07-23 12:27 ` Ander Conselvan De Oliveira 2015-07-21 11:28 ` [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush Maarten Lankhorst 1 sibling, 1 reply; 6+ messages in thread From: Maarten Lankhorst @ 2015-07-21 11:28 UTC (permalink / raw) To: intel-gfx; +Cc: dri-devel This can be a separate case from mode_changed, when connectors stay the same but only the mode is different. Drivers may choose to implement specific optimizations to prevent a full modeset for this case. Changes since v1: - Update kerneldocs slightly. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 39 +++++++++++++++++++++++++++--------- drivers/gpu/drm/i915/intel_display.c | 2 +- include/drm/drm_atomic.h | 3 ++- include/drm/drm_crtc.h | 8 +++++--- 4 files changed, 38 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 0ea8c5d476ef..ac6601071414 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -124,7 +124,7 @@ steal_encoder(struct drm_atomic_state *state, if (IS_ERR(crtc_state)) return PTR_ERR(crtc_state); - crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; list_for_each_entry(connector, &config->connector_list, head) { if (connector->state->best_encoder != encoder) @@ -174,14 +174,14 @@ update_connector_routing(struct drm_atomic_state *state, int conn_idx) idx = drm_crtc_index(connector->state->crtc); crtc_state = state->crtc_states[idx]; - crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; } if (connector_state->crtc) { idx = drm_crtc_index(connector_state->crtc); crtc_state = state->crtc_states[idx]; - crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; } } @@ -233,7 +233,7 @@ update_connector_routing(struct drm_atomic_state *state, int conn_idx) idx = drm_crtc_index(connector_state->crtc); crtc_state = state->crtc_states[idx]; - crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; DRM_DEBUG_ATOMIC("[CONNECTOR:%d:%s] using [ENCODER:%d:%s] on [CRTC:%d]\n", connector->base.id, @@ -256,7 +256,8 @@ mode_fixup(struct drm_atomic_state *state) bool ret; for_each_crtc_in_state(state, crtc, crtc_state, i) { - if (!crtc_state->mode_changed) + if (!crtc_state->mode_changed && + !crtc_state->connectors_changed) continue; drm_mode_copy(&crtc_state->adjusted_mode, &crtc_state->mode); @@ -312,7 +313,8 @@ mode_fixup(struct drm_atomic_state *state) for_each_crtc_in_state(state, crtc, crtc_state, i) { const struct drm_crtc_helper_funcs *funcs; - if (!crtc_state->mode_changed) + if (!crtc_state->mode_changed && + !crtc_state->connectors_changed) continue; funcs = crtc->helper_private; @@ -338,9 +340,14 @@ mode_fixup(struct drm_atomic_state *state) * * Check the state object to see if the requested state is physically possible. * This does all the crtc and connector related computations for an atomic - * update. It computes and updates crtc_state->mode_changed, adds any additional - * connectors needed for full modesets and calls down into ->mode_fixup - * functions of the driver backend. + * update and adds any additional connectors needed for full modesets and calls + * down into ->mode_fixup functions of the driver backend. + * + * crtc_state->mode_changed is set when the input mode is changed. + * crtc_state->connectors_changed is set when a connector is added or + * removed from the crtc. + * crtc_state->active_changed is set when crtc_state->active changes, + * which is used for dpms. * * IMPORTANT: * @@ -373,7 +380,17 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, if (crtc->state->enable != crtc_state->enable) { DRM_DEBUG_ATOMIC("[CRTC:%d] enable changed\n", crtc->base.id); + + /* + * For clarity this assignment is done here, but + * enable == 0 is only true when there are no + * connectors and a NULL mode. + * + * The other way around is true as well. enable != 0 + * iff connectors are attached and a mode is set. + */ crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; } } @@ -448,6 +465,9 @@ EXPORT_SYMBOL(drm_atomic_helper_check_modeset); * This does all the plane update related checks using by calling into the * ->atomic_check hooks provided by the driver. * + * It also sets crtc_state->planes_changed to indicate that a crtc has + * updated planes. + * * RETURNS * Zero for success or -errno */ @@ -2081,6 +2101,7 @@ void __drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc, state->mode_changed = false; state->active_changed = false; state->planes_changed = false; + state->connectors_changed = false; state->event = NULL; } EXPORT_SYMBOL(__drm_atomic_helper_crtc_duplicate_state); diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 6867267115ce..671ca2820f82 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -413,7 +413,7 @@ static const intel_limit_t intel_limits_bxt = { static bool needs_modeset(struct drm_crtc_state *state) { - return state->mode_changed || state->active_changed; + return drm_atomic_crtc_needs_modeset(state); } /** diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 8a3a913320eb..e67aeac2aee0 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -166,7 +166,8 @@ int __must_check drm_atomic_async_commit(struct drm_atomic_state *state); static inline bool drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state) { - return state->mode_changed || state->active_changed; + return state->mode_changed || state->active_changed || + state->connectors_changed; } diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8159a0627b6b..3628bd89abf6 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -255,12 +255,13 @@ struct drm_atomic_state; * @crtc: backpointer to the CRTC * @enable: whether the CRTC should be enabled, gates all other state * @active: whether the CRTC is actively displaying (used for DPMS) - * @mode_changed: for use by helpers and drivers when computing state updates - * @active_changed: for use by helpers and drivers when computing state updates + * @planes_changed: planes on this crtc are updated + * @mode_changed: crtc_state->mode or crtc_state->enable has been changed + * @active_changed: crtc_state->active has been toggled. + * @connectors_changed: connectors to this crtc have been updated * @plane_mask: bitmask of (1 << drm_plane_index(plane)) of attached planes * @last_vblank_count: for helpers and drivers to capture the vblank of the * update to ensure framebuffer cleanup isn't done too early - * @planes_changed: for use by helpers and drivers when computing state updates * @adjusted_mode: for use by helpers and drivers to compute adjusted mode timings * @mode: current mode timings * @event: optional pointer to a DRM event to signal upon completion of the @@ -283,6 +284,7 @@ struct drm_crtc_state { bool planes_changed : 1; bool mode_changed : 1; bool active_changed : 1; + bool connectors_changed : 1; /* attached planes bitmask: * WARNING: transitional helpers do not maintain plane_mask so -- 2.1.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2 2015-07-21 11:28 ` [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2 Maarten Lankhorst @ 2015-07-23 12:27 ` Ander Conselvan De Oliveira 0 siblings, 0 replies; 6+ messages in thread From: Ander Conselvan De Oliveira @ 2015-07-23 12:27 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx; +Cc: dri-devel On Tue, 2015-07-21 at 13:28 +0200, Maarten Lankhorst wrote: > This can be a separate case from mode_changed, when connectors stay > the > same but only the mode is different. Drivers may choose to implement > specific > optimizations to prevent a full modeset for this case. > > Changes since v1: > - Update kerneldocs slightly. > > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> I have a couple of nits below, but anyway, Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com> > --- > drivers/gpu/drm/drm_atomic_helper.c | 39 > +++++++++++++++++++++++++++--------- > drivers/gpu/drm/i915/intel_display.c | 2 +- > include/drm/drm_atomic.h | 3 ++- > include/drm/drm_crtc.h | 8 +++++--- > 4 files changed, 38 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index 0ea8c5d476ef..ac6601071414 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -124,7 +124,7 @@ steal_encoder(struct drm_atomic_state *state, > if (IS_ERR(crtc_state)) > return PTR_ERR(crtc_state); > > - crtc_state->mode_changed = true; > + crtc_state->connectors_changed = true; > > list_for_each_entry(connector, &config->connector_list, > head) { > if (connector->state->best_encoder != encoder) > @@ -174,14 +174,14 @@ update_connector_routing(struct > drm_atomic_state *state, int conn_idx) > idx = drm_crtc_index(connector->state > ->crtc); > > crtc_state = state->crtc_states[idx]; > - crtc_state->mode_changed = true; > + crtc_state->connectors_changed = true; > } > > if (connector_state->crtc) { > idx = drm_crtc_index(connector_state->crtc); > > crtc_state = state->crtc_states[idx]; > - crtc_state->mode_changed = true; > + crtc_state->connectors_changed = true; > } > } > > @@ -233,7 +233,7 @@ update_connector_routing(struct drm_atomic_state > *state, int conn_idx) > idx = drm_crtc_index(connector_state->crtc); > > crtc_state = state->crtc_states[idx]; > - crtc_state->mode_changed = true; > + crtc_state->connectors_changed = true; > There's a comment above the call to update_connector_routing() that mentions setting crtc_state->mode_changed. That should be updated to reflect the changes above. > DRM_DEBUG_ATOMIC("[CONNECTOR:%d:%s] using [ENCODER:%d:%s] on > [CRTC:%d]\n", > connector->base.id, > [...] > @@ -338,9 +340,14 @@ mode_fixup(struct drm_atomic_state *state) > * > * Check the state object to see if the requested state is physically possible. > * This does all the crtc and connector related computations for an atomic > - * update. It computes and updates crtc_state->mode_changed, adds any additional > - * connectors needed for full modesets and calls down into ->mode_fixup > - * functions of the driver backend. > + * update and adds any additional connectors needed for full modesets and calls The first 'and' should be replaced with a comma. [...] Ander _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush. [not found] <1437478142-416-1-git-send-email-maarten.lankhorst@linux.intel.com> 2015-07-21 11:28 ` [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2 Maarten Lankhorst @ 2015-07-21 11:28 ` Maarten Lankhorst 2015-07-23 12:37 ` Ander Conselvan De Oliveira 2015-08-05 6:18 ` Tomi Valkeinen 1 sibling, 2 replies; 6+ messages in thread From: Maarten Lankhorst @ 2015-07-21 11:28 UTC (permalink / raw) To: intel-gfx; +Cc: dri-devel In intel it's useful to keep track of some state changes with old crtc state vs new state, for example to disable initial planes or when a modeset's prevented during fastboot. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++-- drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- drivers/gpu/drm/drm_plane_helper.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 10 ++++++---- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++-- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++-- drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++-- drivers/gpu/drm/tegra/dc.c | 6 ++++-- include/drm/drm_crtc_helper.h | 6 ++++-- 10 files changed, 40 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index f69b92535505..8b8fe3762ca9 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -239,7 +239,8 @@ static int atmel_hlcdc_crtc_atomic_check(struct drm_crtc *c, return atmel_hlcdc_plane_prepare_disc_area(s); } -static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c) +static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c, + struct drm_crtc_state *old_s) { struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c); @@ -253,7 +254,8 @@ static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c) } } -static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc) +static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_s) { /* TODO: write common plane control register if available */ } diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index ac6601071414..4a48d76c4fb1 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1170,7 +1170,7 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, if (!funcs || !funcs->atomic_begin) continue; - funcs->atomic_begin(crtc); + funcs->atomic_begin(crtc, old_crtc_state); } for_each_plane_in_state(old_state, plane, old_plane_state, i) { @@ -1200,7 +1200,7 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, if (!funcs || !funcs->atomic_flush) continue; - funcs->atomic_flush(crtc); + funcs->atomic_flush(crtc, old_crtc_state); } } EXPORT_SYMBOL(drm_atomic_helper_commit_planes); @@ -1236,7 +1236,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) crtc_funcs = crtc->helper_private; if (crtc_funcs && crtc_funcs->atomic_begin) - crtc_funcs->atomic_begin(crtc); + crtc_funcs->atomic_begin(crtc, old_crtc_state); drm_for_each_plane_mask(plane, crtc->dev, plane_mask) { struct drm_plane_state *old_plane_state = @@ -1259,7 +1259,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) } if (crtc_funcs && crtc_funcs->atomic_flush) - crtc_funcs->atomic_flush(crtc); + crtc_funcs->atomic_flush(crtc, old_crtc_state); } EXPORT_SYMBOL(drm_atomic_helper_commit_planes_on_crtc); diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index 03b7afe455e6..cb5dab4c4337 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c @@ -436,7 +436,7 @@ int drm_plane_helper_commit(struct drm_plane *plane, for (i = 0; i < 2; i++) { if (crtc_funcs[i] && crtc_funcs[i]->atomic_begin) - crtc_funcs[i]->atomic_begin(crtc[i]); + crtc_funcs[i]->atomic_begin(crtc[i], crtc[i]->state); } /* @@ -451,7 +451,7 @@ int drm_plane_helper_commit(struct drm_plane *plane, for (i = 0; i < 2; i++) { if (crtc_funcs[i] && crtc_funcs[i]->atomic_flush) - crtc_funcs[i]->atomic_flush(crtc[i]); + crtc_funcs[i]->atomic_flush(crtc[i], crtc[i]->state); } /* diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 671ca2820f82..def9444eeae2 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -102,8 +102,8 @@ static void vlv_prepare_pll(struct intel_crtc *crtc, const struct intel_crtc_state *pipe_config); static void chv_prepare_pll(struct intel_crtc *crtc, const struct intel_crtc_state *pipe_config); -static void intel_begin_crtc_commit(struct drm_crtc *crtc); -static void intel_finish_crtc_commit(struct drm_crtc *crtc); +static void intel_begin_crtc_commit(struct drm_crtc *, struct drm_crtc_state *); +static void intel_finish_crtc_commit(struct drm_crtc *, struct drm_crtc_state *); static void skl_init_scalers(struct drm_device *dev, struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state); static int i9xx_get_refclk(const struct intel_crtc_state *crtc_state, @@ -13440,7 +13440,8 @@ intel_disable_primary_plane(struct drm_plane *plane, dev_priv->display.update_primary_plane(crtc, NULL, 0, 0); } -static void intel_begin_crtc_commit(struct drm_crtc *crtc) +static void intel_begin_crtc_commit(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct drm_device *dev = crtc->dev; struct intel_crtc *intel_crtc = to_intel_crtc(crtc); @@ -13456,7 +13457,8 @@ static void intel_begin_crtc_commit(struct drm_crtc *crtc) skl_detach_scalers(intel_crtc); } -static void intel_finish_crtc_commit(struct drm_crtc *crtc) +static void intel_finish_crtc_commit(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct intel_crtc *intel_crtc = to_intel_crtc(crtc); diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c index c4bb9d9c7667..4dc158ed2e95 100644 --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c @@ -334,13 +334,15 @@ static int mdp4_crtc_atomic_check(struct drm_crtc *crtc, return 0; } -static void mdp4_crtc_atomic_begin(struct drm_crtc *crtc) +static void mdp4_crtc_atomic_begin(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc); DBG("%s: begin", mdp4_crtc->name); } -static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc) +static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc); struct drm_device *dev = crtc->dev; diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c index dea3d2e559b1..4c1df4e6e5bc 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c @@ -388,13 +388,15 @@ static int mdp5_crtc_atomic_check(struct drm_crtc *crtc, return 0; } -static void mdp5_crtc_atomic_begin(struct drm_crtc *crtc) +static void mdp5_crtc_atomic_begin(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc); DBG("%s: begin", mdp5_crtc->name); } -static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc) +static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc); struct drm_device *dev = crtc->dev; diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 65d6ba6621ac..48cb19949ca3 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c @@ -496,7 +496,8 @@ static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc, return true; } -static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc) +static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct drm_pending_vblank_event *event = crtc->state->event; struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc); @@ -512,7 +513,8 @@ static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc) } } -static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc) +static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc); diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c b/drivers/gpu/drm/sti/sti_drm_crtc.c index 6b641c5a2ec7..26e63bf14efe 100644 --- a/drivers/gpu/drm/sti/sti_drm_crtc.c +++ b/drivers/gpu/drm/sti/sti_drm_crtc.c @@ -164,7 +164,8 @@ sti_drm_crtc_mode_set_nofb(struct drm_crtc *crtc) sti_drm_crtc_mode_set(crtc, &crtc->state->adjusted_mode); } -static void sti_drm_atomic_begin(struct drm_crtc *crtc) +static void sti_drm_atomic_begin(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct sti_mixer *mixer = to_sti_mixer(crtc); @@ -178,7 +179,8 @@ static void sti_drm_atomic_begin(struct drm_crtc *crtc) } } -static void sti_drm_atomic_flush(struct drm_crtc *crtc) +static void sti_drm_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { } diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index d447701173e6..24b38090dfd3 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -1275,7 +1275,8 @@ static int tegra_crtc_atomic_check(struct drm_crtc *crtc, return 0; } -static void tegra_crtc_atomic_begin(struct drm_crtc *crtc) +static void tegra_crtc_atomic_begin(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct tegra_dc *dc = to_tegra_dc(crtc); @@ -1289,7 +1290,8 @@ static void tegra_crtc_atomic_begin(struct drm_crtc *crtc) } } -static void tegra_crtc_atomic_flush(struct drm_crtc *crtc) +static void tegra_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state) { struct tegra_dc_state *state = to_dc_state(crtc->state); struct tegra_dc *dc = to_tegra_dc(crtc); diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h index 4562bd12bb4a..800e0d1cf32c 100644 --- a/include/drm/drm_crtc_helper.h +++ b/include/drm/drm_crtc_helper.h @@ -108,8 +108,10 @@ struct drm_crtc_helper_funcs { /* atomic helpers */ int (*atomic_check)(struct drm_crtc *crtc, struct drm_crtc_state *state); - void (*atomic_begin)(struct drm_crtc *crtc); - void (*atomic_flush)(struct drm_crtc *crtc); + void (*atomic_begin)(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state); + void (*atomic_flush)(struct drm_crtc *crtc, + struct drm_crtc_state *old_crtc_state); }; /** -- 2.1.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush. 2015-07-21 11:28 ` [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush Maarten Lankhorst @ 2015-07-23 12:37 ` Ander Conselvan De Oliveira 2015-08-05 6:18 ` Tomi Valkeinen 1 sibling, 0 replies; 6+ messages in thread From: Ander Conselvan De Oliveira @ 2015-07-23 12:37 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx; +Cc: dri-devel Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com> On Tue, 2015-07-21 at 13:28 +0200, Maarten Lankhorst wrote: > In intel it's useful to keep track of some state changes with old > crtc state vs new state, for example to disable initial planes or > when a modeset's prevented during fastboot. > > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++-- > drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- > drivers/gpu/drm/drm_plane_helper.c | 4 ++-- > drivers/gpu/drm/i915/intel_display.c | 10 ++++++---- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++-- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++-- > drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++-- > drivers/gpu/drm/tegra/dc.c | 6 ++++-- > include/drm/drm_crtc_helper.h | 6 ++++-- > 10 files changed, 40 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index f69b92535505..8b8fe3762ca9 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -239,7 +239,8 @@ static int atmel_hlcdc_crtc_atomic_check(struct > drm_crtc *c, > return atmel_hlcdc_plane_prepare_disc_area(s); > } > > -static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c) > +static void atmel_hlcdc_crtc_atomic_begin(struct drm_crtc *c, > + struct drm_crtc_state > *old_s) > { > struct atmel_hlcdc_crtc *crtc = > drm_crtc_to_atmel_hlcdc_crtc(c); > > @@ -253,7 +254,8 @@ static void atmel_hlcdc_crtc_atomic_begin(struct > drm_crtc *c) > } > } > > -static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc) > +static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_s) > { > /* TODO: write common plane control register if available */ > } > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index ac6601071414..4a48d76c4fb1 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -1170,7 +1170,7 @@ void drm_atomic_helper_commit_planes(struct > drm_device *dev, > if (!funcs || !funcs->atomic_begin) > continue; > > - funcs->atomic_begin(crtc); > + funcs->atomic_begin(crtc, old_crtc_state); > } > > for_each_plane_in_state(old_state, plane, old_plane_state, > i) { > @@ -1200,7 +1200,7 @@ void drm_atomic_helper_commit_planes(struct > drm_device *dev, > if (!funcs || !funcs->atomic_flush) > continue; > > - funcs->atomic_flush(crtc); > + funcs->atomic_flush(crtc, old_crtc_state); > } > } > EXPORT_SYMBOL(drm_atomic_helper_commit_planes); > @@ -1236,7 +1236,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct > drm_crtc_state *old_crtc_state) > > crtc_funcs = crtc->helper_private; > if (crtc_funcs && crtc_funcs->atomic_begin) > - crtc_funcs->atomic_begin(crtc); > + crtc_funcs->atomic_begin(crtc, old_crtc_state); > > drm_for_each_plane_mask(plane, crtc->dev, plane_mask) { > struct drm_plane_state *old_plane_state = > @@ -1259,7 +1259,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct > drm_crtc_state *old_crtc_state) > } > > if (crtc_funcs && crtc_funcs->atomic_flush) > - crtc_funcs->atomic_flush(crtc); > + crtc_funcs->atomic_flush(crtc, old_crtc_state); > } > EXPORT_SYMBOL(drm_atomic_helper_commit_planes_on_crtc); > > diff --git a/drivers/gpu/drm/drm_plane_helper.c > b/drivers/gpu/drm/drm_plane_helper.c > index 03b7afe455e6..cb5dab4c4337 100644 > --- a/drivers/gpu/drm/drm_plane_helper.c > +++ b/drivers/gpu/drm/drm_plane_helper.c > @@ -436,7 +436,7 @@ int drm_plane_helper_commit(struct drm_plane > *plane, > > for (i = 0; i < 2; i++) { > if (crtc_funcs[i] && crtc_funcs[i]->atomic_begin) > - crtc_funcs[i]->atomic_begin(crtc[i]); > + crtc_funcs[i]->atomic_begin(crtc[i], crtc[i] > ->state); > } > > /* > @@ -451,7 +451,7 @@ int drm_plane_helper_commit(struct drm_plane > *plane, > > for (i = 0; i < 2; i++) { > if (crtc_funcs[i] && crtc_funcs[i]->atomic_flush) > - crtc_funcs[i]->atomic_flush(crtc[i]); > + crtc_funcs[i]->atomic_flush(crtc[i], crtc[i] > ->state); > } > > /* > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 671ca2820f82..def9444eeae2 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -102,8 +102,8 @@ static void vlv_prepare_pll(struct intel_crtc > *crtc, > const struct intel_crtc_state > *pipe_config); > static void chv_prepare_pll(struct intel_crtc *crtc, > const struct intel_crtc_state > *pipe_config); > -static void intel_begin_crtc_commit(struct drm_crtc *crtc); > -static void intel_finish_crtc_commit(struct drm_crtc *crtc); > +static void intel_begin_crtc_commit(struct drm_crtc *, struct > drm_crtc_state *); > +static void intel_finish_crtc_commit(struct drm_crtc *, struct > drm_crtc_state *); > static void skl_init_scalers(struct drm_device *dev, struct > intel_crtc *intel_crtc, > struct intel_crtc_state *crtc_state); > static int i9xx_get_refclk(const struct intel_crtc_state > *crtc_state, > @@ -13440,7 +13440,8 @@ intel_disable_primary_plane(struct drm_plane > *plane, > dev_priv->display.update_primary_plane(crtc, NULL, 0, 0); > } > > -static void intel_begin_crtc_commit(struct drm_crtc *crtc) > +static void intel_begin_crtc_commit(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct drm_device *dev = crtc->dev; > struct intel_crtc *intel_crtc = to_intel_crtc(crtc); > @@ -13456,7 +13457,8 @@ static void intel_begin_crtc_commit(struct > drm_crtc *crtc) > skl_detach_scalers(intel_crtc); > } > > -static void intel_finish_crtc_commit(struct drm_crtc *crtc) > +static void intel_finish_crtc_commit(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct intel_crtc *intel_crtc = to_intel_crtc(crtc); > > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > index c4bb9d9c7667..4dc158ed2e95 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c > @@ -334,13 +334,15 @@ static int mdp4_crtc_atomic_check(struct > drm_crtc *crtc, > return 0; > } > > -static void mdp4_crtc_atomic_begin(struct drm_crtc *crtc) > +static void mdp4_crtc_atomic_begin(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc); > DBG("%s: begin", mdp4_crtc->name); > } > > -static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc) > +static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct mdp4_crtc *mdp4_crtc = to_mdp4_crtc(crtc); > struct drm_device *dev = crtc->dev; > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > index dea3d2e559b1..4c1df4e6e5bc 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c > @@ -388,13 +388,15 @@ static int mdp5_crtc_atomic_check(struct > drm_crtc *crtc, > return 0; > } > > -static void mdp5_crtc_atomic_begin(struct drm_crtc *crtc) > +static void mdp5_crtc_atomic_begin(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc); > DBG("%s: begin", mdp5_crtc->name); > } > > -static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc) > +static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct mdp5_crtc *mdp5_crtc = to_mdp5_crtc(crtc); > struct drm_device *dev = crtc->dev; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > index 65d6ba6621ac..48cb19949ca3 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -496,7 +496,8 @@ static bool rcar_du_crtc_mode_fixup(struct > drm_crtc *crtc, > return true; > } > > -static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc) > +static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct drm_pending_vblank_event *event = crtc->state->event; > struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc); > @@ -512,7 +513,8 @@ static void rcar_du_crtc_atomic_begin(struct > drm_crtc *crtc) > } > } > > -static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc) > +static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc); > > diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c > b/drivers/gpu/drm/sti/sti_drm_crtc.c > index 6b641c5a2ec7..26e63bf14efe 100644 > --- a/drivers/gpu/drm/sti/sti_drm_crtc.c > +++ b/drivers/gpu/drm/sti/sti_drm_crtc.c > @@ -164,7 +164,8 @@ sti_drm_crtc_mode_set_nofb(struct drm_crtc *crtc) > sti_drm_crtc_mode_set(crtc, &crtc->state->adjusted_mode); > } > > -static void sti_drm_atomic_begin(struct drm_crtc *crtc) > +static void sti_drm_atomic_begin(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct sti_mixer *mixer = to_sti_mixer(crtc); > > @@ -178,7 +179,8 @@ static void sti_drm_atomic_begin(struct drm_crtc > *crtc) > } > } > > -static void sti_drm_atomic_flush(struct drm_crtc *crtc) > +static void sti_drm_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > } > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index d447701173e6..24b38090dfd3 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -1275,7 +1275,8 @@ static int tegra_crtc_atomic_check(struct > drm_crtc *crtc, > return 0; > } > > -static void tegra_crtc_atomic_begin(struct drm_crtc *crtc) > +static void tegra_crtc_atomic_begin(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct tegra_dc *dc = to_tegra_dc(crtc); > > @@ -1289,7 +1290,8 @@ static void tegra_crtc_atomic_begin(struct > drm_crtc *crtc) > } > } > > -static void tegra_crtc_atomic_flush(struct drm_crtc *crtc) > +static void tegra_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_crtc_state > *old_crtc_state) > { > struct tegra_dc_state *state = to_dc_state(crtc->state); > struct tegra_dc *dc = to_tegra_dc(crtc); > diff --git a/include/drm/drm_crtc_helper.h > b/include/drm/drm_crtc_helper.h > index 4562bd12bb4a..800e0d1cf32c 100644 > --- a/include/drm/drm_crtc_helper.h > +++ b/include/drm/drm_crtc_helper.h > @@ -108,8 +108,10 @@ struct drm_crtc_helper_funcs { > /* atomic helpers */ > int (*atomic_check)(struct drm_crtc *crtc, > struct drm_crtc_state *state); > - void (*atomic_begin)(struct drm_crtc *crtc); > - void (*atomic_flush)(struct drm_crtc *crtc); > + void (*atomic_begin)(struct drm_crtc *crtc, > + struct drm_crtc_state *old_crtc_state); > + void (*atomic_flush)(struct drm_crtc *crtc, > + struct drm_crtc_state *old_crtc_state); > }; > > /** _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush. 2015-07-21 11:28 ` [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush Maarten Lankhorst 2015-07-23 12:37 ` Ander Conselvan De Oliveira @ 2015-08-05 6:18 ` Tomi Valkeinen 2015-08-06 12:35 ` Maarten Lankhorst 1 sibling, 1 reply; 6+ messages in thread From: Tomi Valkeinen @ 2015-08-05 6:18 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 1586 bytes --] Hi, On 21/07/15 14:28, Maarten Lankhorst wrote: > In intel it's useful to keep track of some state changes with old > crtc state vs new state, for example to disable initial planes or > when a modeset's prevented during fastboot. > > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++-- > drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- > drivers/gpu/drm/drm_plane_helper.c | 4 ++-- > drivers/gpu/drm/i915/intel_display.c | 10 ++++++---- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++-- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++-- > drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++-- > drivers/gpu/drm/tegra/dc.c | 6 ++++-- > include/drm/drm_crtc_helper.h | 6 ++++-- > 10 files changed, 40 insertions(+), 24 deletions(-) Looks like this broke omapdrm in linux-next: drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: initialization from incompatible pointer type [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: (near initialization for ‘omap_crtc_helper_funcs.atomic_begin’) [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: initialization from incompatible pointer type [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: (near initialization for ‘omap_crtc_helper_funcs.atomic_flush’) [-Werror] Tomi [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush. 2015-08-05 6:18 ` Tomi Valkeinen @ 2015-08-06 12:35 ` Maarten Lankhorst 0 siblings, 0 replies; 6+ messages in thread From: Maarten Lankhorst @ 2015-08-06 12:35 UTC (permalink / raw) To: Tomi Valkeinen, intel-gfx; +Cc: dri-devel Hey, Op 05-08-15 om 08:18 schreef Tomi Valkeinen: > Hi, > > On 21/07/15 14:28, Maarten Lankhorst wrote: >> In intel it's useful to keep track of some state changes with old >> crtc state vs new state, for example to disable initial planes or >> when a modeset's prevented during fastboot. >> >> Cc: dri-devel@lists.freedesktop.org >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> --- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++-- >> drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- >> drivers/gpu/drm/drm_plane_helper.c | 4 ++-- >> drivers/gpu/drm/i915/intel_display.c | 10 ++++++---- >> drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++-- >> drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++-- >> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++-- >> drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++-- >> drivers/gpu/drm/tegra/dc.c | 6 ++++-- >> include/drm/drm_crtc_helper.h | 6 ++++-- >> 10 files changed, 40 insertions(+), 24 deletions(-) > Looks like this broke omapdrm in linux-next: > > drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: initialization from > incompatible pointer type [-Werror] > drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: (near initialization > for ‘omap_crtc_helper_funcs.atomic_begin’) [-Werror] > drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: initialization from > incompatible pointer type [-Werror] > drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: (near initialization > for ‘omap_crtc_helper_funcs.atomic_flush’) [-Werror] > > Tomi > This has been fixed up in topic/drm-misc? Compiles for me cleanly there. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-06 12:35 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1437478142-416-1-git-send-email-maarten.lankhorst@linux.intel.com> 2015-07-21 11:28 ` [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2 Maarten Lankhorst 2015-07-23 12:27 ` Ander Conselvan De Oliveira 2015-07-21 11:28 ` [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush Maarten Lankhorst 2015-07-23 12:37 ` Ander Conselvan De Oliveira 2015-08-05 6:18 ` Tomi Valkeinen 2015-08-06 12:35 ` Maarten Lankhorst
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).