* [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
@ 2019-03-04 20:20 ` Lubomir Rintel
2019-03-12 18:42 ` Rob Herring
2019-03-04 20:20 ` [PATCH v2 2/5] dt-bindings: display: armada: Rename the binding doc file Lubomir Rintel
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Lubomir Rintel @ 2019-03-04 20:20 UTC (permalink / raw)
To: Russell King
Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell
Armada framebuffer objects.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes since v1:
- Moved from bindings/display/armada/
- Removed the marvell,dove-framebuffer string
- Added to the MAINTAINERS entry
.../marvell,armada-framebuffer.txt | 22 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 23 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
diff --git a/Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt b/Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
new file mode 100644
index 000000000000..ab243e2bad45
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
@@ -0,0 +1,22 @@
+Marvell Armada framebuffer reserved memory
+==========================================
+
+Memory set aside for allocation of Marvell Armada framebuffer objects.
+
+Required properties:
+
+ - compatible: must be "marvell,armada-framebuffer"
+
+Please refer to Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
+for common reserved memory binding usage.
+
+Example:
+
+ reserved-memory {
+ display_reserved: framebuffer {
+ compatible = "marvell,armada-framebuffer";
+ size = <0x02000000>;
+ alignment = <0x02000000>;
+ no-map;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index f3a5c97e3419..e71aa05fef29 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8967,6 +8967,7 @@ T: git git://git.armlinux.org.uk/~rmk/linux-arm.git drm-armada-fixes
F: drivers/gpu/drm/armada/
F: include/uapi/drm/armada_drm.h
F: Documentation/devicetree/bindings/display/armada/
+F: Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
MARVELL CRYPTO DRIVER
M: Boris Brezillon <boris.brezillon@bootlin.com>
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer
2019-03-04 20:20 ` [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer Lubomir Rintel
@ 2019-03-12 18:42 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-03-12 18:42 UTC (permalink / raw)
Cc: Russell King, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
On Mon, 4 Mar 2019 21:20:02 +0100, Lubomir Rintel wrote:
> This is the binding for memory that is set aside for allocation of Marvell
> Armada framebuffer objects.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Moved from bindings/display/armada/
> - Removed the marvell,dove-framebuffer string
> - Added to the MAINTAINERS entry
>
> .../marvell,armada-framebuffer.txt | 22 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/5] dt-bindings: display: armada: Rename the binding doc file
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer Lubomir Rintel
@ 2019-03-04 20:20 ` Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation Lubomir Rintel
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Lubomir Rintel @ 2019-03-04 20:20 UTC (permalink / raw)
To: Russell King
Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
Use a more generic name, since it will document more compatible LCD
controllers than just that of Dove. Also, there's no point putting it in
a separate directory.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes since v1:
- Choose a better name than armada/marvell-armada-drm.txt, since
there will be no display-subsystem master node and thus it will
only document just the LCDC.
.../{armada/marvell,dove-lcd.txt => marvell,armada-lcdc.txt} | 0
MAINTAINERS | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename Documentation/devicetree/bindings/display/{armada/marvell,dove-lcd.txt => marvell,armada-lcdc.txt} (100%)
diff --git a/Documentation/devicetree/bindings/display/armada/marvell,dove-lcd.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
similarity index 100%
rename from Documentation/devicetree/bindings/display/armada/marvell,dove-lcd.txt
rename to Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
diff --git a/MAINTAINERS b/MAINTAINERS
index e71aa05fef29..890cbd6e0b7b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8966,7 +8966,7 @@ T: git git://git.armlinux.org.uk/~rmk/linux-arm.git drm-armada-devel
T: git git://git.armlinux.org.uk/~rmk/linux-arm.git drm-armada-fixes
F: drivers/gpu/drm/armada/
F: include/uapi/drm/armada_drm.h
-F: Documentation/devicetree/bindings/display/armada/
+F: Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
F: Documentation/devicetree/bindings/reserved-memory/marvell,armada-framebuffer.txt
MARVELL CRYPTO DRIVER
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 2/5] dt-bindings: display: armada: Rename the binding doc file Lubomir Rintel
@ 2019-03-04 20:20 ` Lubomir Rintel
2019-03-12 18:42 ` Rob Herring
2019-03-04 20:20 ` [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings Lubomir Rintel
2019-03-04 20:20 ` [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
4 siblings, 1 reply; 10+ messages in thread
From: Lubomir Rintel @ 2019-03-04 20:20 UTC (permalink / raw)
To: Russell King
Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
The port is a child, not a property. And should be accompanied by an
example. Plus a pair of cosmetic changes that don't seem to deserve a
separate commit.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes since v1:
- Minor adjustments to the commit message wording.
.../bindings/display/marvell,armada-lcdc.txt | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
index 46525ea3e646..2606a8efc956 100644
--- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
+++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
@@ -1,10 +1,11 @@
-Device Tree bindings for Armada DRM CRTC driver
+Marvell Armada LCD controller
+=============================
Required properties:
+
- compatible: value should be "marvell,dove-lcd".
- reg: base address and size of the LCD controller
- interrupts: single interrupt number for the LCD controller
- - port: video output port with endpoints, as described by graph.txt
Optional properties:
@@ -19,6 +20,11 @@ Note: all clocks are optional but at least one must be specified.
Further clocks may be added in the future according to requirements of
different SoCs.
+Required child nodes:
+
+- port: video output port with endpoints, as described by
+ Documentation/devicetree/bindings/graph.txt
+
Example:
lcd0: lcd-controller@820000 {
@@ -27,4 +33,10 @@ Example:
interrupts = <47>;
clocks = <&si5351 0>;
clock-names = "ext_ref_clk_1";
+
+ lcd0_port: port {
+ lcd0_rgb_out: endpoint {
+ remote-endpoint = <&encoder_rgb_in>;
+ };
+ };
};
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation
2019-03-04 20:20 ` [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation Lubomir Rintel
@ 2019-03-12 18:42 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-03-12 18:42 UTC (permalink / raw)
Cc: Russell King, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
On Mon, 4 Mar 2019 21:20:04 +0100, Lubomir Rintel wrote:
> The port is a child, not a property. And should be accompanied by an
> example. Plus a pair of cosmetic changes that don't seem to deserve a
> separate commit.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Minor adjustments to the commit message wording.
>
> .../bindings/display/marvell,armada-lcdc.txt | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
` (2 preceding siblings ...)
2019-03-04 20:20 ` [PATCH v2 3/5] dt-bindings: display: armada: Improve the LCDC documentation Lubomir Rintel
@ 2019-03-04 20:20 ` Lubomir Rintel
2019-03-12 18:42 ` Rob Herring
2019-03-04 20:20 ` [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
4 siblings, 1 reply; 10+ messages in thread
From: Lubomir Rintel @ 2019-03-04 20:20 UTC (permalink / raw)
To: Russell King
Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as
well, using the same binding.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes since v1:
- Added marvell,armada-lcdc compatible string.
.../devicetree/bindings/display/marvell,armada-lcdc.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
index 2606a8efc956..4ef66bc2845c 100644
--- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
+++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
@@ -3,7 +3,9 @@ Marvell Armada LCD controller
Required properties:
- - compatible: value should be "marvell,dove-lcd".
+ - compatible: value should be "marvell,armada-lcdc" along with
+ "marvell,dove-lcd" or "marvell,mmp2-lcd", depending on the
+ exact SoC model.
- reg: base address and size of the LCD controller
- interrupts: single interrupt number for the LCD controller
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings
2019-03-04 20:20 ` [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings Lubomir Rintel
@ 2019-03-12 18:42 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-03-12 18:42 UTC (permalink / raw)
To: Lubomir Rintel
Cc: Russell King, Mark Rutland, dri-devel, devicetree, linux-kernel
On Mon, Mar 04, 2019 at 09:20:05PM +0100, Lubomir Rintel wrote:
> There's a generic compatible string and the driver will work on a MMP2 as
> well, using the same binding.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Added marvell,armada-lcdc compatible string.
>
> .../devicetree/bindings/display/marvell,armada-lcdc.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> index 2606a8efc956..4ef66bc2845c 100644
> --- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> +++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
> @@ -3,7 +3,9 @@ Marvell Armada LCD controller
>
> Required properties:
>
> - - compatible: value should be "marvell,dove-lcd".
> + - compatible: value should be "marvell,armada-lcdc" along with
> + "marvell,dove-lcd" or "marvell,mmp2-lcd", depending on the
> + exact SoC model.
It is not exactly clear what the order is here. The preferred form is:
compatible: must be one of:
a
b
c
followed by 'fallback'
So "marvell,armada-lcdc" is the fallback, but you can't start requiring
the existing "marvell,dove-lcd" to have a fallback. At least you can't
depend on that.
> - reg: base address and size of the LCD controller
> - interrupts: single interrupt number for the LCD controller
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property
2019-03-04 20:20 [PATCH v2 0/5] dt-bindings: improve the Armada DRM bindings Lubomir Rintel
` (3 preceding siblings ...)
2019-03-04 20:20 ` [PATCH v2 4/5] dt-bindings: display: armada: Add more compatible strings Lubomir Rintel
@ 2019-03-04 20:20 ` Lubomir Rintel
2019-03-12 18:43 ` Rob Herring
4 siblings, 1 reply; 10+ messages in thread
From: Lubomir Rintel @ 2019-03-04 20:20 UTC (permalink / raw)
To: Russell King
Cc: Rob Herring, Mark Rutland, dri-devel, devicetree, linux-kernel,
Lubomir Rintel
This makes it possible to choose a different pixel format for the
endpoint. Modelled after what other LCD controllers use, including
marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
.../devicetree/bindings/display/marvell,armada-lcdc.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
index 4ef66bc2845c..181548d5be93 100644
--- a/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
+++ b/Documentation/devicetree/bindings/display/marvell,armada-lcdc.txt
@@ -26,6 +26,11 @@ Required child nodes:
- port: video output port with endpoints, as described by
Documentation/devicetree/bindings/graph.txt
+ The endpoints can optionally specify the following property:
+
+ - bus-width: recognized values are <12>, <16>, <18> and <24>, that
+ select "rgb444", "rgb565", "rgb666" or "rgb888" pixel format
+ respectively. Defaults to <24> if unspecified.
Example:
@@ -38,6 +43,7 @@ Example:
lcd0_port: port {
lcd0_rgb_out: endpoint {
+ bus-width = <24>;
remote-endpoint = <&encoder_rgb_in>;
};
};
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property
2019-03-04 20:20 ` [PATCH v2 5/5] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
@ 2019-03-12 18:43 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2019-03-12 18:43 UTC (permalink / raw)
Cc: Mark Rutland, devicetree, Russell King, dri-devel, linux-kernel,
Lubomir Rintel
On Mon, 4 Mar 2019 21:20:06 +0100, Lubomir Rintel wrote:
> This makes it possible to choose a different pixel format for the
> endpoint. Modelled after what other LCD controllers use, including
> marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> .../devicetree/bindings/display/marvell,armada-lcdc.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread