* [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
@ 2019-01-17 13:33 Alexander Shiyan
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
` (3 more replies)
0 siblings, 4 replies; 20+ messages in thread
From: Alexander Shiyan @ 2019-01-17 13:33 UTC (permalink / raw)
To: dri-devel
Cc: linux-fbdev, Alexander Shiyan, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, Lee Jones
We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
and BACKLIGHT_LCD_DEVICE) that do the same job.
The patch removes useless BACKLIGHT_LCD_SUPPORT option
and converts LCD_CLASS_DEVICE into a menu.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/unicore32/Kconfig | 1 -
drivers/gpu/drm/Kconfig | 2 --
drivers/gpu/drm/bridge/Kconfig | 1 -
drivers/gpu/drm/fsl-dcu/Kconfig | 1 -
drivers/gpu/drm/i915/Kconfig | 1 -
drivers/gpu/drm/nouveau/Kconfig | 2 --
drivers/gpu/drm/shmobile/Kconfig | 1 -
drivers/gpu/drm/tilcdc/Kconfig | 1 -
drivers/staging/olpc_dcon/Kconfig | 1 -
drivers/usb/misc/Kconfig | 1 -
drivers/video/backlight/Kconfig | 10 ++--------
drivers/video/fbdev/Kconfig | 5 -----
12 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
index c3a41bf..1138334 100644
--- a/arch/unicore32/Kconfig
+++ b/arch/unicore32/Kconfig
@@ -195,7 +195,6 @@ config I2C_EEPROM_AT24
config LCD_BACKLIGHT
tristate "LCD Backlight support"
- select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_PWM
endmenu
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4385f00..ef442a7 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -198,7 +198,6 @@ config DRM_RADEON
select POWER_SUPPLY
select HWMON
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
select INTERVAL_TREE
help
Choose this option if you have an ATI Radeon graphics card. There
@@ -219,7 +218,6 @@ config DRM_AMDGPU
select POWER_SUPPLY
select HWMON
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
select INTERVAL_TREE
select CHASH
help
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 2fee47b..5b5a8e5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -75,7 +75,6 @@ config DRM_PARADE_PS8622
depends on OF
select DRM_PANEL
select DRM_KMS_HELPER
- select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
---help---
Parade eDP-LVDS bridge chip driver.
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index 14a72c4..dc82588 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -2,7 +2,6 @@ config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
depends on DRM && OF && ARM && COMMON_CLK
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_PANEL
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 148be8e..3d5f1cb 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -15,7 +15,6 @@ config DRM_I915
select IRQ_WORK
# i915 depends on ACPI_VIDEO when ACPI is enabled
# but for select to work, need to select ACPI_VIDEO's dependencies, ick
- select BACKLIGHT_LCD_SUPPORT if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
select INPUT if ACPI
select ACPI_VIDEO if ACPI
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 432c440..fd7b869 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -5,14 +5,12 @@ config DRM_NOUVEAU
select DRM_KMS_HELPER
select DRM_TTM
select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
- select BACKLIGHT_LCD_SUPPORT if DRM_NOUVEAU_BACKLIGHT
select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT
select X86_PLATFORM_DEVICES if ACPI && X86
select ACPI_WMI if ACPI && X86
select MXM_WMI if ACPI && X86
select POWER_SUPPLY
# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
- select BACKLIGHT_LCD_SUPPORT if ACPI && X86
select BACKLIGHT_CLASS_DEVICE if ACPI && X86
select INPUT if ACPI && X86
select THERMAL if ACPI && X86
diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index 61bbe8e..e2a6c82 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
@@ -4,7 +4,6 @@ config DRM_SHMOBILE
depends on DRM && ARM
depends on ARCH_SHMOBILE || COMPILE_TEST
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 5259804..cb7df20 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -8,7 +8,6 @@ config DRM_TILCDC
select DRM_PANEL_BRIDGE
select VIDEOMODE_HELPERS
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
help
Choose this option if you have an TI SoC with LCDC display
controller, for example AM33xx in beagle-bone, DA8xx, or
diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
index 192cc8d..c91a56f 100644
--- a/drivers/staging/olpc_dcon/Kconfig
+++ b/drivers/staging/olpc_dcon/Kconfig
@@ -2,7 +2,6 @@ config FB_OLPC_DCON
tristate "One Laptop Per Child Display CONtroller support"
depends on OLPC && FB
depends on I2C
- depends on BACKLIGHT_LCD_SUPPORT
depends on (GPIO_CS5535 || GPIO_CS5535=n)
select BACKLIGHT_CLASS_DEVICE
help
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 68d2f2c..a86a80b 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -141,7 +141,6 @@ config USB_FTDI_ELAN
config USB_APPLEDISPLAY
tristate "Apple Cinema Display support"
- select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
help
Say Y here if you want to control the backlight of Apple Cinema
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 71ee978..3fdc18e 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -2,13 +2,7 @@
# Backlight & LCD drivers configuration
#
-menuconfig BACKLIGHT_LCD_SUPPORT
- bool "Backlight & LCD device support"
- help
- Enable this to be able to choose the drivers for controlling the
- backlight and the LCD panel on some platforms, for example on PDAs.
-
-if BACKLIGHT_LCD_SUPPORT
+menu "Backlight & LCD device support"
#
# LCD
@@ -466,4 +460,4 @@ config BACKLIGHT_RAVE_SP
endif # BACKLIGHT_CLASS_DEVICE
-endif # BACKLIGHT_LCD_SUPPORT
+endmenu
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index ae7712c..7b5c404 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -186,7 +186,6 @@ config FB_MACMODES
config FB_BACKLIGHT
tristate
depends on FB
- select BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
config FB_MODE_HELPERS
@@ -281,7 +280,6 @@ config FB_ARMCLCD
select FB_CFB_IMAGEBLIT
select FB_MODE_HELPERS if OF
select VIDEOMODE_HELPERS if OF
- select BACKLIGHT_LCD_SUPPORT if OF
select BACKLIGHT_CLASS_DEVICE if OF
help
This framebuffer device driver is for the ARM PrimeCell PL110
@@ -315,7 +313,6 @@ config FB_ACORN
config FB_CLPS711X
tristate "CLPS711X LCD support"
depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
- select BACKLIGHT_LCD_SUPPORT
select FB_MODE_HELPERS
select FB_SYS_FILLRECT
select FB_SYS_COPYAREA
@@ -343,7 +340,6 @@ config FB_SA1100
config FB_IMX
tristate "Freescale i.MX1/21/25/27 LCD support"
depends on FB && ARCH_MXC
- select BACKLIGHT_LCD_SUPPORT
select LCD_CLASS_DEVICE
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
@@ -2192,7 +2188,6 @@ config FB_MX3
tristate "MX3 Framebuffer support"
depends on FB && MX3_IPU
select BACKLIGHT_CLASS_DEVICE
- select BACKLIGHT_LCD_SUPPORT
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
--
2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies
2019-01-17 13:33 [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Alexander Shiyan
@ 2019-01-17 13:33 ` Alexander Shiyan
2019-01-17 16:18 ` Daniel Thompson
` (2 more replies)
2019-01-17 16:19 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Daniel Thompson
` (2 subsequent siblings)
3 siblings, 3 replies; 20+ messages in thread
From: Alexander Shiyan @ 2019-01-17 13:33 UTC (permalink / raw)
To: dri-devel
Cc: linux-fbdev, Alexander Shiyan, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, Lee Jones
This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
that are already placed under #if BACKLIGHT_CLASS_DEVICE.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/video/backlight/Kconfig | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 3fdc18e..3ed1d90 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -193,7 +193,6 @@ config BACKLIGHT_IPAQ_MICRO
config BACKLIGHT_LM3533
tristate "Backlight Driver for LM3533"
- depends on BACKLIGHT_CLASS_DEVICE
depends on MFD_LM3533
help
Say Y to enable the backlight driver for National Semiconductor / TI
@@ -317,7 +316,7 @@ config BACKLIGHT_ADP5520
config BACKLIGHT_ADP8860
tristate "Backlight Driver for ADP8860/ADP8861/ADP8863 using WLED"
- depends on BACKLIGHT_CLASS_DEVICE && I2C
+ depends on I2C
select NEW_LEDS
select LEDS_CLASS
help
@@ -329,7 +328,7 @@ config BACKLIGHT_ADP8860
config BACKLIGHT_ADP8870
tristate "Backlight Driver for ADP8870 using WLED"
- depends on BACKLIGHT_CLASS_DEVICE && I2C
+ depends on I2C
select NEW_LEDS
select LEDS_CLASS
help
@@ -347,28 +346,28 @@ config BACKLIGHT_88PM860X
config BACKLIGHT_PCF50633
tristate "Backlight driver for NXP PCF50633 MFD"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_PCF50633
+ depends on MFD_PCF50633
help
If you have a backlight driven by a NXP PCF50633 MFD, say Y here to
enable its driver.
config BACKLIGHT_AAT2870
tristate "AnalogicTech AAT2870 Backlight"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_AAT2870_CORE
+ depends on MFD_AAT2870_CORE
help
If you have a AnalogicTech AAT2870 say Y to enable the
backlight driver.
config BACKLIGHT_LM3630A
tristate "Backlight Driver for LM3630A"
- depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
+ depends on I2C && PWM
select REGMAP_I2C
help
This supports TI LM3630A Backlight Driver
config BACKLIGHT_LM3639
tristate "Backlight Driver for LM3639"
- depends on BACKLIGHT_CLASS_DEVICE && I2C
+ depends on I2C
select REGMAP_I2C
select NEW_LEDS
select LEDS_CLASS
@@ -377,20 +376,20 @@ config BACKLIGHT_LM3639
config BACKLIGHT_LP855X
tristate "Backlight driver for TI LP855X"
- depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
+ depends on I2C && PWM
help
This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
LP8557 backlight driver.
config BACKLIGHT_LP8788
tristate "Backlight driver for TI LP8788 MFD"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
+ depends on MFD_LP8788 && PWM
help
This supports TI LP8788 backlight driver.
config BACKLIGHT_OT200
tristate "Backlight driver for ot200 visualisation device"
- depends on BACKLIGHT_CLASS_DEVICE && CS5535_MFGPT && GPIO_CS5535
+ depends on CS5535_MFGPT && GPIO_CS5535
help
To compile this driver as a module, choose M here: the module will be
called ot200_bl.
@@ -404,7 +403,7 @@ config BACKLIGHT_PANDORA
config BACKLIGHT_SKY81452
tristate "Backlight driver for SKY81452"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_SKY81452
+ depends on MFD_SKY81452
help
If you have a Skyworks SKY81452, say Y to enable the
backlight driver.
@@ -414,14 +413,14 @@ config BACKLIGHT_SKY81452
config BACKLIGHT_TPS65217
tristate "TPS65217 Backlight"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_TPS65217
+ depends on MFD_TPS65217
help
If you have a Texas Instruments TPS65217 say Y to enable the
backlight driver.
config BACKLIGHT_AS3711
tristate "AS3711 Backlight"
- depends on BACKLIGHT_CLASS_DEVICE && MFD_AS3711
+ depends on MFD_AS3711
help
If you have an Austrian Microsystems AS3711 say Y to enable the
backlight driver.
--
2.10.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
@ 2019-01-17 16:18 ` Daniel Thompson
2019-02-08 17:20 ` Bartlomiej Zolnierkiewicz
2019-04-03 10:10 ` Lee Jones
2 siblings, 0 replies; 20+ messages in thread
From: Daniel Thompson @ 2019-01-17 16:18 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Jingoo Han, linux-fbdev, Lee Jones, dri-devel, Bartlomiej Zolnierkiewicz
On Thu, Jan 17, 2019 at 04:33:36PM +0300, Alexander Shiyan wrote:
> This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
> that are already placed under #if BACKLIGHT_CLASS_DEVICE.
Why the # before the if (in Kconfig its just "if" right?).
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Any didn't I ack this already?
Daniel.
> ---
> drivers/video/backlight/Kconfig | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 3fdc18e..3ed1d90 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -193,7 +193,6 @@ config BACKLIGHT_IPAQ_MICRO
>
> config BACKLIGHT_LM3533
> tristate "Backlight Driver for LM3533"
> - depends on BACKLIGHT_CLASS_DEVICE
> depends on MFD_LM3533
> help
> Say Y to enable the backlight driver for National Semiconductor / TI
> @@ -317,7 +316,7 @@ config BACKLIGHT_ADP5520
>
> config BACKLIGHT_ADP8860
> tristate "Backlight Driver for ADP8860/ADP8861/ADP8863 using WLED"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on I2C
> select NEW_LEDS
> select LEDS_CLASS
> help
> @@ -329,7 +328,7 @@ config BACKLIGHT_ADP8860
>
> config BACKLIGHT_ADP8870
> tristate "Backlight Driver for ADP8870 using WLED"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on I2C
> select NEW_LEDS
> select LEDS_CLASS
> help
> @@ -347,28 +346,28 @@ config BACKLIGHT_88PM860X
>
> config BACKLIGHT_PCF50633
> tristate "Backlight driver for NXP PCF50633 MFD"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_PCF50633
> + depends on MFD_PCF50633
> help
> If you have a backlight driven by a NXP PCF50633 MFD, say Y here to
> enable its driver.
>
> config BACKLIGHT_AAT2870
> tristate "AnalogicTech AAT2870 Backlight"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_AAT2870_CORE
> + depends on MFD_AAT2870_CORE
> help
> If you have a AnalogicTech AAT2870 say Y to enable the
> backlight driver.
>
> config BACKLIGHT_LM3630A
> tristate "Backlight Driver for LM3630A"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> + depends on I2C && PWM
> select REGMAP_I2C
> help
> This supports TI LM3630A Backlight Driver
>
> config BACKLIGHT_LM3639
> tristate "Backlight Driver for LM3639"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on I2C
> select REGMAP_I2C
> select NEW_LEDS
> select LEDS_CLASS
> @@ -377,20 +376,20 @@ config BACKLIGHT_LM3639
>
> config BACKLIGHT_LP855X
> tristate "Backlight driver for TI LP855X"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> + depends on I2C && PWM
> help
> This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
> LP8557 backlight driver.
>
> config BACKLIGHT_LP8788
> tristate "Backlight driver for TI LP8788 MFD"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
> + depends on MFD_LP8788 && PWM
> help
> This supports TI LP8788 backlight driver.
>
> config BACKLIGHT_OT200
> tristate "Backlight driver for ot200 visualisation device"
> - depends on BACKLIGHT_CLASS_DEVICE && CS5535_MFGPT && GPIO_CS5535
> + depends on CS5535_MFGPT && GPIO_CS5535
> help
> To compile this driver as a module, choose M here: the module will be
> called ot200_bl.
> @@ -404,7 +403,7 @@ config BACKLIGHT_PANDORA
>
> config BACKLIGHT_SKY81452
> tristate "Backlight driver for SKY81452"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_SKY81452
> + depends on MFD_SKY81452
> help
> If you have a Skyworks SKY81452, say Y to enable the
> backlight driver.
> @@ -414,14 +413,14 @@ config BACKLIGHT_SKY81452
>
> config BACKLIGHT_TPS65217
> tristate "TPS65217 Backlight"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_TPS65217
> + depends on MFD_TPS65217
> help
> If you have a Texas Instruments TPS65217 say Y to enable the
> backlight driver.
>
> config BACKLIGHT_AS3711
> tristate "AS3711 Backlight"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_AS3711
> + depends on MFD_AS3711
> help
> If you have an Austrian Microsystems AS3711 say Y to enable the
> backlight driver.
> --
> 2.10.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-01-17 13:33 [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Alexander Shiyan
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
@ 2019-01-17 16:19 ` Daniel Thompson
2019-02-08 17:19 ` Bartlomiej Zolnierkiewicz
2019-04-03 10:19 ` [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window Lee Jones
2019-05-15 8:56 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Geert Uytterhoeven
3 siblings, 1 reply; 20+ messages in thread
From: Daniel Thompson @ 2019-01-17 16:19 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Jingoo Han, linux-fbdev, Lee Jones, dri-devel, Bartlomiej Zolnierkiewicz
On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> and BACKLIGHT_LCD_DEVICE) that do the same job.
> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> and converts LCD_CLASS_DEVICE into a menu.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
A cover letter with the v1 -> v2 changelog would be nice... but
nevertheless:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> arch/unicore32/Kconfig | 1 -
> drivers/gpu/drm/Kconfig | 2 --
> drivers/gpu/drm/bridge/Kconfig | 1 -
> drivers/gpu/drm/fsl-dcu/Kconfig | 1 -
> drivers/gpu/drm/i915/Kconfig | 1 -
> drivers/gpu/drm/nouveau/Kconfig | 2 --
> drivers/gpu/drm/shmobile/Kconfig | 1 -
> drivers/gpu/drm/tilcdc/Kconfig | 1 -
> drivers/staging/olpc_dcon/Kconfig | 1 -
> drivers/usb/misc/Kconfig | 1 -
> drivers/video/backlight/Kconfig | 10 ++--------
> drivers/video/fbdev/Kconfig | 5 -----
> 12 files changed, 2 insertions(+), 25 deletions(-)
>
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index c3a41bf..1138334 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -195,7 +195,6 @@ config I2C_EEPROM_AT24
>
> config LCD_BACKLIGHT
> tristate "LCD Backlight support"
> - select BACKLIGHT_LCD_SUPPORT
> select BACKLIGHT_PWM
>
> endmenu
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 4385f00..ef442a7 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -198,7 +198,6 @@ config DRM_RADEON
> select POWER_SUPPLY
> select HWMON
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> select INTERVAL_TREE
> help
> Choose this option if you have an ATI Radeon graphics card. There
> @@ -219,7 +218,6 @@ config DRM_AMDGPU
> select POWER_SUPPLY
> select HWMON
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> select INTERVAL_TREE
> select CHASH
> help
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 2fee47b..5b5a8e5 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -75,7 +75,6 @@ config DRM_PARADE_PS8622
> depends on OF
> select DRM_PANEL
> select DRM_KMS_HELPER
> - select BACKLIGHT_LCD_SUPPORT
> select BACKLIGHT_CLASS_DEVICE
> ---help---
> Parade eDP-LVDS bridge chip driver.
> diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> index 14a72c4..dc82588 100644
> --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> @@ -2,7 +2,6 @@ config DRM_FSL_DCU
> tristate "DRM Support for Freescale DCU"
> depends on DRM && OF && ARM && COMMON_CLK
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> select DRM_PANEL
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 148be8e..3d5f1cb 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -15,7 +15,6 @@ config DRM_I915
> select IRQ_WORK
> # i915 depends on ACPI_VIDEO when ACPI is enabled
> # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> - select BACKLIGHT_LCD_SUPPORT if ACPI
> select BACKLIGHT_CLASS_DEVICE if ACPI
> select INPUT if ACPI
> select ACPI_VIDEO if ACPI
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 432c440..fd7b869 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -5,14 +5,12 @@ config DRM_NOUVEAU
> select DRM_KMS_HELPER
> select DRM_TTM
> select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
> - select BACKLIGHT_LCD_SUPPORT if DRM_NOUVEAU_BACKLIGHT
> select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT
> select X86_PLATFORM_DEVICES if ACPI && X86
> select ACPI_WMI if ACPI && X86
> select MXM_WMI if ACPI && X86
> select POWER_SUPPLY
> # Similar to i915, we need to select ACPI_VIDEO and it's dependencies
> - select BACKLIGHT_LCD_SUPPORT if ACPI && X86
> select BACKLIGHT_CLASS_DEVICE if ACPI && X86
> select INPUT if ACPI && X86
> select THERMAL if ACPI && X86
> diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
> index 61bbe8e..e2a6c82 100644
> --- a/drivers/gpu/drm/shmobile/Kconfig
> +++ b/drivers/gpu/drm/shmobile/Kconfig
> @@ -4,7 +4,6 @@ config DRM_SHMOBILE
> depends on DRM && ARM
> depends on ARCH_SHMOBILE || COMPILE_TEST
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> select DRM_KMS_HELPER
> select DRM_KMS_CMA_HELPER
> select DRM_GEM_CMA_HELPER
> diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
> index 5259804..cb7df20 100644
> --- a/drivers/gpu/drm/tilcdc/Kconfig
> +++ b/drivers/gpu/drm/tilcdc/Kconfig
> @@ -8,7 +8,6 @@ config DRM_TILCDC
> select DRM_PANEL_BRIDGE
> select VIDEOMODE_HELPERS
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> help
> Choose this option if you have an TI SoC with LCDC display
> controller, for example AM33xx in beagle-bone, DA8xx, or
> diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
> index 192cc8d..c91a56f 100644
> --- a/drivers/staging/olpc_dcon/Kconfig
> +++ b/drivers/staging/olpc_dcon/Kconfig
> @@ -2,7 +2,6 @@ config FB_OLPC_DCON
> tristate "One Laptop Per Child Display CONtroller support"
> depends on OLPC && FB
> depends on I2C
> - depends on BACKLIGHT_LCD_SUPPORT
> depends on (GPIO_CS5535 || GPIO_CS5535=n)
> select BACKLIGHT_CLASS_DEVICE
> help
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 68d2f2c..a86a80b 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -141,7 +141,6 @@ config USB_FTDI_ELAN
>
> config USB_APPLEDISPLAY
> tristate "Apple Cinema Display support"
> - select BACKLIGHT_LCD_SUPPORT
> select BACKLIGHT_CLASS_DEVICE
> help
> Say Y here if you want to control the backlight of Apple Cinema
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 71ee978..3fdc18e 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -2,13 +2,7 @@
> # Backlight & LCD drivers configuration
> #
>
> -menuconfig BACKLIGHT_LCD_SUPPORT
> - bool "Backlight & LCD device support"
> - help
> - Enable this to be able to choose the drivers for controlling the
> - backlight and the LCD panel on some platforms, for example on PDAs.
> -
> -if BACKLIGHT_LCD_SUPPORT
> +menu "Backlight & LCD device support"
>
> #
> # LCD
> @@ -466,4 +460,4 @@ config BACKLIGHT_RAVE_SP
>
> endif # BACKLIGHT_CLASS_DEVICE
>
> -endif # BACKLIGHT_LCD_SUPPORT
> +endmenu
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index ae7712c..7b5c404 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -186,7 +186,6 @@ config FB_MACMODES
> config FB_BACKLIGHT
> tristate
> depends on FB
> - select BACKLIGHT_LCD_SUPPORT
> select BACKLIGHT_CLASS_DEVICE
>
> config FB_MODE_HELPERS
> @@ -281,7 +280,6 @@ config FB_ARMCLCD
> select FB_CFB_IMAGEBLIT
> select FB_MODE_HELPERS if OF
> select VIDEOMODE_HELPERS if OF
> - select BACKLIGHT_LCD_SUPPORT if OF
> select BACKLIGHT_CLASS_DEVICE if OF
> help
> This framebuffer device driver is for the ARM PrimeCell PL110
> @@ -315,7 +313,6 @@ config FB_ACORN
> config FB_CLPS711X
> tristate "CLPS711X LCD support"
> depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
> - select BACKLIGHT_LCD_SUPPORT
> select FB_MODE_HELPERS
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
> @@ -343,7 +340,6 @@ config FB_SA1100
> config FB_IMX
> tristate "Freescale i.MX1/21/25/27 LCD support"
> depends on FB && ARCH_MXC
> - select BACKLIGHT_LCD_SUPPORT
> select LCD_CLASS_DEVICE
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> @@ -2192,7 +2188,6 @@ config FB_MX3
> tristate "MX3 Framebuffer support"
> depends on FB && MX3_IPU
> select BACKLIGHT_CLASS_DEVICE
> - select BACKLIGHT_LCD_SUPPORT
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> 2.10.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-01-17 16:19 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Daniel Thompson
@ 2019-02-08 17:19 ` Bartlomiej Zolnierkiewicz
2019-02-12 8:42 ` Lee Jones via dri-devel
0 siblings, 1 reply; 20+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-02-08 17:19 UTC (permalink / raw)
To: Daniel Thompson, Alexander Shiyan, Lee Jones
Cc: Jingoo Han, linux-fbdev, dri-devel
On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>> and converts LCD_CLASS_DEVICE into a menu.
>>
>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> A cover letter with the v1 -> v2 changelog would be nice... but
> nevertheless:
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Also:
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Lee, will you pick this up or do you want me to do it?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
2019-01-17 16:18 ` Daniel Thompson
@ 2019-02-08 17:20 ` Bartlomiej Zolnierkiewicz
2019-02-11 10:22 ` Daniel Thompson
2019-04-03 10:10 ` Lee Jones
2 siblings, 1 reply; 20+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-02-08 17:20 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Jingoo Han, linux-fbdev, Lee Jones, Daniel Thompson, dri-devel
On 01/17/2019 02:33 PM, Alexander Shiyan wrote:
> This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
> that are already placed under #if BACKLIGHT_CLASS_DEVICE.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies
2019-02-08 17:20 ` Bartlomiej Zolnierkiewicz
@ 2019-02-11 10:22 ` Daniel Thompson
0 siblings, 0 replies; 20+ messages in thread
From: Daniel Thompson @ 2019-02-11 10:22 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Jingoo Han, linux-fbdev, Lee Jones, dri-devel, Alexander Shiyan
On Fri, Feb 08, 2019 at 06:20:14PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> On 01/17/2019 02:33 PM, Alexander Shiyan wrote:
> > This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
> > that are already placed under #if BACKLIGHT_CLASS_DEVICE.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Sorry... looks like I sent neither an ack nor a nitpick about the #if
(#if is no more part of Kconfig syntax than #ifdef was).
However patch is perfectly clear so:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-08 17:19 ` Bartlomiej Zolnierkiewicz
@ 2019-02-12 8:42 ` Lee Jones via dri-devel
2019-02-13 15:04 ` Bartlomiej Zolnierkiewicz via dri-devel
0 siblings, 1 reply; 20+ messages in thread
From: Lee Jones via dri-devel @ 2019-02-12 8:42 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Jingoo Han, Daniel Thompson, dri-devel, Alexander Shiyan, linux-fbdev
On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>
> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> > On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> >> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> >> and BACKLIGHT_LCD_DEVICE) that do the same job.
> >> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> >> and converts LCD_CLASS_DEVICE into a menu.
> >>
> >> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >
> > A cover letter with the v1 -> v2 changelog would be nice... but
> > nevertheless:
> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Also:
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Lee, will you pick this up or do you want me to do it?
You can take them if you want. I will require a pull-request from an
independent immutable branch though please.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-12 8:42 ` Lee Jones via dri-devel
@ 2019-02-13 15:04 ` Bartlomiej Zolnierkiewicz via dri-devel
2019-02-13 15:19 ` Daniel Vetter
0 siblings, 1 reply; 20+ messages in thread
From: Bartlomiej Zolnierkiewicz via dri-devel @ 2019-02-13 15:04 UTC (permalink / raw)
To: Lee Jones
Cc: Jingoo Han, Daniel Thompson, dri-devel, Alexander Shiyan, linux-fbdev
On 02/12/2019 09:42 AM, Lee Jones wrote:
> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>
>>
>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>>>> and converts LCD_CLASS_DEVICE into a menu.
>>>>
>>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>>
>>> A cover letter with the v1 -> v2 changelog would be nice... but
>>> nevertheless:
>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>>
>> Also:
>>
>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>
>> Lee, will you pick this up or do you want me to do it?
>
> You can take them if you want. I will require a pull-request from an
> independent immutable branch though please.
OK, immutable branch will also allow other trees (drm) to sync with
these changes if desired.
I will do it for v5.2 if you are fine with it (too late for v5.1
IMHO and I also won't have time too fix any potential issues next
week).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-13 15:04 ` Bartlomiej Zolnierkiewicz via dri-devel
@ 2019-02-13 15:19 ` Daniel Vetter
2019-02-13 16:12 ` Bartlomiej Zolnierkiewicz via dri-devel
2019-02-14 8:12 ` Lee Jones via dri-devel
0 siblings, 2 replies; 20+ messages in thread
From: Daniel Vetter @ 2019-02-13 15:19 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Daniel Thompson, Alexander Shiyan, Jingoo Han,
Linux Fbdev development list, dri-devel, Lee Jones
On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via
dri-devel <dri-devel@lists.freedesktop.org> wrote:
>
>
> On 02/12/2019 09:42 AM, Lee Jones wrote:
> > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
> >
> >>
> >> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> >>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> >>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
> >>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> >>>> and converts LCD_CLASS_DEVICE into a menu.
> >>>>
> >>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >>>
> >>> A cover letter with the v1 -> v2 changelog would be nice... but
> >>> nevertheless:
> >>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >>
> >> Also:
> >>
> >> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>
> >> Lee, will you pick this up or do you want me to do it?
> >
> > You can take them if you want. I will require a pull-request from an
> > independent immutable branch though please.
>
> OK, immutable branch will also allow other trees (drm) to sync with
> these changes if desired.
>
> I will do it for v5.2 if you are fine with it (too late for v5.1
> IMHO and I also won't have time too fix any potential issues next
> week).
Topic branch for these 2 simple patches seems like serious overkill.
Especially for backlight stuff, which doesn't move fast. Anyway, up to
you, ack for all the drm patches to go through whatever tree you
people can agree on. Would be good to get it into 5.1 still though,
just to avoid too many conflicts.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-13 15:19 ` Daniel Vetter
@ 2019-02-13 16:12 ` Bartlomiej Zolnierkiewicz via dri-devel
2019-03-20 10:07 ` Lee Jones
2019-02-14 8:12 ` Lee Jones via dri-devel
1 sibling, 1 reply; 20+ messages in thread
From: Bartlomiej Zolnierkiewicz via dri-devel @ 2019-02-13 16:12 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Thompson, Alexander Shiyan, Jingoo Han,
Linux Fbdev development list, dri-devel, Lee Jones
On 02/13/2019 04:19 PM, Daniel Vetter wrote:
> On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via
> dri-devel <dri-devel@lists.freedesktop.org> wrote:
>>
>>
>> On 02/12/2019 09:42 AM, Lee Jones wrote:
>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>>>
>>>>
>>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
>>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>>>>>> and converts LCD_CLASS_DEVICE into a menu.
>>>>>>
>>>>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>>>>
>>>>> A cover letter with the v1 -> v2 changelog would be nice... but
>>>>> nevertheless:
>>>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>>>>
>>>> Also:
>>>>
>>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>>
>>>> Lee, will you pick this up or do you want me to do it?
>>>
>>> You can take them if you want. I will require a pull-request from an
>>> independent immutable branch though please.
>>
>> OK, immutable branch will also allow other trees (drm) to sync with
>> these changes if desired.
>>
>> I will do it for v5.2 if you are fine with it (too late for v5.1
>> IMHO and I also won't have time too fix any potential issues next
>> week).
>
> Topic branch for these 2 simple patches seems like serious overkill.
> Especially for backlight stuff, which doesn't move fast. Anyway, up to
This depends on the development stage we are in [*]. Right now things
are calm so there is low probability of conflicts and we might just
merge these patches without topic branch.
[*] In case of fbdev/Kconfig FB_CLPS711X config option was modified
in v4.20 and both FB_IMX and FB_MX3 config options still need to be
converted to support COMPILE_TEST so at least in theory there is
a potential for conflicts with fbdev if merged for 5.2.
> you, ack for all the drm patches to go through whatever tree you
> people can agree on. Would be good to get it into 5.1 still though,
> just to avoid too many conflicts.
Well, if so I'm also fine with this going in 5.1 w/o topic branch.
Lee, do you want to merge this directly into backlight tree (you
have now both fbdev and drm acks)?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-13 15:19 ` Daniel Vetter
2019-02-13 16:12 ` Bartlomiej Zolnierkiewicz via dri-devel
@ 2019-02-14 8:12 ` Lee Jones via dri-devel
1 sibling, 0 replies; 20+ messages in thread
From: Lee Jones via dri-devel @ 2019-02-14 8:12 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Thompson, Alexander Shiyan, Bartlomiej Zolnierkiewicz,
Jingoo Han, Linux Fbdev development list, dri-devel
On Wed, 13 Feb 2019, Daniel Vetter wrote:
> On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via
> dri-devel <dri-devel@lists.freedesktop.org> wrote:
> >
> >
> > On 02/12/2019 09:42 AM, Lee Jones wrote:
> > > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
> > >
> > >>
> > >> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> > >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> > >>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> > >>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
> > >>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> > >>>> and converts LCD_CLASS_DEVICE into a menu.
> > >>>>
> > >>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > >>>
> > >>> A cover letter with the v1 -> v2 changelog would be nice... but
> > >>> nevertheless:
> > >>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> > >>
> > >> Also:
> > >>
> > >> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > >>
> > >> Lee, will you pick this up or do you want me to do it?
> > >
> > > You can take them if you want. I will require a pull-request from an
> > > independent immutable branch though please.
> >
> > OK, immutable branch will also allow other trees (drm) to sync with
> > these changes if desired.
> >
> > I will do it for v5.2 if you are fine with it (too late for v5.1
> > IMHO and I also won't have time too fix any potential issues next
> > week).
>
> Topic branch for these 2 simple patches seems like serious overkill.
> Especially for backlight stuff, which doesn't move fast. Anyway, up to
> you, ack for all the drm patches to go through whatever tree you
> people can agree on. Would be good to get it into 5.1 still though,
> just to avoid too many conflicts.
It takes me approx 1 min to set-up an immutable branch.
If you think it's too much work, I can set it up for you.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-02-13 16:12 ` Bartlomiej Zolnierkiewicz via dri-devel
@ 2019-03-20 10:07 ` Lee Jones
2019-04-01 15:46 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 20+ messages in thread
From: Lee Jones @ 2019-03-20 10:07 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Daniel Thompson, Alexander Shiyan, Jingoo Han,
Linux Fbdev development list, dri-devel
> >> On 02/12/2019 09:42 AM, Lee Jones wrote:
> >>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
> >>>
> >>>>
> >>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
> >>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
> >>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> >>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
> >>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> >>>>>> and converts LCD_CLASS_DEVICE into a menu.
> >>>>>>
> >>>>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> >>>>>
> >>>>> A cover letter with the v1 -> v2 changelog would be nice... but
> >>>>> nevertheless:
> >>>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> >>>>
> >>>> Also:
> >>>>
> >>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >>>>
> >>>> Lee, will you pick this up or do you want me to do it?
> >>>
> >>> You can take them if you want. I will require a pull-request from an
> >>> independent immutable branch though please.
> >>
> >> OK, immutable branch will also allow other trees (drm) to sync with
> >> these changes if desired.
> >>
> >> I will do it for v5.2 if you are fine with it (too late for v5.1
> >> IMHO and I also won't have time too fix any potential issues next
> >> week).
> > Topic branch for these 2 simple patches seems like serious overkill.
[...]
> > Would be good to get it into 5.1 still though, just to avoid too
> > many conflicts.
I think you just answered your own statement. :)
> Well, if so I'm also fine with this going in 5.1 w/o topic branch.
>
> Lee, do you want to merge this directly into backlight tree (you
> have now both fbdev and drm acks)?
It was too late for v5.1.
Do you still want to take this for v5.2, or should I take them and
provide you with an immutable pull-request?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-03-20 10:07 ` Lee Jones
@ 2019-04-01 15:46 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 20+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-01 15:46 UTC (permalink / raw)
To: Lee Jones
Cc: Daniel Thompson, Alexander Shiyan, Jingoo Han,
Linux Fbdev development list, dri-devel
On 03/20/2019 11:07 AM, Lee Jones wrote:
>>>> On 02/12/2019 09:42 AM, Lee Jones wrote:
>>>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>>>>>
>>>>>>
>>>>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
>>>>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>>>>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>>>>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>>>>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>>>>>>>> and converts LCD_CLASS_DEVICE into a menu.
>>>>>>>>
>>>>>>>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>>>>>>>
>>>>>>> A cover letter with the v1 -> v2 changelog would be nice... but
>>>>>>> nevertheless:
>>>>>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>>>>>>
>>>>>> Also:
>>>>>>
>>>>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>>>>
>>>>>> Lee, will you pick this up or do you want me to do it?
>>>>>
>>>>> You can take them if you want. I will require a pull-request from an
>>>>> independent immutable branch though please.
>>>>
>>>> OK, immutable branch will also allow other trees (drm) to sync with
>>>> these changes if desired.
>>>>
>>>> I will do it for v5.2 if you are fine with it (too late for v5.1
>>>> IMHO and I also won't have time too fix any potential issues next
>>>> week).
>
>>> Topic branch for these 2 simple patches seems like serious overkill.
>
> [...]
>
>>> Would be good to get it into 5.1 still though, just to avoid too
>>> many conflicts.
>
> I think you just answered your own statement. :)
>
>> Well, if so I'm also fine with this going in 5.1 w/o topic branch.
>>
>> Lee, do you want to merge this directly into backlight tree (you
>> have now both fbdev and drm acks)?
>
> It was too late for v5.1.
>
> Do you still want to take this for v5.2, or should I take them and
> provide you with an immutable pull-request?
Please take them and provide immutable branch, thank you.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
2019-01-17 16:18 ` Daniel Thompson
2019-02-08 17:20 ` Bartlomiej Zolnierkiewicz
@ 2019-04-03 10:10 ` Lee Jones
2 siblings, 0 replies; 20+ messages in thread
From: Lee Jones @ 2019-04-03 10:10 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Jingoo Han, linux-fbdev, Daniel Thompson, dri-devel,
Bartlomiej Zolnierkiewicz
On Thu, 17 Jan 2019, Alexander Shiyan wrote:
> This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
> that are already placed under #if BACKLIGHT_CLASS_DEVICE.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/video/backlight/Kconfig | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
Will fix up Daniel's nit about the #if.
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window
2019-01-17 13:33 [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Alexander Shiyan
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
2019-01-17 16:19 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Daniel Thompson
@ 2019-04-03 10:19 ` Lee Jones
2019-04-03 13:29 ` Daniel Vetter
2019-05-15 8:56 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Geert Uytterhoeven
3 siblings, 1 reply; 20+ messages in thread
From: Lee Jones @ 2019-04-03 10:19 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Jingoo Han, linux-fbdev, Daniel Thompson, dri-devel,
Bartlomiej Zolnierkiewicz
To whom it may concern,
Enjoy!
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:
Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git ib-backlight-drm-v5.2
for you to fetch changes up to 8c5dc8d9f19c7992b5ed557b865127a80149041b:
video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol (2019-04-03 11:15:57 +0100)
----------------------------------------------------------------
Immutable branch between MFD and DRM due for the v5.2 merge window
----------------------------------------------------------------
Alexander Shiyan (1):
video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
arch/unicore32/Kconfig | 1 -
drivers/gpu/drm/Kconfig | 2 --
drivers/gpu/drm/bridge/Kconfig | 1 -
drivers/gpu/drm/fsl-dcu/Kconfig | 1 -
drivers/gpu/drm/i915/Kconfig | 1 -
drivers/gpu/drm/nouveau/Kconfig | 2 --
drivers/gpu/drm/shmobile/Kconfig | 1 -
drivers/gpu/drm/tilcdc/Kconfig | 1 -
drivers/staging/olpc_dcon/Kconfig | 1 -
drivers/usb/misc/Kconfig | 1 -
drivers/video/backlight/Kconfig | 10 ++--------
drivers/video/fbdev/Kconfig | 5 -----
12 files changed, 2 insertions(+), 25 deletions(-)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window
2019-04-03 10:19 ` [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window Lee Jones
@ 2019-04-03 13:29 ` Daniel Vetter
0 siblings, 0 replies; 20+ messages in thread
From: Daniel Vetter @ 2019-04-03 13:29 UTC (permalink / raw)
To: Lee Jones
Cc: linux-fbdev, Alexander Shiyan, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, dri-devel
On Wed, Apr 03, 2019 at 11:19:52AM +0100, Lee Jones wrote:
> To whom it may concern,
>
> Enjoy!
>
> The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b:
>
> Linux 5.1-rc1 (2019-03-17 14:22:26 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git ib-backlight-drm-v5.2
>
> for you to fetch changes up to 8c5dc8d9f19c7992b5ed557b865127a80149041b:
>
> video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol (2019-04-03 11:15:57 +0100)
>
> ----------------------------------------------------------------
> Immutable branch between MFD and DRM due for the v5.2 merge window
I pinged Jani (who's been looking at backlight dependencies in the past in
drm), seems like no need to pull this into drm.
Thanks, Daniel
>
> ----------------------------------------------------------------
> Alexander Shiyan (1):
> video: backlight: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
>
> arch/unicore32/Kconfig | 1 -
> drivers/gpu/drm/Kconfig | 2 --
> drivers/gpu/drm/bridge/Kconfig | 1 -
> drivers/gpu/drm/fsl-dcu/Kconfig | 1 -
> drivers/gpu/drm/i915/Kconfig | 1 -
> drivers/gpu/drm/nouveau/Kconfig | 2 --
> drivers/gpu/drm/shmobile/Kconfig | 1 -
> drivers/gpu/drm/tilcdc/Kconfig | 1 -
> drivers/staging/olpc_dcon/Kconfig | 1 -
> drivers/usb/misc/Kconfig | 1 -
> drivers/video/backlight/Kconfig | 10 ++--------
> drivers/video/fbdev/Kconfig | 5 -----
> 12 files changed, 2 insertions(+), 25 deletions(-)
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-01-17 13:33 [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Alexander Shiyan
` (2 preceding siblings ...)
2019-04-03 10:19 ` [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window Lee Jones
@ 2019-05-15 8:56 ` Geert Uytterhoeven
2019-05-15 10:33 ` Alexander Shiyan
3 siblings, 1 reply; 20+ messages in thread
From: Geert Uytterhoeven @ 2019-05-15 8:56 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Linux Fbdev development list, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, DRI Development, Lee Jones
Hi Alexander,
On Thu, Jan 17, 2019 at 2:39 PM Alexander Shiyan <shc_work@mail.ru> wrote:
> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> and BACKLIGHT_LCD_DEVICE) that do the same job.
> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> and converts LCD_CLASS_DEVICE into a menu.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
This is now commit 8c5dc8d9f19c7992 ("video: backlight: Remove useless
BACKLIGHT_LCD_SUPPORT kernel symbol").
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -2,13 +2,7 @@
> # Backlight & LCD drivers configuration
> #
>
> -menuconfig BACKLIGHT_LCD_SUPPORT
> - bool "Backlight & LCD device support"
> - help
> - Enable this to be able to choose the drivers for controlling the
> - backlight and the LCD panel on some platforms, for example on PDAs.
> -
> -if BACKLIGHT_LCD_SUPPORT
> +menu "Backlight & LCD device support"
>
> #
> # LCD
Below, we have:
config LCD_CLASS_DEVICE
tristate "Lowlevel LCD controls"
default m
help
This framework adds support for low-level control of LCD.
Some framebuffer devices connect to platform-specific LCD modules
in order to have a platform-specific way to control the flat panel
(contrast and applying power to the LCD (not to the backlight!)).
and:
config BACKLIGHT_CLASS_DEVICE
tristate "Lowlevel Backlight controls"
default m
help
This framework adds support for low-level control of the LCD
backlight. This includes support for brightness and power.
Hence running "make oldconfig" on a .config where
CONFIG_BACKLIGHT_LCD_SUPPORT was not set leads two to new
questions, where the answers default to "m".
Perhaps the "default m" statements should be removed?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-05-15 8:56 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Geert Uytterhoeven
@ 2019-05-15 10:33 ` Alexander Shiyan
2019-05-15 12:17 ` Geert Uytterhoeven
0 siblings, 1 reply; 20+ messages in thread
From: Alexander Shiyan @ 2019-05-15 10:33 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux Fbdev development list, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, DRI Development, Lee Jones
Hello.
Looks like you're right.
Can you create a patch to fix this?
Thanks.
>Среда, 15 мая 2019, 11:57 +03:00 от Geert Uytterhoeven <geert@linux-m68k.org>:
>
>Hi Alexander,
>
>On Thu, Jan 17, 2019 at 2:39 PM Alexander Shiyan < shc_work@mail.ru > wrote:
>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>> and converts LCD_CLASS_DEVICE into a menu.
>>
>> Signed-off-by: Alexander Shiyan < shc_work@mail.ru >
>This is now commit 8c5dc8d9f19c7992 ("video: backlight: Remove useless
>BACKLIGHT_LCD_SUPPORT kernel symbol").
>
>> --- a/drivers/video/backlight/Kconfig
>> +++ b/drivers/video/backlight/Kconfig
>> @@ -2,13 +2,7 @@
>> # Backlight & LCD drivers configuration
>> #
>>
>> -menuconfig BACKLIGHT_LCD_SUPPORT
>> - bool "Backlight & LCD device support"
>> - help
>> - Enable this to be able to choose the drivers for controlling the
>> - backlight and the LCD panel on some platforms, for example on PDAs.
>> -
>> -if BACKLIGHT_LCD_SUPPORT
>> +menu "Backlight & LCD device support"
>>
>> #
>> # LCD
>
>Below, we have:
>
> config LCD_CLASS_DEVICE
> tristate "Lowlevel LCD controls"
> default m
> help
> This framework adds support for low-level control of LCD.
> Some framebuffer devices connect to platform-specific LCD modules
> in order to have a platform-specific way to control the flat panel
> (contrast and applying power to the LCD (not to the backlight!)).
>
>and:
>
> config BACKLIGHT_CLASS_DEVICE
> tristate "Lowlevel Backlight controls"
> default m
> help
> This framework adds support for low-level control of the LCD
> backlight. This includes support for brightness and power.
>
>Hence running "make oldconfig" on a .config where
>CONFIG_BACKLIGHT_LCD_SUPPORT was not set leads two to new
>questions, where the answers default to "m".
>
>Perhaps the "default m" statements should be removed?
---
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
2019-05-15 10:33 ` Alexander Shiyan
@ 2019-05-15 12:17 ` Geert Uytterhoeven
0 siblings, 0 replies; 20+ messages in thread
From: Geert Uytterhoeven @ 2019-05-15 12:17 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Linux Fbdev development list, Bartlomiej Zolnierkiewicz,
Jingoo Han, Daniel Thompson, DRI Development, Lee Jones
Hi Alexander,
On Wed, May 15, 2019 at 12:34 PM Alexander Shiyan <shc_work@mail.ru> wrote:
> Looks like you're right.
> Can you create a patch to fix this?
Thank you, done.
> >Среда, 15 мая 2019, 11:57 +03:00 от Geert Uytterhoeven <geert@linux-m68k.org>:
> >
> >Hi Alexander,
> >
> >On Thu, Jan 17, 2019 at 2:39 PM Alexander Shiyan < shc_work@mail.ru > wrote:
> >> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
> >> and BACKLIGHT_LCD_DEVICE) that do the same job.
> >> The patch removes useless BACKLIGHT_LCD_SUPPORT option
> >> and converts LCD_CLASS_DEVICE into a menu.
> >>
> >> Signed-off-by: Alexander Shiyan < shc_work@mail.ru >
> >This is now commit 8c5dc8d9f19c7992 ("video: backlight: Remove useless
> >BACKLIGHT_LCD_SUPPORT kernel symbol").
> >
> >> --- a/drivers/video/backlight/Kconfig
> >> +++ b/drivers/video/backlight/Kconfig
> >> @@ -2,13 +2,7 @@
> >> # Backlight & LCD drivers configuration
> >> #
> >>
> >> -menuconfig BACKLIGHT_LCD_SUPPORT
> >> - bool "Backlight & LCD device support"
> >> - help
> >> - Enable this to be able to choose the drivers for controlling the
> >> - backlight and the LCD panel on some platforms, for example on PDAs.
> >> -
> >> -if BACKLIGHT_LCD_SUPPORT
> >> +menu "Backlight & LCD device support"
> >>
> >> #
> >> # LCD
> >
> >Below, we have:
> >
> > config LCD_CLASS_DEVICE
> > tristate "Lowlevel LCD controls"
> > default m
> > help
> > This framework adds support for low-level control of LCD.
> > Some framebuffer devices connect to platform-specific LCD modules
> > in order to have a platform-specific way to control the flat panel
> > (contrast and applying power to the LCD (not to the backlight!)).
> >
> >and:
> >
> > config BACKLIGHT_CLASS_DEVICE
> > tristate "Lowlevel Backlight controls"
> > default m
> > help
> > This framework adds support for low-level control of the LCD
> > backlight. This includes support for brightness and power.
> >
> >Hence running "make oldconfig" on a .config where
> >CONFIG_BACKLIGHT_LCD_SUPPORT was not set leads two to new
> >questions, where the answers default to "m".
> >
> >Perhaps the "default m" statements should be removed?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-05-15 12:17 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 13:33 [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Alexander Shiyan
2019-01-17 13:33 ` [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies Alexander Shiyan
2019-01-17 16:18 ` Daniel Thompson
2019-02-08 17:20 ` Bartlomiej Zolnierkiewicz
2019-02-11 10:22 ` Daniel Thompson
2019-04-03 10:10 ` Lee Jones
2019-01-17 16:19 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Daniel Thompson
2019-02-08 17:19 ` Bartlomiej Zolnierkiewicz
2019-02-12 8:42 ` Lee Jones via dri-devel
2019-02-13 15:04 ` Bartlomiej Zolnierkiewicz via dri-devel
2019-02-13 15:19 ` Daniel Vetter
2019-02-13 16:12 ` Bartlomiej Zolnierkiewicz via dri-devel
2019-03-20 10:07 ` Lee Jones
2019-04-01 15:46 ` Bartlomiej Zolnierkiewicz
2019-02-14 8:12 ` Lee Jones via dri-devel
2019-04-03 10:19 ` [GIT PULL] Immutable branch between MFD and DRM due for the v5.2 merge window Lee Jones
2019-04-03 13:29 ` Daniel Vetter
2019-05-15 8:56 ` [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Geert Uytterhoeven
2019-05-15 10:33 ` Alexander Shiyan
2019-05-15 12:17 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).