dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jyri Sarha <jsarha@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 0/3] drm/omap: fix am4 evm lcd
Date: Wed, 27 Nov 2019 07:45:56 -0800	[thread overview]
Message-ID: <20191127154556.GI43123@atomide.com> (raw)
In-Reply-To: <52608d4e-dd67-1232-41e7-e6d0cba58783@ti.com>

Hi

* Tomi Valkeinen <tomi.valkeinen@ti.com> [191127 12:59]:
> Hi Tony, Thierry, Laurent,
> 
> Any thoughts on the below points?

> I think yet another option is to write some omap boot time quirks code,
> which looks at the DT data, and changes the panel compatible string (for 1),
> and removes the timings node (for 2).

Nah, seems we can just update the compatible.

> On 14/11/2019 11:39, Tomi Valkeinen wrote:
> > 1) Panel driver is not probed. With omapdrm's panel-dpi, the match
> > happened with "panel-dpi" compatible string. Now with panel-simple, the
> > match should happen with the panel model compatible string, which is
> > "osddisplays,osd057T0559-34ts" in the DT file. However, no such
> > compatible exists in panel-simple.
> >
> > Interestingly, the actual panel at least on my EVMs and ePOSes is not
> > osd057T0559-34ts, but osd070t1718-19ts. Also, I was unable to find any
> > information about osd057T0559-34ts. I don't know the history with this,
> > so it is possible that the early versions of the boards did have
> > osd057T0559-34ts, but was later changed to osd070t1718-19ts.

I guess you could keep the old compatible there too if really needed.
But then again if the old compatible is known to be incorrect, it
should be just updated.

So it looks good to me for the dts changes. Do you want me to pick
them into fixes as it seems that the panel driver fix is a separate
issue?

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-27 15:46 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14  9:39 [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-14  9:39 ` Tomi Valkeinen
2019-11-14  9:39 ` [PATCH 1/3] ARM: dts: am437x-gp/epos-evm: fix panel compatible Tomi Valkeinen
2019-11-14  9:39   ` Tomi Valkeinen
2019-12-02 13:01   ` Laurent Pinchart
2019-12-11 16:51     ` Tony Lindgren
2019-11-14  9:39 ` [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings Tomi Valkeinen
2019-11-14  9:39   ` Tomi Valkeinen
2019-12-02 13:04   ` Laurent Pinchart
2019-12-11 16:53     ` Tony Lindgren
2019-12-12  9:37       ` Tomi Valkeinen
2019-12-12 20:35         ` Laurent Pinchart
2020-01-13 12:01           ` Tomi Valkeinen
2020-02-11 10:01             ` Tomi Valkeinen
2020-02-11 11:07               ` Laurent Pinchart
2020-02-11 11:08                 ` Tomi Valkeinen
2020-02-11 11:10                   ` Laurent Pinchart
2020-02-14  0:33                     ` Sebastian Reichel
2020-02-11 12:54                   ` Merlijn Wajer
2020-02-11 16:05                     ` Tony Lindgren
2020-02-11 16:13                       ` Tomi Valkeinen
2020-02-11 16:27                         ` Tony Lindgren
2020-02-11 17:22                           ` Tomi Valkeinen
2020-02-13 21:57                             ` Sebastian Reichel
2019-11-14  9:39 ` [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge Tomi Valkeinen
2019-11-14  9:39   ` Tomi Valkeinen
2019-12-02 13:07   ` Laurent Pinchart
2020-01-13 12:04     ` Tomi Valkeinen
2020-02-10  8:15     ` Tomi Valkeinen
2020-02-14 21:39       ` Sam Ravnborg
2020-02-21 10:43         ` Tomi Valkeinen
2020-02-22 12:16           ` Sam Ravnborg
2019-11-27 12:59 ` [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-27 12:59   ` Tomi Valkeinen
2019-11-27 15:45   ` Tony Lindgren [this message]
2019-11-28  7:03     ` Tomi Valkeinen
2019-12-02 13:13 ` Laurent Pinchart
2019-12-02 13:24   ` Adam Ford
2019-12-03 21:27     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127154556.GI43123@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).