* [PATCH] video: remove set but not used variable 'ulScaleRight' @ 2020-01-19 12:19 ` yu kuai 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: yu kuai @ 2020-01-19 12:19 UTC (permalink / raw) To: b.zolnierkie Cc: linux-fbdev, yi.zhang, linux-kernel, dri-devel, zhengbin13, yukuai3 Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/kyro/STG4000OverlayDevice.c: In function ‘SetOverlayViewPort’: drivers/video/fbdev/kyro/STG4000OverlayDevice.c:334:19: warning: variable ‘ulScaleRight’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai <yukuai3@huawei.com> --- drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c index 0aeeaa10708b..9fde0e3b69ec 100644 --- a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c +++ b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c @@ -331,7 +331,7 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg, u32 ulScale; u32 ulLeft, ulRight; u32 ulSrcLeft, ulSrcRight; - u32 ulScaleLeft, ulScaleRight; + u32 ulScaleLeft; u32 ulhDecim; u32 ulsVal; u32 ulVertDecFactor; @@ -470,7 +470,6 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg, * round down the pixel pos to the nearest 8 pixels. */ ulScaleLeft = ulSrcLeft; - ulScaleRight = ulSrcRight; /* shift fxscale until it is in the range of the scaler */ ulhDecim = 0; -- 2.17.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: remove set but not used variable 'ulScaleRight' 2020-01-19 12:19 ` [PATCH] video: remove set but not used variable 'ulScaleRight' yu kuai @ 2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-03-02 15:42 UTC (permalink / raw) To: yu kuai; +Cc: zhengbin13, linux-fbdev, linux-kernel, dri-devel, yi.zhang On 1/19/20 1:19 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/kyro/STG4000OverlayDevice.c: In function > ‘SetOverlayViewPort’: > drivers/video/fbdev/kyro/STG4000OverlayDevice.c:334:19: warning: > variable ‘ulScaleRight’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai <yukuai3@huawei.com> Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c > index 0aeeaa10708b..9fde0e3b69ec 100644 > --- a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c > +++ b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c > @@ -331,7 +331,7 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg, > u32 ulScale; > u32 ulLeft, ulRight; > u32 ulSrcLeft, ulSrcRight; > - u32 ulScaleLeft, ulScaleRight; > + u32 ulScaleLeft; > u32 ulhDecim; > u32 ulsVal; > u32 ulVertDecFactor; > @@ -470,7 +470,6 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg, > * round down the pixel pos to the nearest 8 pixels. > */ > ulScaleLeft = ulSrcLeft; > - ulScaleRight = ulSrcRight; > > /* shift fxscale until it is in the range of the scaler */ > ulhDecim = 0; > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-02 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200119122043eucas1p2b450cd177ca0d86d268323a074c82b05@eucas1p2.samsung.com>
2020-01-19 12:19 ` [PATCH] video: remove set but not used variable 'ulScaleRight' yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).