* [PATCH] drm/amd/powerplay: remove defined but not used variables
@ 2020-04-17 7:32 Jason Yan
2020-04-17 13:58 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-17 7:32 UTC (permalink / raw)
To: evan.quan, alexander.deucher, christian.koenig, David1.Zhou,
airlied, daniel, yanaijie, amd-gfx, dri-devel, linux-kernel
Cc: Hulk Robot
Fix the following gcc warning:
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46:
warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used
[-Wunused-const-variable=]
static const struct vega10_didt_config_reg
PSMGCEDCThresholdConfig_vega10[] =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:654:46:
warning: ‘PSMSEEDCThresholdConfig_Vega10’ defined but not used
[-Wunused-const-variable=]
static const struct vega10_didt_config_reg
PSMSEEDCThresholdConfig_Vega10[] =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
.../amd/powerplay/hwmgr/vega10_powertune.c | 23 -------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
index ca9b23b5abc9..9757d47dd6b8 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
@@ -651,18 +651,6 @@ static const struct vega10_didt_config_reg PSMSEEDCStallDelayConfig_Vega10[] =
{ 0xFFFFFFFF } /* End of list */
};
-static const struct vega10_didt_config_reg PSMSEEDCThresholdConfig_Vega10[] =
-{
-/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- * Offset Mask Shift Value
- * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- */
- /* SQ EDC THRESHOLD */
- { ixDIDT_SQ_EDC_THRESHOLD, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD_MASK, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000 },
-
- { 0xFFFFFFFF } /* End of list */
-};
-
static const struct vega10_didt_config_reg PSMSEEDCCtrlResetConfig_Vega10[] =
{
/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
@@ -707,17 +695,6 @@ static const struct vega10_didt_config_reg PSMSEEDCCtrlConfig_Vega10[] =
{ 0xFFFFFFFF } /* End of list */
};
-static const struct vega10_didt_config_reg PSMGCEDCThresholdConfig_vega10[] =
-{
-/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- * Offset Mask Shift Value
- * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- */
- { mmGC_EDC_THRESHOLD, GC_EDC_THRESHOLD__EDC_THRESHOLD_MASK, GC_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000000 },
-
- { 0xFFFFFFFF } /* End of list */
-};
-
static const struct vega10_didt_config_reg PSMGCEDCDroopCtrlConfig_vega10[] =
{
/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
--
2.21.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/powerplay: remove defined but not used variables
2020-04-17 7:32 [PATCH] drm/amd/powerplay: remove defined but not used variables Jason Yan
@ 2020-04-17 13:58 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-04-17 13:58 UTC (permalink / raw)
To: Jason Yan
Cc: Dave Airlie, LKML, amd-gfx list, Hulk Robot,
Maling list - DRI developers, Deucher, Alexander, Quan, Evan,
Christian Koenig
On Fri, Apr 17, 2020 at 9:16 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46:
> warning: ‘PSMGCEDCThresholdConfig_vega10’ defined but not used
> [-Wunused-const-variable=]
> static const struct vega10_didt_config_reg
> PSMGCEDCThresholdConfig_vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:654:46:
> warning: ‘PSMSEEDCThresholdConfig_Vega10’ defined but not used
> [-Wunused-const-variable=]
> static const struct vega10_didt_config_reg
> PSMSEEDCThresholdConfig_Vega10[] =
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied. Thanks!
Alex
> ---
> .../amd/powerplay/hwmgr/vega10_powertune.c | 23 -------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> index ca9b23b5abc9..9757d47dd6b8 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> @@ -651,18 +651,6 @@ static const struct vega10_didt_config_reg PSMSEEDCStallDelayConfig_Vega10[] =
> { 0xFFFFFFFF } /* End of list */
> };
>
> -static const struct vega10_didt_config_reg PSMSEEDCThresholdConfig_Vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - * Offset Mask Shift Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> - /* SQ EDC THRESHOLD */
> - { ixDIDT_SQ_EDC_THRESHOLD, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD_MASK, DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000 },
> -
> - { 0xFFFFFFFF } /* End of list */
> -};
> -
> static const struct vega10_didt_config_reg PSMSEEDCCtrlResetConfig_Vega10[] =
> {
> /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> @@ -707,17 +695,6 @@ static const struct vega10_didt_config_reg PSMSEEDCCtrlConfig_Vega10[] =
> { 0xFFFFFFFF } /* End of list */
> };
>
> -static const struct vega10_didt_config_reg PSMGCEDCThresholdConfig_vega10[] =
> -{
> -/* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - * Offset Mask Shift Value
> - * ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> - */
> - { mmGC_EDC_THRESHOLD, GC_EDC_THRESHOLD__EDC_THRESHOLD_MASK, GC_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT, 0x0000000 },
> -
> - { 0xFFFFFFFF } /* End of list */
> -};
> -
> static const struct vega10_didt_config_reg PSMGCEDCDroopCtrlConfig_vega10[] =
> {
> /* ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> --
> 2.21.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-18 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 7:32 [PATCH] drm/amd/powerplay: remove defined but not used variables Jason Yan
2020-04-17 13:58 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).