* [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done()
@ 2020-11-19 1:39 James Qian Wang
2020-11-19 15:27 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: James Qian Wang @ 2020-11-19 1:39 UTC (permalink / raw)
To: Liviu.Dudau, daniel, carsten.haitzler
Cc: nd, James Qian Wang (Arm Technology China), dri-devel
From: "James Qian Wang (Arm Technology China)" <james.qian.wang@arm.com>
Komeda HW has no special, program the update to HW is done first,
then flip happens. So correct the sequence to hw_done() first then
flip_done().
Reported-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: James Qian Wang <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 6b99df696384..034ee08482e0 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -81,10 +81,10 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
drm_atomic_helper_commit_modeset_enables(dev, old_state);
- drm_atomic_helper_wait_for_flip_done(dev, old_state);
-
drm_atomic_helper_commit_hw_done(old_state);
+ drm_atomic_helper_wait_for_flip_done(dev, old_state);
+
drm_atomic_helper_cleanup_planes(dev, old_state);
}
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done()
2020-11-19 1:39 [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done() James Qian Wang
@ 2020-11-19 15:27 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2020-11-19 15:27 UTC (permalink / raw)
To: James Qian Wang; +Cc: carsten.haitzler, nd, Liviu.Dudau, dri-devel
On Thu, Nov 19, 2020 at 09:39:48AM +0800, James Qian Wang wrote:
> From: "James Qian Wang (Arm Technology China)" <james.qian.wang@arm.com>
>
> Komeda HW has no special, program the update to HW is done first,
> then flip happens. So correct the sequence to hw_done() first then
> flip_done().
>
> Reported-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: James Qian Wang <james.qian.wang@arm.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> index 6b99df696384..034ee08482e0 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -81,10 +81,10 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
>
> drm_atomic_helper_commit_modeset_enables(dev, old_state);
>
> - drm_atomic_helper_wait_for_flip_done(dev, old_state);
> -
> drm_atomic_helper_commit_hw_done(old_state);
>
> + drm_atomic_helper_wait_for_flip_done(dev, old_state);
> +
> drm_atomic_helper_cleanup_planes(dev, old_state);
> }
>
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-19 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 1:39 [PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done() James Qian Wang
2020-11-19 15:27 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).