From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Michel Dänzer" <michel@daenzer.net>,
dri-devel <dri-devel@lists.freedesktop.org>,
"James Park" <jpark37@lagfreegames.com>,
"James Park" <james.park@lagfreegames.com>
Subject: Re: [PATCH] drm: Fix drm.h uapi header for Windows
Date: Thu, 3 Dec 2020 14:54:02 +0200 [thread overview]
Message-ID: <20201203125402.GH6112@intel.com> (raw)
In-Reply-To: <CAKMK7uFQcyKRb90FiWFGf3pqotMmLvsTDf9yc7m1Or1tYkdOOA@mail.gmail.com>
On Wed, Dec 02, 2020 at 11:25:58PM +0100, Daniel Vetter wrote:
> On Wed, Dec 2, 2020 at 8:48 PM James Park <james.park@lagfreegames.com> wrote:
> >
> > I can avoid modifying drm.h by doing this to drm_fourcc.h:
> >
> > #ifdef _WIN32
> > #include <stdint.h>
> > typedef uint64_t __u64;
> > #else
> > #include "drm.h"
> > #endif
> >
> > And this to amdgpu_drm.h:
> >
> > #ifdef _WIN32
> > #include <stdint.h>
> > typedef int32_t __s32;
> > typedef uint32_t __u32;
> > typedef uint64_t __u64;
> > #else
> > #include "drm.h"
> > #endif
> >
> > But now I'm touching two files under drm-uapi instead of one, and weirdly.
> >
> > If we're trying to cut ties with the drm-uapi folder entirely, the stuff ac_surface.c need includes the AMD_FMT_MOD stuff in drm_fourcc.h, and AMDGPU_TILING_* under amdgpu_drm.h. Is there a better spot for these definitions?
>
> The drm_fourcc.h maybe makes some sense (I think in some places mesa
> uses these internally, and many drivers use the modifiers directly in
> the main driver). But the amdgpu header should be all ioctl stuff,
> which should be all entirely in the winsys only.
>
> Also kinda disappointing that drm_fourcc.h includes drm.h and isn't
> standalone, but I guess that sailed (at least for linux).
Isn't the only thing it needs the __u32? I would think we could just
replace those with unsigned int (DRM_FORMAT_BIG_ENDIAN already assumes
int is 32bit it seems) and drop the drm.h.
Or are we're worried something already depends on getting drm.h via
just including drm_fourcc.h?
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-03 12:54 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:01 drm: Fix drm.h uapi header for Windows James Park
2020-12-01 10:01 ` [PATCH] " James Park
2020-12-02 8:46 ` Simon Ser
2020-12-02 9:07 ` James Park
2020-12-02 9:07 ` James Park
2020-12-02 11:42 ` Michel Dänzer
2020-12-02 12:46 ` Daniel Vetter
2020-12-02 18:06 ` Michel Dänzer
2020-12-02 19:47 ` James Park
2020-12-02 22:25 ` Daniel Vetter
2020-12-03 1:24 ` James Park
2020-12-03 9:05 ` Pekka Paalanen
2020-12-03 12:54 ` Ville Syrjälä [this message]
2020-12-03 13:13 ` Simon Ser
2020-12-03 8:18 ` Michel Dänzer
2020-12-03 14:52 ` Daniel Vetter
2020-12-03 18:55 ` James Park
2020-12-03 20:45 ` Daniel Vetter
2020-12-04 4:53 ` [PATCH] drm: Allow drm_fourcc.h without including drm.h James Park
2020-12-04 4:53 ` James Park
2020-12-04 8:53 ` Simon Ser
2020-12-04 9:47 ` James Park
2020-12-04 10:08 ` James Park
2020-12-04 14:46 ` kernel test robot
2020-12-04 22:29 ` kernel test robot
2020-12-04 8:11 ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-04 15:58 ` Daniel Vetter
2020-12-04 19:07 ` James Park
2020-12-06 0:39 ` [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE James Park
2020-12-06 0:39 ` James Park
2020-12-07 9:45 ` Simon Ser
2020-12-07 9:55 ` James Park
2020-12-07 9:59 ` Simon Ser
2020-12-07 10:05 ` James Park
2020-12-07 10:15 ` Simon Ser
2020-12-07 17:25 ` kernel test robot
2020-12-07 18:15 ` James Park
2020-12-07 18:15 ` James Park
2020-12-08 12:31 ` Simon Ser
2020-12-08 18:32 ` James Park
2020-12-09 10:15 ` Simon Ser
2020-12-09 10:18 ` Simon Ser
2020-12-09 11:03 ` James Park
2020-12-09 11:03 ` James Park
2020-12-10 8:35 ` Pekka Paalanen
2020-12-10 9:12 ` James Park
2020-12-10 9:12 ` James Park
2021-02-01 21:45 ` James Park
2021-02-02 17:28 ` Emil Velikov
2021-02-02 18:14 ` James Park
2021-02-02 22:48 ` Emil Velikov
2021-02-02 23:05 ` Simon Ser
2021-02-02 8:51 ` Simon Ser
2021-02-02 8:52 ` Simon Ser
2020-12-07 8:51 ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-07 9:08 ` James Park
2020-12-07 10:35 ` Pekka Paalanen
2020-12-07 10:44 ` Pekka Paalanen
2020-12-07 10:47 ` Simon Ser
2020-12-07 10:49 ` James Park
2020-12-07 10:53 ` Simon Ser
2020-12-07 11:01 ` James Park
2020-12-07 11:14 ` Pekka Paalanen
2020-12-08 1:08 ` James Park
2021-08-17 17:21 ` Jason Ekstrand
2020-12-07 9:48 ` Simon Ser
2020-12-07 10:00 ` James Park
2020-12-07 10:02 ` Simon Ser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203125402.GH6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.park@lagfreegames.com \
--cc=jpark37@lagfreegames.com \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).