dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: James Park <james.park@lagfreegames.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	"Michel Dänzer" <michel@daenzer.net>,
	"James Park" <jpark37@lagfreegames.com>
Subject: Re: [PATCH] drm: Fix drm.h uapi header for Windows
Date: Mon, 7 Dec 2020 12:44:54 +0200	[thread overview]
Message-ID: <20201207124454.42b87186@eldfell> (raw)
In-Reply-To: <20201207123514.65e4b868@eldfell>


[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]

On Mon, 7 Dec 2020 12:35:14 +0200
Pekka Paalanen <ppaalanen@gmail.com> wrote:

> On Mon, 7 Dec 2020 01:08:58 -0800
> James Park <james.park@lagfreegames.com> wrote:
> 
> > I'm not completely sure what you're saying, but doesn't drm_base_types.h
> > (now drm_basic_types.h) make things robust to header order? The patch is in
> > another email. You can also see it here:
> > https://github.com/jpark37/linux/commit/0cc8ae750bfd9eab7e31c7de6aa84f24682f4f18  
> 
> If that is robust (I don't know if it is, I haven't checked), then why
> do you have #ifdef DRM_FOURCC_STANDALONE in it at all?
> 
> Like Simon said:
> 
> On Mon, 07 Dec 2020 10:02:36 +0000
> Simon Ser <contact@emersion.fr> wrote:
> 
> > In my compositors I'd like to globally define DRM_FOURCC_STANDALONE
> > (to make sure I don't miss any #define) but I still may include drm.h
> > in the same files as well.  
> 
> If any project #defines it globally, then what good does checking for
> it do? Why not assume that everyone will always want what
> DRM_FOURCC_STANDALONE would bring?

Sorry! Now I got it.

DRM_FOURCC_STANDALONE is a promise that the user is not relying on
drm_foucc.h to pull in drm.h. Nothing else. That's fine.

But then, the code in the header should be literally

#ifndef DRM_FOURCC_STANDALONE
#include "drm.h"
#endif

without an #else branch.


Thanks,
pq

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-07 10:45 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 10:01 drm: Fix drm.h uapi header for Windows James Park
2020-12-01 10:01 ` [PATCH] " James Park
2020-12-02  8:46   ` Simon Ser
2020-12-02  9:07     ` James Park
2020-12-02  9:07       ` James Park
2020-12-02 11:42   ` Michel Dänzer
2020-12-02 12:46     ` Daniel Vetter
2020-12-02 18:06       ` Michel Dänzer
2020-12-02 19:47         ` James Park
2020-12-02 22:25           ` Daniel Vetter
2020-12-03  1:24             ` James Park
2020-12-03  9:05             ` Pekka Paalanen
2020-12-03 12:54             ` Ville Syrjälä
2020-12-03 13:13               ` Simon Ser
2020-12-03  8:18           ` Michel Dänzer
2020-12-03 14:52             ` Daniel Vetter
2020-12-03 18:55               ` James Park
2020-12-03 20:45                 ` Daniel Vetter
2020-12-04  4:53                   ` [PATCH] drm: Allow drm_fourcc.h without including drm.h James Park
2020-12-04  4:53                     ` James Park
2020-12-04  8:53                       ` Simon Ser
2020-12-04  9:47                         ` James Park
2020-12-04 10:08                           ` James Park
2020-12-04 14:46                       ` kernel test robot
2020-12-04 22:29                       ` kernel test robot
2020-12-04  8:11                   ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-04 15:58                     ` Daniel Vetter
2020-12-04 19:07                       ` James Park
2020-12-06  0:39                         ` [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE James Park
2020-12-06  0:39                           ` James Park
2020-12-07  9:45                             ` Simon Ser
2020-12-07  9:55                               ` James Park
2020-12-07  9:59                                 ` Simon Ser
2020-12-07 10:05                                   ` James Park
2020-12-07 10:15                                     ` Simon Ser
2020-12-07 17:25                             ` kernel test robot
2020-12-07 18:15                               ` James Park
2020-12-07 18:15                                 ` James Park
2020-12-08 12:31                                   ` Simon Ser
2020-12-08 18:32                                     ` James Park
2020-12-09 10:15                                       ` Simon Ser
2020-12-09 10:18                                   ` Simon Ser
2020-12-09 11:03                                     ` James Park
2020-12-09 11:03                                       ` James Park
2020-12-10  8:35                                         ` Pekka Paalanen
2020-12-10  9:12                                           ` James Park
2020-12-10  9:12                                             ` James Park
2021-02-01 21:45                                               ` James Park
2021-02-02 17:28                                                 ` Emil Velikov
2021-02-02 18:14                                                   ` James Park
2021-02-02 22:48                                                     ` Emil Velikov
2021-02-02 23:05                                                       ` Simon Ser
2021-02-02  8:51                                               ` Simon Ser
2021-02-02  8:52                                                 ` Simon Ser
2020-12-07  8:51                         ` [PATCH] drm: Fix drm.h uapi header for Windows Pekka Paalanen
2020-12-07  9:08                           ` James Park
2020-12-07 10:35                             ` Pekka Paalanen
2020-12-07 10:44                               ` Pekka Paalanen [this message]
2020-12-07 10:47                                 ` Simon Ser
2020-12-07 10:49                                   ` James Park
2020-12-07 10:53                                     ` Simon Ser
2020-12-07 11:01                                       ` James Park
2020-12-07 11:14                                       ` Pekka Paalanen
2020-12-08  1:08                                         ` James Park
2021-08-17 17:21                                           ` Jason Ekstrand
2020-12-07  9:48                         ` Simon Ser
2020-12-07 10:00                           ` James Park
2020-12-07 10:02                             ` Simon Ser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207124454.42b87186@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=james.park@lagfreegames.com \
    --cc=jpark37@lagfreegames.com \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).