* [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev @ 2021-04-27 17:48 Thomas Zimmermann 2021-04-27 17:52 ` Ruhl, Michael J 0 siblings, 1 reply; 3+ messages in thread From: Thomas Zimmermann @ 2021-04-27 17:48 UTC (permalink / raw) To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel, matthew.auld, michael.j.ruhl Cc: Tvrtko Ursulin, Tvrtko Ursulin, Jani Nikula, Mika Kuoppala, intel-gfx, Gustavo A. R. Silva, dri-devel, Chris Wilson, CQ Tang, Thomas Hellström, Thomas Zimmermann, Daniel Vetter, Xinyun Liu, Dan Carpenter References to struct drm_device.pdev should not be used any longer as the field will be moved into the struct's legacy section. Add a fix for the rsp commit. v2: * fix an error in the commit description (Michael) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Jani Nikula <jani.nikula@intel.com> Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local memory") Cc: CQ Tang <cq.tang@intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Xinyun Liu <xinyun.liu@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: "Thomas Hellström" <thomas.hellstrom@intel.com> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index c5b64b2400e8..e1a32672bbe8 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c @@ -773,7 +773,7 @@ struct intel_memory_region * i915_gem_stolen_lmem_setup(struct drm_i915_private *i915) { struct intel_uncore *uncore = &i915->uncore; - struct pci_dev *pdev = i915->drm.pdev; + struct pci_dev *pdev = to_pci_dev(i915->drm.dev); struct intel_memory_region *mem; resource_size_t io_start; resource_size_t lmem_size; -- 2.31.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev 2021-04-27 17:48 [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev Thomas Zimmermann @ 2021-04-27 17:52 ` Ruhl, Michael J 2021-04-29 9:32 ` Jani Nikula 0 siblings, 1 reply; 3+ messages in thread From: Ruhl, Michael J @ 2021-04-27 17:52 UTC (permalink / raw) To: Thomas Zimmermann, jani.nikula, joonas.lahtinen, Vivi, Rodrigo, airlied, daniel, Auld, Matthew Cc: Tvrtko Ursulin, Ursulin, Tvrtko, Nikula, Jani, Mika Kuoppala, intel-gfx, Gustavo A. R. Silva, dri-devel, Chris Wilson, Tang, CQ, Hellstrom, Thomas, Daniel Vetter, Liu, Xinyun, Dan Carpenter >-----Original Message----- >From: Thomas Zimmermann <tzimmermann@suse.de> >Sent: Tuesday, April 27, 2021 1:49 PM >To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo ><rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; Auld, Matthew ><matthew.auld@intel.com>; Ruhl, Michael J <michael.j.ruhl@intel.com> >Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Thomas >Zimmermann <tzimmermann@suse.de>; Nikula, Jani ><jani.nikula@intel.com>; Tang, CQ <cq.tang@intel.com>; Tvrtko Ursulin ><tvrtko.ursulin@linux.intel.com>; Liu, Xinyun <xinyun.liu@intel.com>; Ursulin, >Tvrtko <tvrtko.ursulin@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; >Mika Kuoppala <mika.kuoppala@linux.intel.com>; Daniel Vetter ><daniel.vetter@ffwll.ch>; Maarten Lankhorst ><maarten.lankhorst@linux.intel.com>; Hellstrom, Thomas ><thomas.hellstrom@intel.com>; Gustavo A. R. Silva ><gustavoars@kernel.org>; Dan Carpenter <dan.carpenter@oracle.com> >Subject: [PATCH v2] drm/i915/gem: Remove reference to struct >drm_device.pdev > >References to struct drm_device.pdev should not be used any longer as >the field will be moved into the struct's legacy section. Add a fix >for the rsp commit. Commit message match the patch. Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com M >v2: > * fix an error in the commit description (Michael) > >Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >Reviewed-by: Jani Nikula <jani.nikula@intel.com> >Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local >memory") >Cc: CQ Tang <cq.tang@intel.com> >Cc: Matthew Auld <matthew.auld@intel.com> >Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >Cc: Xinyun Liu <xinyun.liu@intel.com> >Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >Cc: Jani Nikula <jani.nikula@linux.intel.com> >Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >Cc: Chris Wilson <chris@chris-wilson.co.uk> >Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> >Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >Cc: "Thomas Hellström" <thomas.hellstrom@intel.com> >Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> >Cc: Dan Carpenter <dan.carpenter@oracle.com> >Cc: intel-gfx@lists.freedesktop.org >--- > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >index c5b64b2400e8..e1a32672bbe8 100644 >--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >@@ -773,7 +773,7 @@ struct intel_memory_region * > i915_gem_stolen_lmem_setup(struct drm_i915_private *i915) > { > struct intel_uncore *uncore = &i915->uncore; >- struct pci_dev *pdev = i915->drm.pdev; >+ struct pci_dev *pdev = to_pci_dev(i915->drm.dev); > struct intel_memory_region *mem; > resource_size_t io_start; > resource_size_t lmem_size; >-- >2.31.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev 2021-04-27 17:52 ` Ruhl, Michael J @ 2021-04-29 9:32 ` Jani Nikula 0 siblings, 0 replies; 3+ messages in thread From: Jani Nikula @ 2021-04-29 9:32 UTC (permalink / raw) To: Ruhl, Michael J, Thomas Zimmermann, joonas.lahtinen, Vivi, Rodrigo, airlied, daniel, Auld, Matthew Cc: Tvrtko Ursulin, Ursulin, Tvrtko, Mika Kuoppala, intel-gfx, Gustavo A. R. Silva, dri-devel, Chris Wilson, Tang, CQ, Hellstrom, Thomas, Daniel Vetter, Liu, Xinyun, Dan Carpenter On Tue, 27 Apr 2021, "Ruhl, Michael J" <michael.j.ruhl@intel.com> wrote: >>-----Original Message----- >>From: Thomas Zimmermann <tzimmermann@suse.de> >>Sent: Tuesday, April 27, 2021 1:49 PM >>To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rodrigo >><rodrigo.vivi@intel.com>; airlied@linux.ie; daniel@ffwll.ch; Auld, Matthew >><matthew.auld@intel.com>; Ruhl, Michael J <michael.j.ruhl@intel.com> >>Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Thomas >>Zimmermann <tzimmermann@suse.de>; Nikula, Jani >><jani.nikula@intel.com>; Tang, CQ <cq.tang@intel.com>; Tvrtko Ursulin >><tvrtko.ursulin@linux.intel.com>; Liu, Xinyun <xinyun.liu@intel.com>; Ursulin, >>Tvrtko <tvrtko.ursulin@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; >>Mika Kuoppala <mika.kuoppala@linux.intel.com>; Daniel Vetter >><daniel.vetter@ffwll.ch>; Maarten Lankhorst >><maarten.lankhorst@linux.intel.com>; Hellstrom, Thomas >><thomas.hellstrom@intel.com>; Gustavo A. R. Silva >><gustavoars@kernel.org>; Dan Carpenter <dan.carpenter@oracle.com> >>Subject: [PATCH v2] drm/i915/gem: Remove reference to struct >>drm_device.pdev >> >>References to struct drm_device.pdev should not be used any longer as >>the field will be moved into the struct's legacy section. Add a fix >>for the rsp commit. > > Commit message match the patch. > > Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com Thanks for the patch and review, pushed to drm-intel-gt-next. BR, Jani. > > M > >>v2: >> * fix an error in the commit description (Michael) >> >>Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >>Reviewed-by: Jani Nikula <jani.nikula@intel.com> >>Fixes: d57d4a1daf5e ("drm/i915: Create stolen memory region from local >>memory") >>Cc: CQ Tang <cq.tang@intel.com> >>Cc: Matthew Auld <matthew.auld@intel.com> >>Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>Cc: Xinyun Liu <xinyun.liu@intel.com> >>Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>Cc: Jani Nikula <jani.nikula@linux.intel.com> >>Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >>Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >>Cc: Chris Wilson <chris@chris-wilson.co.uk> >>Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> >>Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >>Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >>Cc: "Thomas Hellström" <thomas.hellstrom@intel.com> >>Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> >>Cc: Dan Carpenter <dan.carpenter@oracle.com> >>Cc: intel-gfx@lists.freedesktop.org >>--- >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >>b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >>index c5b64b2400e8..e1a32672bbe8 100644 >>--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >>+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >>@@ -773,7 +773,7 @@ struct intel_memory_region * >> i915_gem_stolen_lmem_setup(struct drm_i915_private *i915) >> { >> struct intel_uncore *uncore = &i915->uncore; >>- struct pci_dev *pdev = i915->drm.pdev; >>+ struct pci_dev *pdev = to_pci_dev(i915->drm.dev); >> struct intel_memory_region *mem; >> resource_size_t io_start; >> resource_size_t lmem_size; >>-- >>2.31.1 > -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-29 9:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-27 17:48 [PATCH v2] drm/i915/gem: Remove reference to struct drm_device.pdev Thomas Zimmermann 2021-04-27 17:52 ` Ruhl, Michael J 2021-04-29 9:32 ` Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).