dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state
@ 2021-04-29 12:38 Wan Jiabing
  2021-04-29 14:30 ` Rodrigo Siqueira
  0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-04-29 12:38 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Airlie, Daniel Vetter, Aric Cyr, Rodrigo Siqueira,
	Qingqing Zhuo, Aurabindo Pillai, Bhawanpreet Lakha, Jacky Liao,
	Meenakshikumar Somasundaram, Nicholas Kazlauskas, Wenjing Liu,
	amd-gfx, dri-devel, linux-kernel
  Cc: kael_w, Wan Jiabing

There are two declarations of struct dc_state here.
Remove the later duplicate more secure.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Remove the later duplicate instead of the former.
---
 drivers/gpu/drm/amd/display/dc/dc.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 8108b82bac60..6f3c95b5d1a2 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
 	int min_dcfclk_mhz;
 };
 
-struct dc_state;
 struct resource_pool;
 struct dce_hwseq;
 struct gpu_info_soc_bounding_box_v1_0;
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state
  2021-04-29 12:38 [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state Wan Jiabing
@ 2021-04-29 14:30 ` Rodrigo Siqueira
  2021-04-29 14:40   ` Rodrigo Siqueira
  0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Siqueira @ 2021-04-29 14:30 UTC (permalink / raw)
  To: Wan Jiabing
  Cc: Jacky Liao, Leo Li, Bhawanpreet Lakha, Qingqing Zhuo,
	Wenjing Liu, linux-kernel, amd-gfx, Nicholas Kazlauskas,
	Meenakshikumar Somasundaram, David Airlie, Aurabindo Pillai,
	dri-devel, Alex Deucher, kael_w, Christian König


[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

On 04/29, Wan Jiabing wrote:
> There are two declarations of struct dc_state here.
> Remove the later duplicate more secure.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Remove the later duplicate instead of the former.
> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 8108b82bac60..6f3c95b5d1a2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
>  	int min_dcfclk_mhz;
>  };
>  
> -struct dc_state;
>  struct resource_pool;
>  struct dce_hwseq;
>  struct gpu_info_soc_bounding_box_v1_0;
> -- 
> 2.25.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state
  2021-04-29 14:30 ` Rodrigo Siqueira
@ 2021-04-29 14:40   ` Rodrigo Siqueira
  0 siblings, 0 replies; 3+ messages in thread
From: Rodrigo Siqueira @ 2021-04-29 14:40 UTC (permalink / raw)
  To: Wan Jiabing
  Cc: Jacky Liao, Leo Li, Bhawanpreet Lakha, Qingqing Zhuo,
	Wenjing Liu, linux-kernel, amd-gfx, Nicholas Kazlauskas,
	Meenakshikumar Somasundaram, David Airlie, Aurabindo Pillai,
	dri-devel, Alex Deucher, kael_w, Christian König


[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

Applied to amd-staging-drm-next.

Thanks

On 04/29, Rodrigo Siqueira wrote:
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> 
> On 04/29, Wan Jiabing wrote:
> > There are two declarations of struct dc_state here.
> > Remove the later duplicate more secure.
> > 
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> > ---
> > Changelog:
> > v2:
> > - Remove the later duplicate instead of the former.
> > ---
> >  drivers/gpu/drm/amd/display/dc/dc.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> > index 8108b82bac60..6f3c95b5d1a2 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dc.h
> > +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> > @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
> >  	int min_dcfclk_mhz;
> >  };
> >  
> > -struct dc_state;
> >  struct resource_pool;
> >  struct dce_hwseq;
> >  struct gpu_info_soc_bounding_box_v1_0;
> > -- 
> > 2.25.1
> > 
> 
> -- 
> Rodrigo Siqueira
> https://siqueira.tech



-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-29 14:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 12:38 [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state Wan Jiabing
2021-04-29 14:30 ` Rodrigo Siqueira
2021-04-29 14:40   ` Rodrigo Siqueira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).