* [PATCH] drm/i915: Disable bonding on gen12+ platforms
@ 2021-07-28 19:21 Matthew Brost
2021-08-06 18:25 ` [Intel-gfx] " John Harrison
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Brost @ 2021-07-28 19:21 UTC (permalink / raw)
To: intel-gfx, dri-devel
Disable bonding on gen12+ platforms aside from ones already supported by
the i915 - TGL, RKL, and ADL-S.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 05c3ee191710..9c3672bac0e2 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
u16 idx, num_bonds;
int err, n;
+ if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
+ !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
+ drm_dbg(&i915->drm,
+ "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
+ return -ENODEV;
+ }
+
if (get_user(idx, &ext->virtual_index))
return -EFAULT;
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms
2021-07-28 19:21 [PATCH] drm/i915: Disable bonding on gen12+ platforms Matthew Brost
@ 2021-08-06 18:25 ` John Harrison
2021-08-06 18:54 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: John Harrison @ 2021-08-06 18:25 UTC (permalink / raw)
To: Matthew Brost, intel-gfx, dri-devel
On 7/28/2021 12:21, Matthew Brost wrote:
> Disable bonding on gen12+ platforms aside from ones already supported by
> the i915 - TGL, RKL, and ADL-S.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 05c3ee191710..9c3672bac0e2 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
> u16 idx, num_bonds;
> int err, n;
>
> + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
> + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
> + drm_dbg(&i915->drm,
> + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
I would have said not supported rather than not allowed. Either way:
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
> + return -ENODEV;
> + }
> +
> if (get_user(idx, &ext->virtual_index))
> return -EFAULT;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms
2021-08-06 18:25 ` [Intel-gfx] " John Harrison
@ 2021-08-06 18:54 ` Daniel Vetter
2021-08-07 5:02 ` Matt Roper
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2021-08-06 18:54 UTC (permalink / raw)
To: John Harrison; +Cc: Matthew Brost, intel-gfx, dri-devel
On Fri, Aug 6, 2021 at 8:25 PM John Harrison <john.c.harrison@intel.com> wrote:
> On 7/28/2021 12:21, Matthew Brost wrote:
> > Disable bonding on gen12+ platforms aside from ones already supported by
> > the i915 - TGL, RKL, and ADL-S.
> >
> > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index 05c3ee191710..9c3672bac0e2 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
> > u16 idx, num_bonds;
> > int err, n;
> >
> > + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
> > + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
> > + drm_dbg(&i915->drm,
> > + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
> I would have said not supported rather than not allowed. Either way:
> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Either is fine with me.
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> > + return -ENODEV;
> > + }
> > +
> > if (get_user(idx, &ext->virtual_index))
> > return -EFAULT;
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms
2021-08-06 18:54 ` Daniel Vetter
@ 2021-08-07 5:02 ` Matt Roper
2021-11-26 13:03 ` Tvrtko Ursulin
0 siblings, 1 reply; 5+ messages in thread
From: Matt Roper @ 2021-08-07 5:02 UTC (permalink / raw)
To: Daniel Vetter; +Cc: John Harrison, Matthew Brost, intel-gfx, dri-devel
On Fri, Aug 06, 2021 at 08:54:59PM +0200, Daniel Vetter wrote:
> On Fri, Aug 6, 2021 at 8:25 PM John Harrison <john.c.harrison@intel.com> wrote:
> > On 7/28/2021 12:21, Matthew Brost wrote:
> > > Disable bonding on gen12+ platforms aside from ones already supported by
> > > the i915 - TGL, RKL, and ADL-S.
> > >
> > > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > > index 05c3ee191710..9c3672bac0e2 100644
> > > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > > @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
> > > u16 idx, num_bonds;
> > > int err, n;
> > >
> > > + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
> > > + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
> > > + drm_dbg(&i915->drm,
> > > + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
> > I would have said not supported rather than not allowed. Either way:
> > Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>
> Either is fine with me.
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
Applied to drm-intel-gt-next (with the suggested debug message wording
tweak). Thanks for the patch and reviews.
Matt
> >
> > > + return -ENODEV;
> > > + }
> > > +
> > > if (get_user(idx, &ext->virtual_index))
> > > return -EFAULT;
> > >
> >
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Disable bonding on gen12+ platforms
2021-08-07 5:02 ` Matt Roper
@ 2021-11-26 13:03 ` Tvrtko Ursulin
0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2021-11-26 13:03 UTC (permalink / raw)
To: Matt Roper, Daniel Vetter
Cc: Matthew Brost, intel-gfx, dri-devel, John Harrison
On 07/08/2021 06:02, Matt Roper wrote:
> On Fri, Aug 06, 2021 at 08:54:59PM +0200, Daniel Vetter wrote:
>> On Fri, Aug 6, 2021 at 8:25 PM John Harrison <john.c.harrison@intel.com> wrote:
>>> On 7/28/2021 12:21, Matthew Brost wrote:
>>>> Disable bonding on gen12+ platforms aside from ones already supported by
>>>> the i915 - TGL, RKL, and ADL-S.
Does this needs adjusting for the change in ADL-P plans?
Regards,
Tvrtko
>>>>
>>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> index 05c3ee191710..9c3672bac0e2 100644
>>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
>>>> @@ -446,6 +446,13 @@ set_proto_ctx_engines_bond(struct i915_user_extension __user *base, void *data)
>>>> u16 idx, num_bonds;
>>>> int err, n;
>>>>
>>>> + if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915) &&
>>>> + !IS_ROCKETLAKE(i915) && !IS_ALDERLAKE_S(i915)) {
>>>> + drm_dbg(&i915->drm,
>>>> + "Bonding on gen12+ aside from TGL, RKL, and ADL_S not allowed\n");
>>> I would have said not supported rather than not allowed. Either way:
>>> Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>>
>> Either is fine with me.
>>
>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>
> Applied to drm-intel-gt-next (with the suggested debug message wording
> tweak). Thanks for the patch and reviews.
>
>
> Matt
>
>>>
>>>> + return -ENODEV;
>>>> + }
>>>> +
>>>> if (get_user(idx, &ext->virtual_index))
>>>> return -EFAULT;
>>>>
>>>
>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-26 13:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 19:21 [PATCH] drm/i915: Disable bonding on gen12+ platforms Matthew Brost
2021-08-06 18:25 ` [Intel-gfx] " John Harrison
2021-08-06 18:54 ` Daniel Vetter
2021-08-07 5:02 ` Matt Roper
2021-11-26 13:03 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).