* [PATCH v3] drm: add a check to verify the size alignment
@ 2022-04-11 7:38 Arunpravin Paneer Selvam
2022-04-11 9:47 ` Matthew Auld
0 siblings, 1 reply; 6+ messages in thread
From: Arunpravin Paneer Selvam @ 2022-04-11 7:38 UTC (permalink / raw)
To: intel-gfx, amd-gfx, dri-devel
Cc: alexander.deucher, Arunpravin Paneer Selvam, matthew.auld,
christian.koenig
Add a simple check to reject any size not aligned to the
min_page_size.
when size is not aligned to min_page_size, driver module
should handle in their own way either to round_up() the
size value to min_page_size or just to enable WARN_ON().
If we dont handle the alignment properly, we may hit the
following bug, Unigine Heaven has allocation requests for
example required pages are 257 and alignment request is 256.
To allocate the left over 1 page, continues the iteration to
find the order value which is 0 and when it compares with
min_order = 8, triggers the BUG_ON(order < min_order).
v2: add more commit description
v3: remove WARN_ON()
Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/drm_buddy.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 72f52f293249..11bb59399471 100644
--- a/drivers/gpu/drm/drm_buddy.c
+++ b/drivers/gpu/drm/drm_buddy.c
@@ -665,6 +665,9 @@ int drm_buddy_alloc_blocks(struct drm_buddy *mm,
if (start + size == end)
return __drm_buddy_alloc_range(mm, start, size, blocks);
+ if (!IS_ALIGNED(size, min_page_size))
+ return -EINVAL;
+
pages = size >> ilog2(mm->chunk_size);
order = fls(pages) - 1;
min_order = ilog2(min_page_size) - ilog2(mm->chunk_size);
base-commit: 4dcdb745569d8eef8db09e24e8ff2e5dffc0664c
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm: add a check to verify the size alignment
2022-04-11 7:38 [PATCH v3] drm: add a check to verify the size alignment Arunpravin Paneer Selvam
@ 2022-04-11 9:47 ` Matthew Auld
2022-04-11 12:42 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2022-04-11 9:47 UTC (permalink / raw)
To: Arunpravin Paneer Selvam, intel-gfx, amd-gfx, dri-devel
Cc: alexander.deucher, christian.koenig
On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
> Add a simple check to reject any size not aligned to the
> min_page_size.
>
> when size is not aligned to min_page_size, driver module
> should handle in their own way either to round_up() the
> size value to min_page_size or just to enable WARN_ON().
>
> If we dont handle the alignment properly, we may hit the
> following bug, Unigine Heaven has allocation requests for
> example required pages are 257 and alignment request is 256.
> To allocate the left over 1 page, continues the iteration to
> find the order value which is 0 and when it compares with
> min_order = 8, triggers the BUG_ON(order < min_order).
>
> v2: add more commit description
> v3: remove WARN_ON()
>
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm: add a check to verify the size alignment
2022-04-11 9:47 ` Matthew Auld
@ 2022-04-11 12:42 ` Christian König
2022-04-11 13:32 ` Matthew Auld
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2022-04-11 12:42 UTC (permalink / raw)
To: Matthew Auld, Arunpravin Paneer Selvam, intel-gfx, amd-gfx, dri-devel
Cc: alexander.deucher, christian.koenig
Am 11.04.22 um 11:47 schrieb Matthew Auld:
> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>> Add a simple check to reject any size not aligned to the
>> min_page_size.
>>
>> when size is not aligned to min_page_size, driver module
>> should handle in their own way either to round_up() the
>> size value to min_page_size or just to enable WARN_ON().
>>
>> If we dont handle the alignment properly, we may hit the
>> following bug, Unigine Heaven has allocation requests for
>> example required pages are 257 and alignment request is 256.
>> To allocate the left over 1 page, continues the iteration to
>> find the order value which is 0 and when it compares with
>> min_order = 8, triggers the BUG_ON(order < min_order).
>>
>> v2: add more commit description
>> v3: remove WARN_ON()
>>
>> Signed-off-by: Arunpravin Paneer Selvam
>> <Arunpravin.PaneerSelvam@amd.com>
>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
Question here is who will be pushing that to drm-misc-next? Should I
take care of that?
I think it's time that Arun should request push permission for
drm-misc-next.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm: add a check to verify the size alignment
2022-04-11 12:42 ` Christian König
@ 2022-04-11 13:32 ` Matthew Auld
2022-04-11 13:49 ` Arunpravin Paneer Selvam
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2022-04-11 13:32 UTC (permalink / raw)
To: Christian König, Arunpravin Paneer Selvam, intel-gfx,
amd-gfx, dri-devel
Cc: alexander.deucher, christian.koenig
On 11/04/2022 13:42, Christian König wrote:
>
> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>> Add a simple check to reject any size not aligned to the
>>> min_page_size.
>>>
>>> when size is not aligned to min_page_size, driver module
>>> should handle in their own way either to round_up() the
>>> size value to min_page_size or just to enable WARN_ON().
>>>
>>> If we dont handle the alignment properly, we may hit the
>>> following bug, Unigine Heaven has allocation requests for
>>> example required pages are 257 and alignment request is 256.
>>> To allocate the left over 1 page, continues the iteration to
>>> find the order value which is 0 and when it compares with
>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>
>>> v2: add more commit description
>>> v3: remove WARN_ON()
>>>
>>> Signed-off-by: Arunpravin Paneer Selvam
>>> <Arunpravin.PaneerSelvam@amd.com>
>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>
>
> Question here is who will be pushing that to drm-misc-next? Should I
> take care of that?
Yes, please do.
>
> I think it's time that Arun should request push permission for
> drm-misc-next.
>
> Thanks,
> Christian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm: add a check to verify the size alignment
2022-04-11 13:32 ` Matthew Auld
@ 2022-04-11 13:49 ` Arunpravin Paneer Selvam
2022-04-11 13:44 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Arunpravin Paneer Selvam @ 2022-04-11 13:49 UTC (permalink / raw)
To: Matthew Auld, Christian König, intel-gfx, amd-gfx, dri-devel
Cc: alexander.deucher, christian.koenig
On 11/04/22 7:02 pm, Matthew Auld wrote:
> On 11/04/2022 13:42, Christian König wrote:
>>
>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>> Add a simple check to reject any size not aligned to the
>>>> min_page_size.
>>>>
>>>> when size is not aligned to min_page_size, driver module
>>>> should handle in their own way either to round_up() the
>>>> size value to min_page_size or just to enable WARN_ON().
>>>>
>>>> If we dont handle the alignment properly, we may hit the
>>>> following bug, Unigine Heaven has allocation requests for
>>>> example required pages are 257 and alignment request is 256.
>>>> To allocate the left over 1 page, continues the iteration to
>>>> find the order value which is 0 and when it compares with
>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>
>>>> v2: add more commit description
>>>> v3: remove WARN_ON()
>>>>
>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>
>>
>> Question here is who will be pushing that to drm-misc-next? Should I
>> take care of that?
>
> Yes, please do.
>
>>
>> I think it's time that Arun should request push permission for
>> drm-misc-next.
How to get push permission for drm-misc-next, should I send request mail
to maintainers, may be next time I will push myself.
Thanks,
Arun
>>
>> Thanks,
>> Christian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] drm: add a check to verify the size alignment
2022-04-11 13:49 ` Arunpravin Paneer Selvam
@ 2022-04-11 13:44 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2022-04-11 13:44 UTC (permalink / raw)
To: Arunpravin Paneer Selvam, Matthew Auld, intel-gfx, amd-gfx, dri-devel
Cc: alexander.deucher, christian.koenig
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.
See here
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html
Regards,
Christian.
>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-11 13:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 7:38 [PATCH v3] drm: add a check to verify the size alignment Arunpravin Paneer Selvam
2022-04-11 9:47 ` Matthew Auld
2022-04-11 12:42 ` Christian König
2022-04-11 13:32 ` Matthew Auld
2022-04-11 13:49 ` Arunpravin Paneer Selvam
2022-04-11 13:44 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).