* [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels
@ 2022-09-20 14:59 Chris Morgan
2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Chris Morgan @ 2022-09-20 14:59 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan,
robh+dt, thierry.reding, sam
From: Chris Morgan <macromorgan@hotmail.com>
Add the NewVision NV3051D panel as found on the Anbernic RG353P and
RG353V. The underlying LCD panel itself is unknown (the NV3051D is
the controller), so the device name is used for the panel with a
fallback to the driver IC.
Changes from V1:
- Changed compatible string to the driver IC.
- Updated documentation to use new compatible string with board
name.
- Refactored somewhat to make it easier to support other LCD panels
with this kernel module.
- Added support for 60hz mode. Adjusted pixel clock to ensure proper
60hz and 120hz (previously was running at 124hz).
- Added vendor prefix for NewVision. Anbernic vendor prefix added in
https://lore.kernel.org/linux-devicetree/20220906210324.28986-2-macroalpha82@gmail.com
Chris Morgan (3):
dt-bindings: vendor-prefixes: add NewVision vendor prefix
dt-bindings: display: panel: Add NewVision NV3051D bindings
drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel
.../display/panel/newvision,nv3051d.yaml | 55 ++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
.../gpu/drm/panel/panel-newvision-nv3051d.c | 513 ++++++++++++++++++
5 files changed, 580 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3051d.c
--
2.25.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix 2022-09-20 14:59 [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels Chris Morgan @ 2022-09-20 14:59 ` Chris Morgan 2022-09-21 6:50 ` Krzysztof Kozlowski 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan 2022-09-20 14:59 ` [PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel Chris Morgan 2 siblings, 1 reply; 14+ messages in thread From: Chris Morgan @ 2022-09-20 14:59 UTC (permalink / raw) To: dri-devel Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, robh+dt, thierry.reding, sam From: Chris Morgan <macromorgan@hotmail.com> NewVision (also sometimes written as New Vision) is a company based in Shenzen that manufactures ICs for controlling LCD panels. https://www.newvisiondisplay.com/ Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 2f0151e9f6be..d9c38e214863 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -873,6 +873,8 @@ patternProperties: description: Shenzhen Netxeon Technology CO., LTD "^neweast,.*": description: Guangdong Neweast Optoelectronics CO., LTD + "^newvision,.*": + description: New Vision Display (Shenzhen) Co., Ltd. "^nexbox,.*": description: Nexbox "^nextthing,.*": -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix 2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan @ 2022-09-21 6:50 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-09-21 6:50 UTC (permalink / raw) To: Chris Morgan, dri-devel Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, robh+dt, thierry.reding, sam On 20/09/2022 16:59, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > NewVision (also sometimes written as New Vision) is a company based in > Shenzen that manufactures ICs for controlling LCD panels. > > https://www.newvisiondisplay.com/ > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-20 14:59 [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels Chris Morgan 2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan @ 2022-09-20 14:59 ` Chris Morgan 2022-09-21 6:51 ` Krzysztof Kozlowski ` (2 more replies) 2022-09-20 14:59 ` [PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel Chris Morgan 2 siblings, 3 replies; 14+ messages in thread From: Chris Morgan @ 2022-09-20 14:59 UTC (permalink / raw) To: dri-devel Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, robh+dt, thierry.reding, sam From: Chris Morgan <macromorgan@hotmail.com> Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p". Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml new file mode 100644 index 000000000000..d90bca4171c2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NewVision NV3051D based LCD panel + +description: | + The NewVision NV3051D is a driver chip used to drive DSI panels. For now, + this driver only supports the 640x480 panels found in the Anbernic RG353 + based devices. + +maintainers: + - Chris Morgan <macromorgan@hotmail.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panel + - const: newvision,nv3051d + reg: true + backlight: true + port: true + reset-gpios: true + vdd-supply: + description: regulator that supplies the vdd voltage + +required: + - compatible + - reg + - backlight + - vdd-supply + +additionalProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "anbernic,rg353p-panel"; + reg = <0>; + backlight = <&backlight>; + vdd-supply = <&vcc3v3_lcd>; + }; + }; + +... -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan @ 2022-09-21 6:51 ` Krzysztof Kozlowski 2022-09-21 14:38 ` Chris Morgan 2022-09-21 7:01 ` Krzysztof Kozlowski 2022-09-24 17:07 ` Rob Herring 2 siblings, 1 reply; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-09-21 6:51 UTC (permalink / raw) To: Chris Morgan, dri-devel Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, robh+dt, thierry.reding, sam On 20/09/2022 16:59, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the hardware itself is known as "anbernic,rg353p". > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > new file mode 100644 > index 000000000000..d90bca4171c2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NewVision NV3051D based LCD panel > + > +description: | > + The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > + this driver only supports the 640x480 panels found in the Anbernic RG353 > + based devices. > + > +maintainers: > + - Chris Morgan <macromorgan@hotmail.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - anbernic,rg353p-panel Are these vendor prefixs documented? > + - anbernic,rg353v-panel > + - const: newvision,nv3051d Blank line. > + reg: true > + backlight: true > + port: true > + reset-gpios: true > + vdd-supply: > + description: regulator that supplies the vdd voltage Skip description and make it just "true". It's kind of obvious. > + > +required: > + - compatible > + - reg > + - backlight > + - vdd-supply Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-21 6:51 ` Krzysztof Kozlowski @ 2022-09-21 14:38 ` Chris Morgan 2022-09-21 15:21 ` Krzysztof Kozlowski 0 siblings, 1 reply; 14+ messages in thread From: Chris Morgan @ 2022-09-21 14:38 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, robh+dt, thierry.reding, sam On Wed, Sep 21, 2022 at 08:51:34AM +0200, Krzysztof Kozlowski wrote: > On 20/09/2022 16:59, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel binding > > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > > is used because the hardware itself is known as "anbernic,rg353p". > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > new file mode 100644 > > index 000000000000..d90bca4171c2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fpanel%2Fnewvision%2Cnv3051d.yaml%23&data=05%7C01%7C%7C844872fdf91b413aa65a08da9b9db9e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637993398994635658%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eTM2IFjR0TKPlQNYfoq3Poao8QYLSHRVaqiXtufJ7VA%3D&reserved=0 > > +$schema: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7C%7C844872fdf91b413aa65a08da9b9db9e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637993398994635658%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sjb7x2Z2wKu1C8mMBW1epwuXipe8V26zxpHcCAuKLZY%3D&reserved=0 > > + > > +title: NewVision NV3051D based LCD panel > > + > > +description: | > > + The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > > + this driver only supports the 640x480 panels found in the Anbernic RG353 > > + based devices. > > + > > +maintainers: > > + - Chris Morgan <macromorgan@hotmail.com> > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - anbernic,rg353p-panel > > Are these vendor prefixs documented? Yes, they are in another patch series referenced in the cover letter. They were added for the Anbernic devicetrees and should (I believe) land in 6.1. > > > + - anbernic,rg353v-panel > > + - const: newvision,nv3051d > > Blank line. > Ack. > > + reg: true > > + backlight: true > > + port: true > > + reset-gpios: true > > + vdd-supply: > > + description: regulator that supplies the vdd voltage > > Skip description and make it just "true". It's kind of obvious. > Ack. > > + > > +required: > > + - compatible > > + - reg > > + - backlight > > + - vdd-supply > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-21 14:38 ` Chris Morgan @ 2022-09-21 15:21 ` Krzysztof Kozlowski 2022-09-21 15:50 ` Chris Morgan 0 siblings, 1 reply; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-09-21 15:21 UTC (permalink / raw) To: Chris Morgan Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, robh+dt, thierry.reding, sam On 21/09/2022 16:38, Chris Morgan wrote: >>> + compatible: >>> + items: >>> + - enum: >>> + - anbernic,rg353p-panel >> >> Are these vendor prefixs documented? > > Yes, they are in another patch series referenced in the cover letter. > They were added for the Anbernic devicetrees and should (I believe) > land in 6.1. OK... you still need to test your bindings. Your patch was clearly not tested before sending. :( Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-21 15:21 ` Krzysztof Kozlowski @ 2022-09-21 15:50 ` Chris Morgan 2022-09-21 15:57 ` Krzysztof Kozlowski 0 siblings, 1 reply; 14+ messages in thread From: Chris Morgan @ 2022-09-21 15:50 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, robh+dt, thierry.reding, sam On Wed, Sep 21, 2022 at 05:21:19PM +0200, Krzysztof Kozlowski wrote: > On 21/09/2022 16:38, Chris Morgan wrote: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - anbernic,rg353p-panel > >> > >> Are these vendor prefixs documented? > > > > Yes, they are in another patch series referenced in the cover letter. > > They were added for the Anbernic devicetrees and should (I believe) > > land in 6.1. > > OK... you still need to test your bindings. Your patch was clearly not > tested before sending. :( I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and make dtbs_check (with DT_SCHEMA_FILES specified again). That's the proper testing flow correct? In this case it's the pre-requisite that's causing the issue as I see on a pristine master tree I'm warned about the missing vendor prefix for anbernic. Should I wait for that to go upstream before I submit this again? I'll make the other change about the space and the description of the vdd-supply when I resubmit. Are we good with the panel compatibles? I'm still not entirely sure the best thing to name them as I have no part number whatsoever except the driver IC. Thank you. > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-21 15:50 ` Chris Morgan @ 2022-09-21 15:57 ` Krzysztof Kozlowski 2022-09-21 16:17 ` Chris Morgan 0 siblings, 1 reply; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-09-21 15:57 UTC (permalink / raw) To: Chris Morgan Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, robh+dt, thierry.reding, sam On 21/09/2022 17:50, Chris Morgan wrote: > On Wed, Sep 21, 2022 at 05:21:19PM +0200, Krzysztof Kozlowski wrote: >> On 21/09/2022 16:38, Chris Morgan wrote: >>>>> + compatible: >>>>> + items: >>>>> + - enum: >>>>> + - anbernic,rg353p-panel >>>> >>>> Are these vendor prefixs documented? >>> >>> Yes, they are in another patch series referenced in the cover letter. >>> They were added for the Anbernic devicetrees and should (I believe) >>> land in 6.1. >> >> OK... you still need to test your bindings. Your patch was clearly not >> tested before sending. :( > > I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and > make dtbs_check (with DT_SCHEMA_FILES specified again). I have doubts. So if you say you did it, then you probably did not look at the results... or whatever other reason the test was not effective, because your binding cannot pass the dt_binding_check. > That's the proper > testing flow correct? In this case it's the pre-requisite that's causing > the issue as I see on a pristine master tree I'm warned about the missing > vendor prefix for anbernic. Should I wait for that to go upstream before > I submit this again? Not really. The testing fails on wrong compatible in example. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-21 15:57 ` Krzysztof Kozlowski @ 2022-09-21 16:17 ` Chris Morgan 0 siblings, 0 replies; 14+ messages in thread From: Chris Morgan @ 2022-09-21 16:17 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, robh+dt, thierry.reding, sam On Wed, Sep 21, 2022 at 05:57:55PM +0200, Krzysztof Kozlowski wrote: > On 21/09/2022 17:50, Chris Morgan wrote: > > On Wed, Sep 21, 2022 at 05:21:19PM +0200, Krzysztof Kozlowski wrote: > >> On 21/09/2022 16:38, Chris Morgan wrote: > >>>>> + compatible: > >>>>> + items: > >>>>> + - enum: > >>>>> + - anbernic,rg353p-panel > >>>> > >>>> Are these vendor prefixs documented? > >>> > >>> Yes, they are in another patch series referenced in the cover letter. > >>> They were added for the Anbernic devicetrees and should (I believe) > >>> land in 6.1. > >> > >> OK... you still need to test your bindings. Your patch was clearly not > >> tested before sending. :( > > > > I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and > > make dtbs_check (with DT_SCHEMA_FILES specified again). > > I have doubts. So if you say you did it, then you probably did not look > at the results... or whatever other reason the test was not effective, > because your binding cannot pass the dt_binding_check. > > > That's the proper > > testing flow correct? In this case it's the pre-requisite that's causing > > the issue as I see on a pristine master tree I'm warned about the missing > > vendor prefix for anbernic. Should I wait for that to go upstream before > > I submit this again? > > Not really. The testing fails on wrong compatible in example. My mistake, I see what I did wrong and apologize for the trouble. I misinterpreted the error I did get (I expected an issue with a missing vendor string, but as you correctly point out the received error is not for that). I'll correct and resend. Would you be so kind as to confirm if you're okay with the "anbernic,rg353-panel", "newvision,nv3051d" strings? Thank you once again and I apologize for my mistake. > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan 2022-09-21 6:51 ` Krzysztof Kozlowski @ 2022-09-21 7:01 ` Krzysztof Kozlowski 2022-09-24 17:07 ` Rob Herring 2 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-09-21 7:01 UTC (permalink / raw) To: Chris Morgan Cc: devicetree, Chris Morgan, krzysztof.kozlowski+dt, airlied, robh+dt, thierry.reding, dri-devel, sam On Tue, 20 Sep 2022 09:59:04 -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the hardware itself is known as "anbernic,rg353p". > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.example.dtb: panel@0: compatible: ['anbernic,rg353p-panel'] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan 2022-09-21 6:51 ` Krzysztof Kozlowski 2022-09-21 7:01 ` Krzysztof Kozlowski @ 2022-09-24 17:07 ` Rob Herring 2022-09-24 17:51 ` Chris Morgan 2 siblings, 1 reply; 14+ messages in thread From: Rob Herring @ 2022-09-24 17:07 UTC (permalink / raw) To: Chris Morgan Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, dri-devel, thierry.reding, sam On Tue, Sep 20, 2022 at 09:59:04AM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the hardware itself is known as "anbernic,rg353p". > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > new file mode 100644 > index 000000000000..d90bca4171c2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NewVision NV3051D based LCD panel > + > +description: | > + The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > + this driver only supports the 640x480 panels found in the Anbernic RG353 > + based devices. > + > +maintainers: > + - Chris Morgan <macromorgan@hotmail.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - anbernic,rg353p-panel > + - anbernic,rg353v-panel Is 'panel' redundant? IOW, could 'rg353v' identify something else other than the panel? Rob ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings 2022-09-24 17:07 ` Rob Herring @ 2022-09-24 17:51 ` Chris Morgan 0 siblings, 0 replies; 14+ messages in thread From: Chris Morgan @ 2022-09-24 17:51 UTC (permalink / raw) To: Rob Herring Cc: devicetree, krzysztof.kozlowski+dt, airlied, dri-devel, Chris Morgan, thierry.reding, sam On Sat, Sep 24, 2022 at 12:07:44PM -0500, Rob Herring wrote: > On Tue, Sep 20, 2022 at 09:59:04AM -0500, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel binding > > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > > is used because the hardware itself is known as "anbernic,rg353p". > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > .../display/panel/newvision,nv3051d.yaml | 55 +++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > new file mode 100644 > > index 000000000000..d90bca4171c2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fpanel%2Fnewvision%2Cnv3051d.yaml%23&data=05%7C01%7C%7C4f204345128d4cb827ca08da9e4f4d06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637996360672620588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9%2B66S0t1p9EqWBdmaLBj8pKte2fjzsmL%2FSbmmD8eNi0%3D&reserved=0 > > +$schema: https://nam12.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7C%7C4f204345128d4cb827ca08da9e4f4d06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637996360672620588%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=r%2BzTHlte226t9fXktNC9k4NO%2FE2RomRIxuWBuRshIw0%3D&reserved=0 > > + > > +title: NewVision NV3051D based LCD panel > > + > > +description: | > > + The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > > + this driver only supports the 640x480 panels found in the Anbernic RG353 > > + based devices. > > + > > +maintainers: > > + - Chris Morgan <macromorgan@hotmail.com> > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - anbernic,rg353p-panel > > + - anbernic,rg353v-panel > > Is 'panel' redundant? IOW, could 'rg353v' identify something else other > than the panel? It is not redundant, the device itself is identified as "anbernic,rg353v". I don't have a part number for the LCD panel itself, only the controller IC. Thank you. > > Rob ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel 2022-09-20 14:59 [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels Chris Morgan 2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan @ 2022-09-20 14:59 ` Chris Morgan 2 siblings, 0 replies; 14+ messages in thread From: Chris Morgan @ 2022-09-20 14:59 UTC (permalink / raw) To: dri-devel Cc: devicetree, krzysztof.kozlowski+dt, airlied, Chris Morgan, robh+dt, thierry.reding, sam From: Chris Morgan <macromorgan@hotmail.com> Add NewVision NV3051D MIPI-DSI LCD panel Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying LCD part number for the RG353x devices is unknown, so the device name and a fallback for the driver IC is used instead. Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3051d.c | 513 ++++++++++++++++++ 3 files changed, 523 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3051d.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index a9043eacce97..7258d28dda2f 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -296,6 +296,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3051D + tristate "NewVision NV3051D DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + This driver supports the NV3051D based panel found on the Anbernic + RG353P and RG353V. + config DRM_PANEL_NEWVISION_NV3052C tristate "NewVision NV3052C RGB/SPI panel" depends on OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 34e717382dbb..cb03b3a82738 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -27,6 +27,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3051D) += panel-newvision-nv3051d.o obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c new file mode 100644 index 000000000000..be57b3579bd5 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c @@ -0,0 +1,513 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NV3051D MIPI-DSI panel driver for Anbernic RG353x + * Copyright (C) 2022 Chris Morgan + * + * based on + * + * Elida kd35t133 3.5" MIPI-DSI panel driver + * Copyright (C) Theobroma Systems 2020 + */ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/media-bus-format.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> + +#include <video/display_timing.h> +#include <video/mipi_display.h> + +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> + +struct nv3051d_panel_info { + const struct drm_display_mode *display_modes; + unsigned int num_modes; + u16 width_mm, height_mm; + u32 bus_flags; +}; + +struct panel_nv3051d { + struct device *dev; + struct drm_panel panel; + struct gpio_desc *reset_gpio; + const struct nv3051d_panel_info *panel_info; + struct regulator *vdd; + bool prepared; +}; + +static inline struct panel_nv3051d *panel_to_panelnv3051d(struct drm_panel *panel) +{ + return container_of(panel, struct panel_nv3051d, panel); +} + +#define dsi_dcs_write_seq(dsi, cmd, seq...) do { \ + static const u8 b[] = { cmd, seq }; \ + int ret; \ + ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b)); \ + if (ret < 0) \ + return ret; \ + } while (0) + +static int panel_nv3051d_init_sequence(struct panel_nv3051d *ctx) +{ + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); + + /* + * Init sequence was supplied by device vendor with no + * documentation. + */ + + dsi_dcs_write_seq(dsi, 0xFF, 0x30); + dsi_dcs_write_seq(dsi, 0xFF, 0x52); + dsi_dcs_write_seq(dsi, 0xFF, 0x01); + dsi_dcs_write_seq(dsi, 0xE3, 0x00); + dsi_dcs_write_seq(dsi, 0x03, 0x40); + dsi_dcs_write_seq(dsi, 0x04, 0x00); + dsi_dcs_write_seq(dsi, 0x05, 0x03); + dsi_dcs_write_seq(dsi, 0x24, 0x12); + dsi_dcs_write_seq(dsi, 0x25, 0x1E); + dsi_dcs_write_seq(dsi, 0x26, 0x28); + dsi_dcs_write_seq(dsi, 0x27, 0x52); + dsi_dcs_write_seq(dsi, 0x28, 0x57); + dsi_dcs_write_seq(dsi, 0x29, 0x01); + dsi_dcs_write_seq(dsi, 0x2A, 0xDF); + dsi_dcs_write_seq(dsi, 0x38, 0x9C); + dsi_dcs_write_seq(dsi, 0x39, 0xA7); + dsi_dcs_write_seq(dsi, 0x3A, 0x53); + dsi_dcs_write_seq(dsi, 0x44, 0x00); + dsi_dcs_write_seq(dsi, 0x49, 0x3C); + dsi_dcs_write_seq(dsi, 0x59, 0xFE); + dsi_dcs_write_seq(dsi, 0x5C, 0x00); + dsi_dcs_write_seq(dsi, 0x91, 0x77); + dsi_dcs_write_seq(dsi, 0x92, 0x77); + dsi_dcs_write_seq(dsi, 0xA0, 0x55); + dsi_dcs_write_seq(dsi, 0xA1, 0x50); + dsi_dcs_write_seq(dsi, 0xA4, 0x9C); + dsi_dcs_write_seq(dsi, 0xA7, 0x02); + dsi_dcs_write_seq(dsi, 0xA8, 0x01); + dsi_dcs_write_seq(dsi, 0xA9, 0x01); + dsi_dcs_write_seq(dsi, 0xAA, 0xFC); + dsi_dcs_write_seq(dsi, 0xAB, 0x28); + dsi_dcs_write_seq(dsi, 0xAC, 0x06); + dsi_dcs_write_seq(dsi, 0xAD, 0x06); + dsi_dcs_write_seq(dsi, 0xAE, 0x06); + dsi_dcs_write_seq(dsi, 0xAF, 0x03); + dsi_dcs_write_seq(dsi, 0xB0, 0x08); + dsi_dcs_write_seq(dsi, 0xB1, 0x26); + dsi_dcs_write_seq(dsi, 0xB2, 0x28); + dsi_dcs_write_seq(dsi, 0xB3, 0x28); + dsi_dcs_write_seq(dsi, 0xB4, 0x33); + dsi_dcs_write_seq(dsi, 0xB5, 0x08); + dsi_dcs_write_seq(dsi, 0xB6, 0x26); + dsi_dcs_write_seq(dsi, 0xB7, 0x08); + dsi_dcs_write_seq(dsi, 0xB8, 0x26); + dsi_dcs_write_seq(dsi, 0xFF, 0x30); + dsi_dcs_write_seq(dsi, 0xFF, 0x52); + dsi_dcs_write_seq(dsi, 0xFF, 0x02); + dsi_dcs_write_seq(dsi, 0xB1, 0x0E); + dsi_dcs_write_seq(dsi, 0xD1, 0x0E); + dsi_dcs_write_seq(dsi, 0xB4, 0x29); + dsi_dcs_write_seq(dsi, 0xD4, 0x2B); + dsi_dcs_write_seq(dsi, 0xB2, 0x0C); + dsi_dcs_write_seq(dsi, 0xD2, 0x0A); + dsi_dcs_write_seq(dsi, 0xB3, 0x28); + dsi_dcs_write_seq(dsi, 0xD3, 0x28); + dsi_dcs_write_seq(dsi, 0xB6, 0x11); + dsi_dcs_write_seq(dsi, 0xD6, 0x0D); + dsi_dcs_write_seq(dsi, 0xB7, 0x32); + dsi_dcs_write_seq(dsi, 0xD7, 0x30); + dsi_dcs_write_seq(dsi, 0xC1, 0x04); + dsi_dcs_write_seq(dsi, 0xE1, 0x06); + dsi_dcs_write_seq(dsi, 0xB8, 0x0A); + dsi_dcs_write_seq(dsi, 0xD8, 0x0A); + dsi_dcs_write_seq(dsi, 0xB9, 0x01); + dsi_dcs_write_seq(dsi, 0xD9, 0x01); + dsi_dcs_write_seq(dsi, 0xBD, 0x13); + dsi_dcs_write_seq(dsi, 0xDD, 0x13); + dsi_dcs_write_seq(dsi, 0xBC, 0x11); + dsi_dcs_write_seq(dsi, 0xDC, 0x11); + dsi_dcs_write_seq(dsi, 0xBB, 0x0F); + dsi_dcs_write_seq(dsi, 0xDB, 0x0F); + dsi_dcs_write_seq(dsi, 0xBA, 0x0F); + dsi_dcs_write_seq(dsi, 0xDA, 0x0F); + dsi_dcs_write_seq(dsi, 0xBE, 0x18); + dsi_dcs_write_seq(dsi, 0xDE, 0x18); + dsi_dcs_write_seq(dsi, 0xBF, 0x0F); + dsi_dcs_write_seq(dsi, 0xDF, 0x0F); + dsi_dcs_write_seq(dsi, 0xC0, 0x17); + dsi_dcs_write_seq(dsi, 0xE0, 0x17); + dsi_dcs_write_seq(dsi, 0xB5, 0x3B); + dsi_dcs_write_seq(dsi, 0xD5, 0x3C); + dsi_dcs_write_seq(dsi, 0xB0, 0x0B); + dsi_dcs_write_seq(dsi, 0xD0, 0x0C); + dsi_dcs_write_seq(dsi, 0xFF, 0x30); + dsi_dcs_write_seq(dsi, 0xFF, 0x52); + dsi_dcs_write_seq(dsi, 0xFF, 0x03); + dsi_dcs_write_seq(dsi, 0x00, 0x2A); + dsi_dcs_write_seq(dsi, 0x01, 0x2A); + dsi_dcs_write_seq(dsi, 0x02, 0x2A); + dsi_dcs_write_seq(dsi, 0x03, 0x2A); + dsi_dcs_write_seq(dsi, 0x04, 0x61); + dsi_dcs_write_seq(dsi, 0x05, 0x80); + dsi_dcs_write_seq(dsi, 0x06, 0xC7); + dsi_dcs_write_seq(dsi, 0x07, 0x01); + dsi_dcs_write_seq(dsi, 0x08, 0x82); + dsi_dcs_write_seq(dsi, 0x09, 0x83); + dsi_dcs_write_seq(dsi, 0x30, 0x2A); + dsi_dcs_write_seq(dsi, 0x31, 0x2A); + dsi_dcs_write_seq(dsi, 0x32, 0x2A); + dsi_dcs_write_seq(dsi, 0x33, 0x2A); + dsi_dcs_write_seq(dsi, 0x34, 0x61); + dsi_dcs_write_seq(dsi, 0x35, 0xC5); + dsi_dcs_write_seq(dsi, 0x36, 0x80); + dsi_dcs_write_seq(dsi, 0x37, 0x23); + dsi_dcs_write_seq(dsi, 0x40, 0x82); + dsi_dcs_write_seq(dsi, 0x41, 0x83); + dsi_dcs_write_seq(dsi, 0x42, 0x80); + dsi_dcs_write_seq(dsi, 0x43, 0x81); + dsi_dcs_write_seq(dsi, 0x44, 0x11); + dsi_dcs_write_seq(dsi, 0x45, 0xF2); + dsi_dcs_write_seq(dsi, 0x46, 0xF1); + dsi_dcs_write_seq(dsi, 0x47, 0x11); + dsi_dcs_write_seq(dsi, 0x48, 0xF4); + dsi_dcs_write_seq(dsi, 0x49, 0xF3); + dsi_dcs_write_seq(dsi, 0x50, 0x02); + dsi_dcs_write_seq(dsi, 0x51, 0x01); + dsi_dcs_write_seq(dsi, 0x52, 0x04); + dsi_dcs_write_seq(dsi, 0x53, 0x03); + dsi_dcs_write_seq(dsi, 0x54, 0x11); + dsi_dcs_write_seq(dsi, 0x55, 0xF6); + dsi_dcs_write_seq(dsi, 0x56, 0xF5); + dsi_dcs_write_seq(dsi, 0x57, 0x11); + dsi_dcs_write_seq(dsi, 0x58, 0xF8); + dsi_dcs_write_seq(dsi, 0x59, 0xF7); + dsi_dcs_write_seq(dsi, 0x7E, 0x02); + dsi_dcs_write_seq(dsi, 0x7F, 0x80); + dsi_dcs_write_seq(dsi, 0xE0, 0x5A); + dsi_dcs_write_seq(dsi, 0xB1, 0x00); + dsi_dcs_write_seq(dsi, 0xB4, 0x0E); + dsi_dcs_write_seq(dsi, 0xB5, 0x0F); + dsi_dcs_write_seq(dsi, 0xB6, 0x04); + dsi_dcs_write_seq(dsi, 0xB7, 0x07); + dsi_dcs_write_seq(dsi, 0xB8, 0x06); + dsi_dcs_write_seq(dsi, 0xB9, 0x05); + dsi_dcs_write_seq(dsi, 0xBA, 0x0F); + dsi_dcs_write_seq(dsi, 0xC7, 0x00); + dsi_dcs_write_seq(dsi, 0xCA, 0x0E); + dsi_dcs_write_seq(dsi, 0xCB, 0x0F); + dsi_dcs_write_seq(dsi, 0xCC, 0x04); + dsi_dcs_write_seq(dsi, 0xCD, 0x07); + dsi_dcs_write_seq(dsi, 0xCE, 0x06); + dsi_dcs_write_seq(dsi, 0xCF, 0x05); + dsi_dcs_write_seq(dsi, 0xD0, 0x0F); + dsi_dcs_write_seq(dsi, 0x81, 0x0F); + dsi_dcs_write_seq(dsi, 0x84, 0x0E); + dsi_dcs_write_seq(dsi, 0x85, 0x0F); + dsi_dcs_write_seq(dsi, 0x86, 0x07); + dsi_dcs_write_seq(dsi, 0x87, 0x04); + dsi_dcs_write_seq(dsi, 0x88, 0x05); + dsi_dcs_write_seq(dsi, 0x89, 0x06); + dsi_dcs_write_seq(dsi, 0x8A, 0x00); + dsi_dcs_write_seq(dsi, 0x97, 0x0F); + dsi_dcs_write_seq(dsi, 0x9A, 0x0E); + dsi_dcs_write_seq(dsi, 0x9B, 0x0F); + dsi_dcs_write_seq(dsi, 0x9C, 0x07); + dsi_dcs_write_seq(dsi, 0x9D, 0x04); + dsi_dcs_write_seq(dsi, 0x9E, 0x05); + dsi_dcs_write_seq(dsi, 0x9F, 0x06); + dsi_dcs_write_seq(dsi, 0xA0, 0x00); + dsi_dcs_write_seq(dsi, 0xFF, 0x30); + dsi_dcs_write_seq(dsi, 0xFF, 0x52); + dsi_dcs_write_seq(dsi, 0xFF, 0x02); + dsi_dcs_write_seq(dsi, 0x01, 0x01); + dsi_dcs_write_seq(dsi, 0x02, 0xDA); + dsi_dcs_write_seq(dsi, 0x03, 0xBA); + dsi_dcs_write_seq(dsi, 0x04, 0xA8); + dsi_dcs_write_seq(dsi, 0x05, 0x9A); + dsi_dcs_write_seq(dsi, 0x06, 0x70); + dsi_dcs_write_seq(dsi, 0x07, 0xFF); + dsi_dcs_write_seq(dsi, 0x08, 0x91); + dsi_dcs_write_seq(dsi, 0x09, 0x90); + dsi_dcs_write_seq(dsi, 0x0A, 0xFF); + dsi_dcs_write_seq(dsi, 0x0B, 0x8F); + dsi_dcs_write_seq(dsi, 0x0C, 0x60); + dsi_dcs_write_seq(dsi, 0x0D, 0x58); + dsi_dcs_write_seq(dsi, 0x0E, 0x48); + dsi_dcs_write_seq(dsi, 0x0F, 0x38); + dsi_dcs_write_seq(dsi, 0x10, 0x2B); + dsi_dcs_write_seq(dsi, 0xFF, 0x30); + dsi_dcs_write_seq(dsi, 0xFF, 0x52); + dsi_dcs_write_seq(dsi, 0xFF, 0x00); + dsi_dcs_write_seq(dsi, 0x36, 0x02); + dsi_dcs_write_seq(dsi, 0x3A, 0x70); + + dev_dbg(ctx->dev, "Panel init sequence done\n"); + + return 0; +} + +static int panel_nv3051d_unprepare(struct drm_panel *panel) +{ + struct panel_nv3051d *ctx = panel_to_panelnv3051d(panel); + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); + int ret; + + if (!ctx->prepared) + return 0; + + ret = mipi_dsi_dcs_set_display_off(dsi); + if (ret < 0) + dev_err(ctx->dev, "failed to set display off: %d\n", ret); + + msleep(20); + + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); + if (ret < 0) { + dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); + return ret; + } + + usleep_range(10000, 15000); + + regulator_disable(ctx->vdd); + + ctx->prepared = false; + + return 0; +} + +static int panel_nv3051d_prepare(struct drm_panel *panel) +{ + struct panel_nv3051d *ctx = panel_to_panelnv3051d(panel); + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); + int ret; + + if (ctx->prepared) + return 0; + + dev_dbg(ctx->dev, "Resetting the panel\n"); + ret = regulator_enable(ctx->vdd); + if (ret < 0) { + dev_err(ctx->dev, "Failed to enable vdd supply: %d\n", ret); + return ret; + } + + usleep_range(2000, 3000); + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + msleep(150); + gpiod_set_value_cansleep(ctx->reset_gpio, 0); + msleep(20); + + ret = panel_nv3051d_init_sequence(ctx); + if (ret < 0) { + dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret); + goto disable_vdd; + } + + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); + if (ret < 0) { + dev_err(ctx->dev, "Failed to exit sleep mode: %d\n", ret); + goto disable_vdd; + } + + msleep(200); + + ret = mipi_dsi_dcs_set_display_on(dsi); + if (ret < 0) { + dev_err(ctx->dev, "Failed to set display on: %d\n", ret); + goto disable_vdd; + } + + usleep_range(10000, 15000); + + ctx->prepared = true; + + return 0; + +disable_vdd: + regulator_disable(ctx->vdd); + return ret; +} + +static int panel_nv3051d_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct panel_nv3051d *ctx = panel_to_panelnv3051d(panel); + const struct nv3051d_panel_info *panel_info = ctx->panel_info; + struct drm_display_mode *mode; + unsigned int i; + + for (i = 0; i < panel_info->num_modes; i++) { + mode = drm_mode_duplicate(connector->dev, + &panel_info->display_modes[i]); + if (!mode) + return -ENOMEM; + + drm_mode_set_name(mode); + + mode->type = DRM_MODE_TYPE_DRIVER; + if (panel_info->num_modes == 1) + mode->type |= DRM_MODE_TYPE_PREFERRED; + + drm_mode_probed_add(connector, mode); + } + + connector->display_info.bpc = 8; + connector->display_info.width_mm = panel_info->width_mm; + connector->display_info.height_mm = panel_info->height_mm; + connector->display_info.bus_flags = panel_info->bus_flags; + + return panel_info->num_modes; +} + +static const struct drm_panel_funcs panel_nv3051d_funcs = { + .unprepare = panel_nv3051d_unprepare, + .prepare = panel_nv3051d_prepare, + .get_modes = panel_nv3051d_get_modes, +}; + +static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) +{ + struct device *dev = &dsi->dev; + struct panel_nv3051d *ctx; + int ret; + + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ctx->dev = dev; + + ctx->panel_info = of_device_get_match_data(dev); + if (!ctx->panel_info) + return -EINVAL; + + ctx->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->reset_gpio)) { + dev_err(dev, "cannot get reset gpio\n"); + return PTR_ERR(ctx->reset_gpio); + } + + ctx->vdd = devm_regulator_get(dev, "vdd"); + if (IS_ERR(ctx->vdd)) { + ret = PTR_ERR(ctx->vdd); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to request vdd regulator: %d\n", ret); + return ret; + } + + mipi_dsi_set_drvdata(dsi, ctx); + + dsi->lanes = 4; + dsi->format = MIPI_DSI_FMT_RGB888; + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; + + drm_panel_init(&ctx->panel, &dsi->dev, &panel_nv3051d_funcs, + DRM_MODE_CONNECTOR_DSI); + + ret = drm_panel_of_backlight(&ctx->panel); + if (ret) + return ret; + + drm_panel_add(&ctx->panel); + + ret = mipi_dsi_attach(dsi); + if (ret < 0) { + dev_err(dev, "mipi_dsi_attach failed: %d\n", ret); + drm_panel_remove(&ctx->panel); + return ret; + } + + return 0; +} + +static void panel_nv3051d_shutdown(struct mipi_dsi_device *dsi) +{ + struct panel_nv3051d *ctx = mipi_dsi_get_drvdata(dsi); + int ret; + + ret = drm_panel_unprepare(&ctx->panel); + if (ret < 0) + dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret); + + ret = drm_panel_disable(&ctx->panel); + if (ret < 0) + dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret); +} + +static int panel_nv3051d_remove(struct mipi_dsi_device *dsi) +{ + struct panel_nv3051d *ctx = mipi_dsi_get_drvdata(dsi); + int ret; + + panel_nv3051d_shutdown(dsi); + + ret = mipi_dsi_detach(dsi); + if (ret < 0) + dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); + + drm_panel_remove(&ctx->panel); + + return 0; +} + +static const struct drm_display_mode nv3051d_rgxx3_modes[] = { + { /* 120hz */ + .hdisplay = 640, + .hsync_start = 640 + 40, + .hsync_end = 640 + 40 + 2, + .htotal = 640 + 40 + 2 + 80, + .vdisplay = 480, + .vsync_start = 480 + 18, + .vsync_end = 480 + 18 + 2, + .vtotal = 480 + 18 + 2 + 28, + .clock = 48300, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, + { /* 60hz */ + .hdisplay = 640, + .hsync_start = 640 + 40, + .hsync_end = 640 + 40 + 2, + .htotal = 640 + 40 + 2 + 80, + .vdisplay = 480, + .vsync_start = 480 + 18, + .vsync_end = 480 + 18 + 2, + .vtotal = 480 + 18 + 2 + 28, + .clock = 24150, + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, + }, +}; + +static const struct nv3051d_panel_info nv3051d_rgxx3_info = { + .display_modes = nv3051d_rgxx3_modes, + .num_modes = ARRAY_SIZE(nv3051d_rgxx3_modes), + .width_mm = 70, + .height_mm = 57, + .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, +}; + +static const struct of_device_id newvision_nv3051d_of_match[] = { + { .compatible = "newvision,nv3051d", .data = &nv3051d_rgxx3_info }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, newvision_nv3051d_of_match); + +static struct mipi_dsi_driver newvision_nv3051d_driver = { + .driver = { + .name = "panel-newvision-nv3051d", + .of_match_table = newvision_nv3051d_of_match, + }, + .probe = panel_nv3051d_probe, + .remove = panel_nv3051d_remove, + .shutdown = panel_nv3051d_shutdown, +}; +module_mipi_dsi_driver(newvision_nv3051d_driver); + +MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>"); +MODULE_DESCRIPTION("DRM driver for Newvision NV3051D based MIPI DSI panels"); +MODULE_LICENSE("GPL"); -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-09-24 17:51 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-20 14:59 [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels Chris Morgan 2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan 2022-09-21 6:50 ` Krzysztof Kozlowski 2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan 2022-09-21 6:51 ` Krzysztof Kozlowski 2022-09-21 14:38 ` Chris Morgan 2022-09-21 15:21 ` Krzysztof Kozlowski 2022-09-21 15:50 ` Chris Morgan 2022-09-21 15:57 ` Krzysztof Kozlowski 2022-09-21 16:17 ` Chris Morgan 2022-09-21 7:01 ` Krzysztof Kozlowski 2022-09-24 17:07 ` Rob Herring 2022-09-24 17:51 ` Chris Morgan 2022-09-20 14:59 ` [PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel Chris Morgan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).