[PATCH] drm/fb-helper: Fix missing kerneldoc include

[PATCH] drm/fb-helper: Fix missing kerneldoc include

[Daniel Vetter]

This was lost in the code movement done in 8ab59da26bc0
("drm/fb-helper: Move generic fbdev emulation into separate source
file").

Fixes: 8ab59da26bc0 ("drm/fb-helper: Move generic fbdev emulation into separate source file")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/drm-kms-helpers.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
index dbc85fd7a971..a4860ffd6e86 100644
--- a/Documentation/gpu/drm-kms-helpers.rst
+++ b/Documentation/gpu/drm-kms-helpers.rst
@@ -116,6 +116,9 @@ fbdev Helper Functions Reference
 .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c
    :export:
 
+.. kernel-doc:: drivers/gpu/drm/drm_fbdev_generic.c
+   :export:
+
 format Helper Functions Reference
 =================================
 
-- 
2.37.2

Re: [PATCH] drm/fb-helper: Fix missing kerneldoc include

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1318 bytes --]



Am 07.11.22 um 20:09 schrieb Daniel Vetter:
> This was lost in the code movement done in 8ab59da26bc0
> ("drm/fb-helper: Move generic fbdev emulation into separate source
> file").
> 
> Fixes: 8ab59da26bc0 ("drm/fb-helper: Move generic fbdev emulation into separate source file")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   Documentation/gpu/drm-kms-helpers.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
> index dbc85fd7a971..a4860ffd6e86 100644
> --- a/Documentation/gpu/drm-kms-helpers.rst
> +++ b/Documentation/gpu/drm-kms-helpers.rst
> @@ -116,6 +116,9 @@ fbdev Helper Functions Reference
>   .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c
>      :export:
>   
> +.. kernel-doc:: drivers/gpu/drm/drm_fbdev_generic.c
> +   :export:
> +
>   format Helper Functions Reference
>   =================================
>   

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH] drm/fb-helper: Fix missing kerneldoc include

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1902 bytes --]

Thanks. Merged with fixes for the following warnings.

66ba1150c07e (HEAD -> drm-misc-next) drm/fb-helper: Fix missing 
kerneldoc include
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 
'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8ab59da26bc0 
("drm/fb-helper: Move generic fbdev emulation into separate source file")'
#6:
This was lost in the code movement done in 8ab59da26bc0

-:30: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address 
mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 
'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'

Best regards
Thomas

Am 07.11.22 um 20:09 schrieb Daniel Vetter:
> This was lost in the code movement done in 8ab59da26bc0
> ("drm/fb-helper: Move generic fbdev emulation into separate source
> file").
> 
> Fixes: 8ab59da26bc0 ("drm/fb-helper: Move generic fbdev emulation into separate source file")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>   Documentation/gpu/drm-kms-helpers.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst
> index dbc85fd7a971..a4860ffd6e86 100644
> --- a/Documentation/gpu/drm-kms-helpers.rst
> +++ b/Documentation/gpu/drm-kms-helpers.rst
> @@ -116,6 +116,9 @@ fbdev Helper Functions Reference
>   .. kernel-doc:: drivers/gpu/drm/drm_fb_helper.c
>      :export:
>   
> +.. kernel-doc:: drivers/gpu/drm/drm_fbdev_generic.c
> +   :export:
> +
>   format Helper Functions Reference
>   =================================
>   

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]