* [PATCH] drm/vgem: Drop struct drm_vgem_gem_object
@ 2023-02-22 16:06 Maíra Canal
2023-03-15 22:31 ` Melissa Wen
2023-03-20 19:07 ` Maíra Canal
0 siblings, 2 replies; 3+ messages in thread
From: Maíra Canal @ 2023-02-22 16:06 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Thomas Zimmermann,
Javier Martinez Canillas, Melissa Wen
Cc: Maíra Canal, dri-devel
Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
helpers to vgem and with that, removed all uses of the struct
drm_vgem_gem_object. So, as the struct is no longer used, delete it.
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
index 0ed300317f87..34cf63e6fb3d 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.h
+++ b/drivers/gpu/drm/vgem/vgem_drv.h
@@ -39,17 +39,6 @@ struct vgem_file {
struct mutex fence_mutex;
};
-#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
-struct drm_vgem_gem_object {
- struct drm_gem_object base;
-
- struct page **pages;
- unsigned int pages_pin_count;
- struct mutex pages_lock;
-
- struct sg_table *table;
-};
-
int vgem_fence_open(struct vgem_file *file);
int vgem_fence_attach_ioctl(struct drm_device *dev,
void *data,
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vgem: Drop struct drm_vgem_gem_object
2023-02-22 16:06 [PATCH] drm/vgem: Drop struct drm_vgem_gem_object Maíra Canal
@ 2023-03-15 22:31 ` Melissa Wen
2023-03-20 19:07 ` Maíra Canal
1 sibling, 0 replies; 3+ messages in thread
From: Melissa Wen @ 2023-03-15 22:31 UTC (permalink / raw)
To: Maíra Canal; +Cc: dri-devel, Thomas Zimmermann, Javier Martinez Canillas
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On 02/22, Maíra Canal wrote:
> Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
> helpers to vgem and with that, removed all uses of the struct
> drm_vgem_gem_object. So, as the struct is no longer used, delete it.
>
Thanks,
Reviewed-by: Melissa Wen <mwen@igalia.com>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
> drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
> index 0ed300317f87..34cf63e6fb3d 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.h
> +++ b/drivers/gpu/drm/vgem/vgem_drv.h
> @@ -39,17 +39,6 @@ struct vgem_file {
> struct mutex fence_mutex;
> };
>
> -#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
> -struct drm_vgem_gem_object {
> - struct drm_gem_object base;
> -
> - struct page **pages;
> - unsigned int pages_pin_count;
> - struct mutex pages_lock;
> -
> - struct sg_table *table;
> -};
> -
> int vgem_fence_open(struct vgem_file *file);
> int vgem_fence_attach_ioctl(struct drm_device *dev,
> void *data,
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vgem: Drop struct drm_vgem_gem_object
2023-02-22 16:06 [PATCH] drm/vgem: Drop struct drm_vgem_gem_object Maíra Canal
2023-03-15 22:31 ` Melissa Wen
@ 2023-03-20 19:07 ` Maíra Canal
1 sibling, 0 replies; 3+ messages in thread
From: Maíra Canal @ 2023-03-20 19:07 UTC (permalink / raw)
To: Maíra Canal, David Airlie, Daniel Vetter, Thomas Zimmermann,
Javier Martinez Canillas, Melissa Wen
Cc: dri-devel
On 2/22/23 13:06, Maíra Canal wrote:
> Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
> helpers to vgem and with that, removed all uses of the struct
> drm_vgem_gem_object. So, as the struct is no longer used, delete it.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
Applied to drm-misc-next.
Best Regards,
- Maíra Canal
> drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
> index 0ed300317f87..34cf63e6fb3d 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.h
> +++ b/drivers/gpu/drm/vgem/vgem_drv.h
> @@ -39,17 +39,6 @@ struct vgem_file {
> struct mutex fence_mutex;
> };
>
> -#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
> -struct drm_vgem_gem_object {
> - struct drm_gem_object base;
> -
> - struct page **pages;
> - unsigned int pages_pin_count;
> - struct mutex pages_lock;
> -
> - struct sg_table *table;
> -};
> -
> int vgem_fence_open(struct vgem_file *file);
> int vgem_fence_attach_ioctl(struct drm_device *dev,
> void *data,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-20 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22 16:06 [PATCH] drm/vgem: Drop struct drm_vgem_gem_object Maíra Canal
2023-03-15 22:31 ` Melissa Wen
2023-03-20 19:07 ` Maíra Canal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).