* [PATCH] drm/qxl: pass a device into ttm init.
@ 2024-01-23 2:20 Dave Airlie
2024-01-23 3:25 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Dave Airlie @ 2024-01-23 2:20 UTC (permalink / raw)
To: dri-devel; +Cc: Dave Airlie, Rajneesh Bhardwaj, Steven Rostedt
From: Dave Airlie <airlied@redhat.com>
ttm init was changed to look at numa node, but that needed a device.
Only qxl appears to not hand in a device, so just fix that.
Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer")
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/qxl/qxl_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 1a82629bce3f..1876419ea237 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev)
int num_io_pages; /* != rom->num_io_pages, we include surface0 */
/* No others user of address space so set it to 0 */
- r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL,
+ r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev,
qdev->ddev.anon_inode->i_mapping,
qdev->ddev.vma_offset_manager,
false, false);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/qxl: pass a device into ttm init.
2024-01-23 2:20 [PATCH] drm/qxl: pass a device into ttm init Dave Airlie
@ 2024-01-23 3:25 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2024-01-23 3:25 UTC (permalink / raw)
To: Dave Airlie; +Cc: Dave Airlie, Rajneesh Bhardwaj, dri-devel
On Tue, 23 Jan 2024 12:20:15 +1000
Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> ttm init was changed to look at numa node, but that needed a device.
>
> Only qxl appears to not hand in a device, so just fix that.
>
> Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer")
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
My tests seem to get past the crash with this patch and not my "fix".
Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/qxl/qxl_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
> index 1a82629bce3f..1876419ea237 100644
> --- a/drivers/gpu/drm/qxl/qxl_ttm.c
> +++ b/drivers/gpu/drm/qxl/qxl_ttm.c
> @@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev)
> int num_io_pages; /* != rom->num_io_pages, we include surface0 */
>
> /* No others user of address space so set it to 0 */
> - r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL,
> + r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev,
> qdev->ddev.anon_inode->i_mapping,
> qdev->ddev.vma_offset_manager,
> false, false);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drm/qxl: pass a device into ttm init.
@ 2024-01-23 2:19 Dave Airlie
0 siblings, 0 replies; 3+ messages in thread
From: Dave Airlie @ 2024-01-23 2:19 UTC (permalink / raw)
To: dri-devel
From: Dave Airlie <airlied@redhat.com>
ttm init was changed to look at numa node, but that needed a device.
Only qxl appears to not hand in a device, so just fix that.
Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer")
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/qxl/qxl_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 1a82629bce3f..1876419ea237 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev)
int num_io_pages; /* != rom->num_io_pages, we include surface0 */
/* No others user of address space so set it to 0 */
- r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL,
+ r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev,
qdev->ddev.anon_inode->i_mapping,
qdev->ddev.vma_offset_manager,
false, false);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-23 3:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-23 2:20 [PATCH] drm/qxl: pass a device into ttm init Dave Airlie
2024-01-23 3:25 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2024-01-23 2:19 Dave Airlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).