Re: [PATCH 00/14] drm/radeon: remove comparison to bool

* Re: [PATCH 00/14] drm/radeon: remove comparison to bool
@ 2020-05-06 16:36 Koenig, Christian
  0 siblings, 0 replies; 3+ messages in thread
From: Koenig, Christian @ 2020-05-06 16:36 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Dave Airlie, amd-gfx list, Zheng Bin,
	Maling list - DRI developers, Deucher, Alexander

[-- Attachment #1.1: Type: text/plain, Size: 2601 bytes --]

Am 06.05.2020 18:00 schrieb Alex Deucher <alexdeucher@gmail.com>:
On Wed, May 6, 2020 at 10:27 AM Zheng Bin <zhengbin13@huawei.com> wrote:
>
> Zheng Bin (14):
>   drm/radeon: remove comparison to bool in btc_dpm.c
>   drm/radeon: remove comparison to bool in ci_dpm.c
>   drm/radeon: remove comparison to bool in ni_dpm.c
>   drm/radeon: remove comparison to bool in radeon_atpx_handler.c
>   drm/radeon: remove comparison to bool in radeon_object.c
>   drm/radeon: remove comparison to bool in radeon_ttm.c
>   drm/radeon: remove comparison to bool in r100.c
>   drm/radeon: remove comparison to bool in r300.c
>   drm/radeon: remove comparison to bool in r600.c
>   drm/radeon: remove comparison to bool in rs600.c
>   drm/radeon: remove comparison to bool in rs690.c
>   drm/radeon: remove comparison to bool in rv6xx_dpm.c
>   drm/radeon: remove comparison to bool in rv515.c
>   drm/radeon: remove comparison to bool in si_dpm.c

Does the checker need to be fixed?  All of these are comparing boolean
variables to true/false.  Seems like needless code churn to me.

We should probably make sure that no new code like this leaks in, but I also don't see that this is necessary for the old driver stack.

Christian.

Alex

>
>  drivers/gpu/drm/radeon/btc_dpm.c             | 2 +-
>  drivers/gpu/drm/radeon/ci_dpm.c              | 4 ++--
>  drivers/gpu/drm/radeon/ni_dpm.c              | 6 +++---
>  drivers/gpu/drm/radeon/r100.c                | 2 +-
>  drivers/gpu/drm/radeon/r300.c                | 2 +-
>  drivers/gpu/drm/radeon/r600.c                | 3 ++-
>  drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 ++--
>  drivers/gpu/drm/radeon/radeon_object.c       | 2 +-
>  drivers/gpu/drm/radeon/radeon_ttm.c          | 2 +-
>  drivers/gpu/drm/radeon/rs600.c               | 2 +-
>  drivers/gpu/drm/radeon/rs690.c               | 3 ++-
>  drivers/gpu/drm/radeon/rv515.c               | 2 +-
>  drivers/gpu/drm/radeon/rv6xx_dpm.c           | 2 +-
>  drivers/gpu/drm/radeon/si_dpm.c              | 6 +++---
>  14 files changed, 22 insertions(+), 20 deletions(-)
>
> --
> 2.26.0.106.g9fadedd
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cchristian.koenig%40amd.com%7C10c2a90728574bb20ef208d7f1d69e2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243776401264275&amp;sdata=Z6alCS8hPA7rWNKHimpkc6zBldtBagK0dGpX8mTOEZA%3D&amp;reserved=0

[-- Attachment #1.2: Type: text/html, Size: 5311 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread