* [RESEND 01/26] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 02/26] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header Lee Jones
` (25 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Chun-Kuang Hu, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Matthias Brugger, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_color.c:45: warning: Function parameter or member 'clk' not described in 'mtk_disp_color'
drivers/gpu/drm/mediatek/mtk_disp_color.c:45: warning: Function parameter or member 'regs' not described in 'mtk_disp_color'
drivers/gpu/drm/mediatek/mtk_disp_color.c:45: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_color'
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/mediatek/mtk_disp_color.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c
index 63f411ab393b7..6f4c80bbc0eb6 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_color.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_color.c
@@ -30,9 +30,8 @@ struct mtk_disp_color_data {
unsigned int color_offset;
};
-/**
+/*
* struct mtk_disp_color - DISP_COLOR driver structure
- * @ddp_comp: structure containing type enum and hardware resources
* @crtc: associated crtc to report irq events to
* @data: platform colour driver data
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 02/26] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
2021-06-02 14:32 ` [RESEND 01/26] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 03/26] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header Lee Jones
` (24 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Chun-Kuang Hu, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Matthias Brugger, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_gamma.c:42: warning: Function parameter or member 'clk' not described in 'mtk_disp_gamma'
drivers/gpu/drm/mediatek/mtk_disp_gamma.c:42: warning: Function parameter or member 'regs' not described in 'mtk_disp_gamma'
drivers/gpu/drm/mediatek/mtk_disp_gamma.c:42: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_gamma'
drivers/gpu/drm/mediatek/mtk_disp_gamma.c:42: warning: Function parameter or member 'data' not described in 'mtk_disp_gamma'
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
index 3ebf91e0ab412..3a5815ab40795 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
@@ -29,10 +29,8 @@ struct mtk_disp_gamma_data {
bool has_dither;
};
-/**
+/*
* struct mtk_disp_gamma - DISP_GAMMA driver structure
- * @ddp_comp - structure containing type enum and hardware resources
- * @crtc - associated crtc to report irq events to
*/
struct mtk_disp_gamma {
struct clk *clk;
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 03/26] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
2021-06-02 14:32 ` [RESEND 01/26] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header Lee Jones
2021-06-02 14:32 ` [RESEND 02/26] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 04/26] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header Lee Jones
` (23 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Chun-Kuang Hu, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Matthias Brugger, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ovl.c:83: warning: Function parameter or member 'clk' not described in 'mtk_disp_ovl'
drivers/gpu/drm/mediatek/mtk_disp_ovl.c:83: warning: Function parameter or member 'regs' not described in 'mtk_disp_ovl'
drivers/gpu/drm/mediatek/mtk_disp_ovl.c:83: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ovl'
drivers/gpu/drm/mediatek/mtk_disp_ovl.c:83: warning: Function parameter or member 'vblank_cb' not described in 'mtk_disp_ovl'
drivers/gpu/drm/mediatek/mtk_disp_ovl.c:83: warning: Function parameter or member 'vblank_cb_data' not described in 'mtk_disp_ovl'
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 961f87f8d4d15..fa9d79963cd34 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -66,9 +66,8 @@ struct mtk_disp_ovl_data {
bool smi_id_en;
};
-/**
+/*
* struct mtk_disp_ovl - DISP_OVL driver structure
- * @ddp_comp: structure containing type enum and hardware resources
* @crtc: associated crtc to report vblank events to
* @data: platform data
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 04/26] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (2 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 03/26] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 05/26] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers Lee Jones
` (22 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Chun-Kuang Hu, David Airlie, linux-kernel, dri-devel,
linux-mediatek, Matthias Brugger, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'clk' not described in 'mtk_disp_rdma'
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'regs' not described in 'mtk_disp_rdma'
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_rdma'
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'vblank_cb' not described in 'mtk_disp_rdma'
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'vblank_cb_data' not described in 'mtk_disp_rdma'
drivers/gpu/drm/mediatek/mtk_disp_rdma.c:72: warning: Function parameter or member 'fifo_size' not described in 'mtk_disp_rdma'
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
index 728aaadfea8cf..705f28ceb4ddd 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
@@ -55,10 +55,8 @@ struct mtk_disp_rdma_data {
unsigned int fifo_size;
};
-/**
+/*
* struct mtk_disp_rdma - DISP_RDMA driver structure
- * @ddp_comp: structure containing type enum and hardware resources
- * @crtc: associated crtc to report irq events to
* @data: local driver data
*/
struct mtk_disp_rdma {
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 05/26] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (3 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 04/26] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Lee Jones
` (21 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Benjamin Gaignard, David Airlie, linux-kernel, dri-devel, Vincent Abriou
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c:77: warning: expecting prototype for Start hdmi phy macro cell tx3g4c28(). Prototype was for sti_hdmi_tx3g4c28phy_start() instead
drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c:187: warning: expecting prototype for Stop hdmi phy macro cell tx3g4c28(). Prototype was for sti_hdmi_tx3g4c28phy_stop() instead
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c
index d5f94dca0d323..d25ecd4f4b673 100644
--- a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c
+++ b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c
@@ -67,7 +67,7 @@ static struct hdmi_phy_config hdmiphy_config[NB_HDMI_PHY_CONFIG] = {
};
/**
- * Start hdmi phy macro cell tx3g4c28
+ * sti_hdmi_tx3g4c28phy_start - Start hdmi phy macro cell tx3g4c28
*
* @hdmi: pointer on the hdmi internal structure
*
@@ -179,7 +179,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi *hdmi)
}
/**
- * Stop hdmi phy macro cell tx3g4c28
+ * sti_hdmi_tx3g4c28phy_stop - Stop hdmi phy macro cell tx3g4c28
*
* @hdmi: pointer on the hdmi internal structure
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 06/26] drm/sti/sti_hda: Provide missing function names
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (4 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 05/26] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 07/26] drm/sti/sti_tvout: Provide a bunch of " Lee Jones
` (20 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Benjamin Gaignard, David Airlie, linux-kernel, dri-devel,
Fabien Dessenne
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/sti/sti_hda.c:283: warning: expecting prototype for Search for a video mode in the supported modes table(). Prototype was for hda_get_mode_idx() instead
drivers/gpu/drm/sti/sti_hda.c:301: warning: expecting prototype for Enable the HD DACS(). Prototype was for hda_enable_hd_dacs() instead
drivers/gpu/drm/sti/sti_hda.c:383: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Fabien Dessenne <fabien.dessenne@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/sti/sti_hda.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 5c2b650b561d5..03f3377f918c0 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -272,7 +272,7 @@ static void hda_write(struct sti_hda *hda, u32 val, int offset)
}
/**
- * Search for a video mode in the supported modes table
+ * hda_get_mode_idx - Search for a video mode in the supported modes table
*
* @mode: mode being searched
* @idx: index of the found mode
@@ -292,7 +292,7 @@ static bool hda_get_mode_idx(struct drm_display_mode mode, int *idx)
}
/**
- * Enable the HD DACS
+ * hda_enable_hd_dacs - Enable the HD DACS
*
* @hda: pointer to HD analog structure
* @enable: true if HD DACS need to be enabled, else false
@@ -380,7 +380,7 @@ static void hda_debugfs_init(struct sti_hda *hda, struct drm_minor *minor)
}
/**
- * Configure AWG, writing instructions
+ * sti_hda_configure_awg - Configure AWG, writing instructions
*
* @hda: pointer to HD analog structure
* @awg_instr: pointer to AWG instructions table
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 07/26] drm/sti/sti_tvout: Provide a bunch of missing function names
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (5 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 06/26] drm/sti/sti_hda: Provide missing function names Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 08/26] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' Lee Jones
` (19 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Benjamin Gaignard, David Airlie, linux-kernel, dri-devel, Vincent Abriou
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/sti/sti_tvout.c:166: warning: expecting prototype for Set the clipping mode of a VIP(). Prototype was for tvout_vip_set_color_order() instead
drivers/gpu/drm/sti/sti_tvout.c:187: warning: expecting prototype for Set the clipping mode of a VIP(). Prototype was for tvout_vip_set_clip_mode() instead
drivers/gpu/drm/sti/sti_tvout.c:203: warning: expecting prototype for Set the rounded value of a VIP(). Prototype was for tvout_vip_set_rnd() instead
drivers/gpu/drm/sti/sti_tvout.c:223: warning: expecting prototype for Select the VIP input(). Prototype was for tvout_vip_set_sel_input() instead
drivers/gpu/drm/sti/sti_tvout.c:258: warning: expecting prototype for Select the input video signed or unsigned(). Prototype was for tvout_vip_set_in_vid_fmt() instead
drivers/gpu/drm/sti/sti_tvout.c:274: warning: expecting prototype for Set preformatter matrix(). Prototype was for tvout_preformatter_set_matrix() instead
drivers/gpu/drm/sti/sti_tvout.c:299: warning: expecting prototype for Start VIP block for DVO output(). Prototype was for tvout_dvo_start() instead
drivers/gpu/drm/sti/sti_tvout.c:353: warning: expecting prototype for Start VIP block for HDMI output(). Prototype was for tvout_hdmi_start() instead
drivers/gpu/drm/sti/sti_tvout.c:402: warning: expecting prototype for Start HDF VIP and HD DAC(). Prototype was for tvout_hda_start() instead
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/sti/sti_tvout.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index df3817f0fd302..2499715a69b79 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -153,7 +153,7 @@ static void tvout_write(struct sti_tvout *tvout, u32 val, int offset)
}
/**
- * Set the clipping mode of a VIP
+ * tvout_vip_set_color_order - Set the clipping mode of a VIP
*
* @tvout: tvout structure
* @reg: register to set
@@ -177,7 +177,7 @@ static void tvout_vip_set_color_order(struct sti_tvout *tvout, int reg,
}
/**
- * Set the clipping mode of a VIP
+ * tvout_vip_set_clip_mode - Set the clipping mode of a VIP
*
* @tvout: tvout structure
* @reg: register to set
@@ -193,7 +193,7 @@ static void tvout_vip_set_clip_mode(struct sti_tvout *tvout, int reg, u32 range)
}
/**
- * Set the rounded value of a VIP
+ * tvout_vip_set_rnd - Set the rounded value of a VIP
*
* @tvout: tvout structure
* @reg: register to set
@@ -209,7 +209,7 @@ static void tvout_vip_set_rnd(struct sti_tvout *tvout, int reg, u32 rnd)
}
/**
- * Select the VIP input
+ * tvout_vip_set_sel_input - Select the VIP input
*
* @tvout: tvout structure
* @reg: register to set
@@ -247,7 +247,7 @@ static void tvout_vip_set_sel_input(struct sti_tvout *tvout,
}
/**
- * Select the input video signed or unsigned
+ * tvout_vip_set_in_vid_fmt - Select the input video signed or unsigned
*
* @tvout: tvout structure
* @reg: register to set
@@ -264,7 +264,7 @@ static void tvout_vip_set_in_vid_fmt(struct sti_tvout *tvout,
}
/**
- * Set preformatter matrix
+ * tvout_preformatter_set_matrix - Set preformatter matrix
*
* @tvout: tvout structure
* @mode: display mode structure
@@ -289,7 +289,7 @@ static void tvout_preformatter_set_matrix(struct sti_tvout *tvout,
}
/**
- * Start VIP block for DVO output
+ * tvout_dvo_start - Start VIP block for DVO output
*
* @tvout: pointer on tvout structure
* @main_path: true if main path has to be used in the vip configuration
@@ -343,7 +343,7 @@ static void tvout_dvo_start(struct sti_tvout *tvout, bool main_path)
}
/**
- * Start VIP block for HDMI output
+ * tvout_hdmi_start - Start VIP block for HDMI output
*
* @tvout: pointer on tvout structure
* @main_path: true if main path has to be used in the vip configuration
@@ -392,7 +392,7 @@ static void tvout_hdmi_start(struct sti_tvout *tvout, bool main_path)
}
/**
- * Start HDF VIP and HD DAC
+ * tvout_hda_start - Start HDF VIP and HD DAC
*
* @tvout: pointer on tvout structure
* @main_path: true if main path has to be used in the vip configuration
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 08/26] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (6 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 07/26] drm/sti/sti_tvout: Provide a bunch of " Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones
` (18 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Benjamin Gaignard, David Airlie, linux-kernel, Fabien Dessenne,
dri-devel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/sti/sti_hqvdp.c:796: warning: expecting prototype for sti_vdp_vtg_cb(). Prototype was for sti_hqvdp_vtg_cb() instead
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fabien Dessenne <fabien.dessenne@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index edbb99f53de19..d09b08995b12a 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -782,7 +782,7 @@ static void sti_hqvdp_disable(struct sti_hqvdp *hqvdp)
}
/**
- * sti_vdp_vtg_cb
+ * sti_hqvdp_vtg_cb
* @nb: notifier block
* @evt: event message
* @data: private data
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (7 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 08/26] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 17:26 ` [Freedreno] " abhinavk
2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
` (17 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
AngeloGioacchino Del Regno, Sean Paul
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e4..088900841bf8b 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
static int dpu_encoder_phys_cmd_wait_for_commit_done(
struct dpu_encoder_phys *phys_enc)
{
- struct dpu_encoder_phys_cmd *cmd_enc;
-
- cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
/* only required for master controller */
if (!dpu_encoder_phys_cmd_is_master(phys_enc))
return 0;
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [Freedreno] [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc'
2021-06-02 14:32 ` [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones
@ 2021-06-02 17:26 ` abhinavk
0 siblings, 0 replies; 45+ messages in thread
From: abhinavk @ 2021-06-02 17:26 UTC (permalink / raw)
To: Lee Jones
Cc: Sean Paul, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
AngeloGioacchino Del Regno, freedreno
On 2021-06-02 07:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
> ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
> variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@somainline.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e4..088900841bf8b 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int
> dpu_encoder_phys_cmd_wait_for_tx_complete(
> static int dpu_encoder_phys_cmd_wait_for_commit_done(
> struct dpu_encoder_phys *phys_enc)
> {
> - struct dpu_encoder_phys_cmd *cmd_enc;
> -
> - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
> /* only required for master controller */
> if (!dpu_encoder_phys_cmd_is_master(phys_enc))
> return 0;
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (8 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 09/26] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 17:33 ` [Freedreno] " abhinavk
2021-06-04 8:32 ` Dmitry Baryshkov
2021-06-02 14:32 ` [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones
` (16 subsequent siblings)
26 siblings, 2 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Krishna Manikandan, David Airlie, linux-arm-msm, linux-kernel,
dri-devel, freedreno, Sean Paul
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting prototype for Register offsets in MDSS register file for the interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:35: warning: expecting prototype for WB interrupt status bit definitions(). Prototype was for DPU_INTR_WB_0_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:42: warning: expecting prototype for WDOG timer interrupt status bit definitions(). Prototype was for DPU_INTR_WD_TIMER_0_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:51: warning: expecting prototype for Pingpong interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:71: warning: expecting prototype for Interface interrupt status bit definitions(). Prototype was for DPU_INTR_INTF_0_UNDERRUN() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:85: warning: expecting prototype for Pingpong Secondary interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:94: warning: expecting prototype for Pingpong TEAR detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TEAR_DETECTED() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:102: warning: expecting prototype for Pingpong TE detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TE_DETECTED() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:110: warning: expecting prototype for Ctl start interrupt status bit definitions(). Prototype was for DPU_INTR_CTL_0_START() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:119: warning: expecting prototype for Concurrent WB overflow interrupt status bit definitions(). Prototype was for DPU_INTR_CWB_2_OVERFLOW() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:125: warning: expecting prototype for Histogram VIG done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:133: warning: expecting prototype for Histogram VIG reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_RSTSEQ_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:141: warning: expecting prototype for Histogram DSPP done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:149: warning: expecting prototype for Histogram DSPP reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:157: warning: expecting prototype for INTF interrupt status bit definitions(). Prototype was for DPU_INTR_VIDEO_INTO_STATIC() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:170: warning: expecting prototype for AD4 interrupt status bit definitions(). Prototype was for DPU_INTR_BACKLIGHT_UPDATED() instead
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Krishna Manikandan <mkrishn@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index 48c96b8121268..aaf251741dc27 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -10,7 +10,7 @@
#include "dpu_hw_util.h"
#include "dpu_hw_mdss.h"
-/**
+/*
* Register offsets in MDSS register file for the interrupt registers
* w.r.t. to the MDP base
*/
@@ -29,14 +29,14 @@
#define MDP_INTF_1_OFF_REV_7xxx 0x35000
#define MDP_INTF_5_OFF_REV_7xxx 0x39000
-/**
+/*
* WB interrupt status bit definitions
*/
#define DPU_INTR_WB_0_DONE BIT(0)
#define DPU_INTR_WB_1_DONE BIT(1)
#define DPU_INTR_WB_2_DONE BIT(4)
-/**
+/*
* WDOG timer interrupt status bit definitions
*/
#define DPU_INTR_WD_TIMER_0_DONE BIT(2)
@@ -45,7 +45,7 @@
#define DPU_INTR_WD_TIMER_3_DONE BIT(6)
#define DPU_INTR_WD_TIMER_4_DONE BIT(7)
-/**
+/*
* Pingpong interrupt status bit definitions
*/
#define DPU_INTR_PING_PONG_0_DONE BIT(8)
@@ -65,7 +65,7 @@
#define DPU_INTR_PING_PONG_2_AUTOREFRESH_DONE BIT(22)
#define DPU_INTR_PING_PONG_3_AUTOREFRESH_DONE BIT(23)
-/**
+/*
* Interface interrupt status bit definitions
*/
#define DPU_INTR_INTF_0_UNDERRUN BIT(24)
@@ -79,7 +79,7 @@
#define DPU_INTR_INTF_3_VSYNC BIT(31)
#define DPU_INTR_INTF_5_VSYNC BIT(23)
-/**
+/*
* Pingpong Secondary interrupt status bit definitions
*/
#define DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE BIT(0)
@@ -88,7 +88,7 @@
#define DPU_INTR_PING_PONG_S0_TEAR_DETECTED BIT(22)
#define DPU_INTR_PING_PONG_S0_TE_DETECTED BIT(28)
-/**
+/*
* Pingpong TEAR detection interrupt status bit definitions
*/
#define DPU_INTR_PING_PONG_0_TEAR_DETECTED BIT(16)
@@ -96,7 +96,7 @@
#define DPU_INTR_PING_PONG_2_TEAR_DETECTED BIT(18)
#define DPU_INTR_PING_PONG_3_TEAR_DETECTED BIT(19)
-/**
+/*
* Pingpong TE detection interrupt status bit definitions
*/
#define DPU_INTR_PING_PONG_0_TE_DETECTED BIT(24)
@@ -104,7 +104,7 @@
#define DPU_INTR_PING_PONG_2_TE_DETECTED BIT(26)
#define DPU_INTR_PING_PONG_3_TE_DETECTED BIT(27)
-/**
+/*
* Ctl start interrupt status bit definitions
*/
#define DPU_INTR_CTL_0_START BIT(9)
@@ -113,13 +113,13 @@
#define DPU_INTR_CTL_3_START BIT(12)
#define DPU_INTR_CTL_4_START BIT(13)
-/**
+/*
* Concurrent WB overflow interrupt status bit definitions
*/
#define DPU_INTR_CWB_2_OVERFLOW BIT(14)
#define DPU_INTR_CWB_3_OVERFLOW BIT(15)
-/**
+/*
* Histogram VIG done interrupt status bit definitions
*/
#define DPU_INTR_HIST_VIG_0_DONE BIT(0)
@@ -127,7 +127,7 @@
#define DPU_INTR_HIST_VIG_2_DONE BIT(8)
#define DPU_INTR_HIST_VIG_3_DONE BIT(10)
-/**
+/*
* Histogram VIG reset Sequence done interrupt status bit definitions
*/
#define DPU_INTR_HIST_VIG_0_RSTSEQ_DONE BIT(1)
@@ -135,7 +135,7 @@
#define DPU_INTR_HIST_VIG_2_RSTSEQ_DONE BIT(9)
#define DPU_INTR_HIST_VIG_3_RSTSEQ_DONE BIT(11)
-/**
+/*
* Histogram DSPP done interrupt status bit definitions
*/
#define DPU_INTR_HIST_DSPP_0_DONE BIT(12)
@@ -143,7 +143,7 @@
#define DPU_INTR_HIST_DSPP_2_DONE BIT(20)
#define DPU_INTR_HIST_DSPP_3_DONE BIT(22)
-/**
+/*
* Histogram DSPP reset Sequence done interrupt status bit definitions
*/
#define DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE BIT(13)
@@ -151,7 +151,7 @@
#define DPU_INTR_HIST_DSPP_2_RSTSEQ_DONE BIT(21)
#define DPU_INTR_HIST_DSPP_3_RSTSEQ_DONE BIT(23)
-/**
+/*
* INTF interrupt status bit definitions
*/
#define DPU_INTR_VIDEO_INTO_STATIC BIT(0)
@@ -164,7 +164,7 @@
#define DPU_INTR_DSICMD_2_OUTOF_STATIC BIT(7)
#define DPU_INTR_PROG_LINE BIT(8)
-/**
+/*
* AD4 interrupt status bit definitions
*/
#define DPU_INTR_BACKLIGHT_UPDATED BIT(0)
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [Freedreno] [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses
2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
@ 2021-06-02 17:33 ` abhinavk
2021-06-04 8:32 ` Dmitry Baryshkov
1 sibling, 0 replies; 45+ messages in thread
From: abhinavk @ 2021-06-02 17:33 UTC (permalink / raw)
To: Lee Jones
Cc: Sean Paul, Krishna Manikandan, David Airlie, linux-arm-msm,
linux-kernel, dri-devel, freedreno
On 2021-06-02 07:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning:
> expecting prototype for Register offsets in MDSS register file for the
> interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:35: warning:
> expecting prototype for WB interrupt status bit definitions().
> Prototype was for DPU_INTR_WB_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:42: warning:
> expecting prototype for WDOG timer interrupt status bit definitions().
> Prototype was for DPU_INTR_WD_TIMER_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:51: warning:
> expecting prototype for Pingpong interrupt status bit definitions().
> Prototype was for DPU_INTR_PING_PONG_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:71: warning:
> expecting prototype for Interface interrupt status bit definitions().
> Prototype was for DPU_INTR_INTF_0_UNDERRUN() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:85: warning:
> expecting prototype for Pingpong Secondary interrupt status bit
> definitions(). Prototype was for
> DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:94: warning:
> expecting prototype for Pingpong TEAR detection interrupt status bit
> definitions(). Prototype was for DPU_INTR_PING_PONG_0_TEAR_DETECTED()
> instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:102: warning:
> expecting prototype for Pingpong TE detection interrupt status bit
> definitions(). Prototype was for DPU_INTR_PING_PONG_0_TE_DETECTED()
> instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:110: warning:
> expecting prototype for Ctl start interrupt status bit definitions().
> Prototype was for DPU_INTR_CTL_0_START() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:119: warning:
> expecting prototype for Concurrent WB overflow interrupt status bit
> definitions(). Prototype was for DPU_INTR_CWB_2_OVERFLOW() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:125: warning:
> expecting prototype for Histogram VIG done interrupt status bit
> definitions(). Prototype was for DPU_INTR_HIST_VIG_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:133: warning:
> expecting prototype for Histogram VIG reset Sequence done interrupt
> status bit definitions(). Prototype was for
> DPU_INTR_HIST_VIG_0_RSTSEQ_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:141: warning:
> expecting prototype for Histogram DSPP done interrupt status bit
> definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:149: warning:
> expecting prototype for Histogram DSPP reset Sequence done interrupt
> status bit definitions(). Prototype was for
> DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:157: warning:
> expecting prototype for INTF interrupt status bit definitions().
> Prototype was for DPU_INTR_VIDEO_INTO_STATIC() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:170: warning:
> expecting prototype for AD4 interrupt status bit definitions().
> Prototype was for DPU_INTR_BACKLIGHT_UPDATED() instead
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Krishna Manikandan <mkrishn@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 48c96b8121268..aaf251741dc27 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -10,7 +10,7 @@
> #include "dpu_hw_util.h"
> #include "dpu_hw_mdss.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
> @@ -29,14 +29,14 @@
> #define MDP_INTF_1_OFF_REV_7xxx 0x35000
> #define MDP_INTF_5_OFF_REV_7xxx 0x39000
>
> -/**
> +/*
> * WB interrupt status bit definitions
> */
> #define DPU_INTR_WB_0_DONE BIT(0)
> #define DPU_INTR_WB_1_DONE BIT(1)
> #define DPU_INTR_WB_2_DONE BIT(4)
>
> -/**
> +/*
> * WDOG timer interrupt status bit definitions
> */
> #define DPU_INTR_WD_TIMER_0_DONE BIT(2)
> @@ -45,7 +45,7 @@
> #define DPU_INTR_WD_TIMER_3_DONE BIT(6)
> #define DPU_INTR_WD_TIMER_4_DONE BIT(7)
>
> -/**
> +/*
> * Pingpong interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_DONE BIT(8)
> @@ -65,7 +65,7 @@
> #define DPU_INTR_PING_PONG_2_AUTOREFRESH_DONE BIT(22)
> #define DPU_INTR_PING_PONG_3_AUTOREFRESH_DONE BIT(23)
>
> -/**
> +/*
> * Interface interrupt status bit definitions
> */
> #define DPU_INTR_INTF_0_UNDERRUN BIT(24)
> @@ -79,7 +79,7 @@
> #define DPU_INTR_INTF_3_VSYNC BIT(31)
> #define DPU_INTR_INTF_5_VSYNC BIT(23)
>
> -/**
> +/*
> * Pingpong Secondary interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE BIT(0)
> @@ -88,7 +88,7 @@
> #define DPU_INTR_PING_PONG_S0_TEAR_DETECTED BIT(22)
> #define DPU_INTR_PING_PONG_S0_TE_DETECTED BIT(28)
>
> -/**
> +/*
> * Pingpong TEAR detection interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_TEAR_DETECTED BIT(16)
> @@ -96,7 +96,7 @@
> #define DPU_INTR_PING_PONG_2_TEAR_DETECTED BIT(18)
> #define DPU_INTR_PING_PONG_3_TEAR_DETECTED BIT(19)
>
> -/**
> +/*
> * Pingpong TE detection interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_TE_DETECTED BIT(24)
> @@ -104,7 +104,7 @@
> #define DPU_INTR_PING_PONG_2_TE_DETECTED BIT(26)
> #define DPU_INTR_PING_PONG_3_TE_DETECTED BIT(27)
>
> -/**
> +/*
> * Ctl start interrupt status bit definitions
> */
> #define DPU_INTR_CTL_0_START BIT(9)
> @@ -113,13 +113,13 @@
> #define DPU_INTR_CTL_3_START BIT(12)
> #define DPU_INTR_CTL_4_START BIT(13)
>
> -/**
> +/*
> * Concurrent WB overflow interrupt status bit definitions
> */
> #define DPU_INTR_CWB_2_OVERFLOW BIT(14)
> #define DPU_INTR_CWB_3_OVERFLOW BIT(15)
>
> -/**
> +/*
> * Histogram VIG done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_VIG_0_DONE BIT(0)
> @@ -127,7 +127,7 @@
> #define DPU_INTR_HIST_VIG_2_DONE BIT(8)
> #define DPU_INTR_HIST_VIG_3_DONE BIT(10)
>
> -/**
> +/*
> * Histogram VIG reset Sequence done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_VIG_0_RSTSEQ_DONE BIT(1)
> @@ -135,7 +135,7 @@
> #define DPU_INTR_HIST_VIG_2_RSTSEQ_DONE BIT(9)
> #define DPU_INTR_HIST_VIG_3_RSTSEQ_DONE BIT(11)
>
> -/**
> +/*
> * Histogram DSPP done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_DSPP_0_DONE BIT(12)
> @@ -143,7 +143,7 @@
> #define DPU_INTR_HIST_DSPP_2_DONE BIT(20)
> #define DPU_INTR_HIST_DSPP_3_DONE BIT(22)
>
> -/**
> +/*
> * Histogram DSPP reset Sequence done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE BIT(13)
> @@ -151,7 +151,7 @@
> #define DPU_INTR_HIST_DSPP_2_RSTSEQ_DONE BIT(21)
> #define DPU_INTR_HIST_DSPP_3_RSTSEQ_DONE BIT(23)
>
> -/**
> +/*
> * INTF interrupt status bit definitions
> */
> #define DPU_INTR_VIDEO_INTO_STATIC BIT(0)
> @@ -164,7 +164,7 @@
> #define DPU_INTR_DSICMD_2_OUTOF_STATIC BIT(7)
> #define DPU_INTR_PROG_LINE BIT(8)
>
> -/**
> +/*
> * AD4 interrupt status bit definitions
> */
> #define DPU_INTR_BACKLIGHT_UPDATED BIT(0)
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses
2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
2021-06-02 17:33 ` [Freedreno] " abhinavk
@ 2021-06-04 8:32 ` Dmitry Baryshkov
2021-06-04 8:57 ` Lee Jones
1 sibling, 1 reply; 45+ messages in thread
From: Dmitry Baryshkov @ 2021-06-04 8:32 UTC (permalink / raw)
To: Lee Jones
Cc: Krishna Manikandan, David Airlie, linux-arm-msm, linux-kernel,
dri-devel, freedreno, Sean Paul
On 02/06/2021 17:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting prototype for Register offsets in MDSS register file for the interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:35: warning: expecting prototype for WB interrupt status bit definitions(). Prototype was for DPU_INTR_WB_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:42: warning: expecting prototype for WDOG timer interrupt status bit definitions(). Prototype was for DPU_INTR_WD_TIMER_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:51: warning: expecting prototype for Pingpong interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:71: warning: expecting prototype for Interface interrupt status bit definitions(). Prototype was for DPU_INTR_INTF_0_UNDERRUN() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:85: warning: expecting prototype for Pingpong Secondary interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:94: warning: expecting prototype for Pingpong TEAR detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TEAR_DETECTED() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:102: warning: expecting prototype for Pingpong TE detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TE_DETECTED() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:110: warning: expecting prototype for Ctl start interrupt status bit definitions(). Prototype was for DPU_INTR_CTL_0_START() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:119: warning: expecting prototype for Concurrent WB overflow interrupt status bit definitions(). Prototype was for DPU_INTR_CWB_2_OVERFLOW() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:125: warning: expecting prototype for Histogram VIG done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:133: warning: expecting prototype for Histogram VIG reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_RSTSEQ_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:141: warning: expecting prototype for Histogram DSPP done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:149: warning: expecting prototype for Histogram DSPP reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:157: warning: expecting prototype for INTF interrupt status bit definitions(). Prototype was for DPU_INTR_VIDEO_INTO_STATIC() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:170: warning: expecting prototype for AD4 interrupt status bit definitions(). Prototype was for DPU_INTR_BACKLIGHT_UPDATED() instead
Most of these defines are gone in msm/msm-next. Could you please rebase
and repost just this patch? Other patches apply clearly.
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Krishna Manikandan <mkrishn@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> index 48c96b8121268..aaf251741dc27 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
> @@ -10,7 +10,7 @@
> #include "dpu_hw_util.h"
> #include "dpu_hw_mdss.h"
>
> -/**
> +/*
> * Register offsets in MDSS register file for the interrupt registers
> * w.r.t. to the MDP base
> */
> @@ -29,14 +29,14 @@
> #define MDP_INTF_1_OFF_REV_7xxx 0x35000
> #define MDP_INTF_5_OFF_REV_7xxx 0x39000
>
> -/**
> +/*
> * WB interrupt status bit definitions
> */
> #define DPU_INTR_WB_0_DONE BIT(0)
> #define DPU_INTR_WB_1_DONE BIT(1)
> #define DPU_INTR_WB_2_DONE BIT(4)
>
> -/**
> +/*
> * WDOG timer interrupt status bit definitions
> */
> #define DPU_INTR_WD_TIMER_0_DONE BIT(2)
> @@ -45,7 +45,7 @@
> #define DPU_INTR_WD_TIMER_3_DONE BIT(6)
> #define DPU_INTR_WD_TIMER_4_DONE BIT(7)
>
> -/**
> +/*
> * Pingpong interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_DONE BIT(8)
> @@ -65,7 +65,7 @@
> #define DPU_INTR_PING_PONG_2_AUTOREFRESH_DONE BIT(22)
> #define DPU_INTR_PING_PONG_3_AUTOREFRESH_DONE BIT(23)
>
> -/**
> +/*
> * Interface interrupt status bit definitions
> */
> #define DPU_INTR_INTF_0_UNDERRUN BIT(24)
> @@ -79,7 +79,7 @@
> #define DPU_INTR_INTF_3_VSYNC BIT(31)
> #define DPU_INTR_INTF_5_VSYNC BIT(23)
>
> -/**
> +/*
> * Pingpong Secondary interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE BIT(0)
> @@ -88,7 +88,7 @@
> #define DPU_INTR_PING_PONG_S0_TEAR_DETECTED BIT(22)
> #define DPU_INTR_PING_PONG_S0_TE_DETECTED BIT(28)
>
> -/**
> +/*
> * Pingpong TEAR detection interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_TEAR_DETECTED BIT(16)
> @@ -96,7 +96,7 @@
> #define DPU_INTR_PING_PONG_2_TEAR_DETECTED BIT(18)
> #define DPU_INTR_PING_PONG_3_TEAR_DETECTED BIT(19)
>
> -/**
> +/*
> * Pingpong TE detection interrupt status bit definitions
> */
> #define DPU_INTR_PING_PONG_0_TE_DETECTED BIT(24)
> @@ -104,7 +104,7 @@
> #define DPU_INTR_PING_PONG_2_TE_DETECTED BIT(26)
> #define DPU_INTR_PING_PONG_3_TE_DETECTED BIT(27)
>
> -/**
> +/*
> * Ctl start interrupt status bit definitions
> */
> #define DPU_INTR_CTL_0_START BIT(9)
> @@ -113,13 +113,13 @@
> #define DPU_INTR_CTL_3_START BIT(12)
> #define DPU_INTR_CTL_4_START BIT(13)
>
> -/**
> +/*
> * Concurrent WB overflow interrupt status bit definitions
> */
> #define DPU_INTR_CWB_2_OVERFLOW BIT(14)
> #define DPU_INTR_CWB_3_OVERFLOW BIT(15)
>
> -/**
> +/*
> * Histogram VIG done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_VIG_0_DONE BIT(0)
> @@ -127,7 +127,7 @@
> #define DPU_INTR_HIST_VIG_2_DONE BIT(8)
> #define DPU_INTR_HIST_VIG_3_DONE BIT(10)
>
> -/**
> +/*
> * Histogram VIG reset Sequence done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_VIG_0_RSTSEQ_DONE BIT(1)
> @@ -135,7 +135,7 @@
> #define DPU_INTR_HIST_VIG_2_RSTSEQ_DONE BIT(9)
> #define DPU_INTR_HIST_VIG_3_RSTSEQ_DONE BIT(11)
>
> -/**
> +/*
> * Histogram DSPP done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_DSPP_0_DONE BIT(12)
> @@ -143,7 +143,7 @@
> #define DPU_INTR_HIST_DSPP_2_DONE BIT(20)
> #define DPU_INTR_HIST_DSPP_3_DONE BIT(22)
>
> -/**
> +/*
> * Histogram DSPP reset Sequence done interrupt status bit definitions
> */
> #define DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE BIT(13)
> @@ -151,7 +151,7 @@
> #define DPU_INTR_HIST_DSPP_2_RSTSEQ_DONE BIT(21)
> #define DPU_INTR_HIST_DSPP_3_RSTSEQ_DONE BIT(23)
>
> -/**
> +/*
> * INTF interrupt status bit definitions
> */
> #define DPU_INTR_VIDEO_INTO_STATIC BIT(0)
> @@ -164,7 +164,7 @@
> #define DPU_INTR_DSICMD_2_OUTOF_STATIC BIT(7)
> #define DPU_INTR_PROG_LINE BIT(8)
>
> -/**
> +/*
> * AD4 interrupt status bit definitions
> */
> #define DPU_INTR_BACKLIGHT_UPDATED BIT(0)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses
2021-06-04 8:32 ` Dmitry Baryshkov
@ 2021-06-04 8:57 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-04 8:57 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Krishna Manikandan, David Airlie, linux-arm-msm, linux-kernel,
dri-devel, freedreno, Sean Paul
On Fri, 04 Jun 2021, Dmitry Baryshkov wrote:
> On 02/06/2021 17:32, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting prototype for Register offsets in MDSS register file for the interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:35: warning: expecting prototype for WB interrupt status bit definitions(). Prototype was for DPU_INTR_WB_0_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:42: warning: expecting prototype for WDOG timer interrupt status bit definitions(). Prototype was for DPU_INTR_WD_TIMER_0_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:51: warning: expecting prototype for Pingpong interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:71: warning: expecting prototype for Interface interrupt status bit definitions(). Prototype was for DPU_INTR_INTF_0_UNDERRUN() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:85: warning: expecting prototype for Pingpong Secondary interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_S0_AUTOREFRESH_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:94: warning: expecting prototype for Pingpong TEAR detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TEAR_DETECTED() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:102: warning: expecting prototype for Pingpong TE detection interrupt status bit definitions(). Prototype was for DPU_INTR_PING_PONG_0_TE_DETECTED() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:110: warning: expecting prototype for Ctl start interrupt status bit definitions(). Prototype was for DPU_INTR_CTL_0_START() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:119: warning: expecting prototype for Concurrent WB overflow interrupt status bit definitions(). Prototype was for DPU_INTR_CWB_2_OVERFLOW() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:125: warning: expecting prototype for Histogram VIG done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:133: warning: expecting prototype for Histogram VIG reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_VIG_0_RSTSEQ_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:141: warning: expecting prototype for Histogram DSPP done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:149: warning: expecting prototype for Histogram DSPP reset Sequence done interrupt status bit definitions(). Prototype was for DPU_INTR_HIST_DSPP_0_RSTSEQ_DONE() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:157: warning: expecting prototype for INTF interrupt status bit definitions(). Prototype was for DPU_INTR_VIDEO_INTO_STATIC() instead
> > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:170: warning: expecting prototype for AD4 interrupt status bit definitions(). Prototype was for DPU_INTR_BACKLIGHT_UPDATED() instead
>
> Most of these defines are gone in msm/msm-next. Could you please rebase and
> repost just this patch? Other patches apply clearly.
Sure.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (9 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 17:29 ` [Freedreno] " abhinavk
2021-06-02 14:32 ` [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones
` (15 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Sean Paul
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:373: warning: expecting prototype for _dpu_plane_set_panic_lut(). Prototype was for _dpu_plane_set_danger_lut() instead
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:498: warning: expecting prototype for _dpu_plane_set_vbif_qos(). Prototype was for _dpu_plane_set_qos_remap() instead
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 7a993547eb751..ed05a7ab58f53 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
@@ -364,7 +364,7 @@ static void _dpu_plane_set_qos_lut(struct drm_plane *plane,
}
/**
- * _dpu_plane_set_panic_lut - set danger/safe LUT of the given plane
+ * _dpu_plane_set_danger_lut - set danger/safe LUT of the given plane
* @plane: Pointer to drm plane
* @fb: Pointer to framebuffer associated with the given plane
*/
@@ -491,7 +491,7 @@ static void _dpu_plane_set_ot_limit(struct drm_plane *plane,
}
/**
- * _dpu_plane_set_vbif_qos - set vbif QoS for the given plane
+ * _dpu_plane_set_qos_remap - set vbif QoS for the given plane
* @plane: Pointer to drm plane
*/
static void _dpu_plane_set_qos_remap(struct drm_plane *plane)
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [Freedreno] [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
2021-06-02 14:32 ` [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones
@ 2021-06-02 17:29 ` abhinavk
0 siblings, 0 replies; 45+ messages in thread
From: abhinavk @ 2021-06-02 17:29 UTC (permalink / raw)
To: Lee Jones
Cc: Sean Paul, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
freedreno
On 2021-06-02 07:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:373: warning: expecting
> prototype for _dpu_plane_set_panic_lut(). Prototype was for
> _dpu_plane_set_danger_lut() instead
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:498: warning: expecting
> prototype for _dpu_plane_set_vbif_qos(). Prototype was for
> _dpu_plane_set_qos_remap() instead
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 7a993547eb751..ed05a7ab58f53 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -364,7 +364,7 @@ static void _dpu_plane_set_qos_lut(struct drm_plane
> *plane,
> }
>
> /**
> - * _dpu_plane_set_panic_lut - set danger/safe LUT of the given plane
> + * _dpu_plane_set_danger_lut - set danger/safe LUT of the given plane
> * @plane: Pointer to drm plane
> * @fb: Pointer to framebuffer associated with the given plane
> */
> @@ -491,7 +491,7 @@ static void _dpu_plane_set_ot_limit(struct
> drm_plane *plane,
> }
>
> /**
> - * _dpu_plane_set_vbif_qos - set vbif QoS for the given plane
> + * _dpu_plane_set_qos_remap - set vbif QoS for the given plane
> * @plane: Pointer to drm plane
> */
> static void _dpu_plane_set_qos_remap(struct drm_plane *plane)
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (10 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 11/26] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-04 0:49 ` Dmitry Baryshkov
2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
` (14 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Christian König, linaro-mm-sig, Sean Paul, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/msm_gem.c:364: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/msm/msm_gem.c:763: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/msm_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 56df86e5f7400..15434deb19334 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -372,7 +372,7 @@ static void del_vma(struct msm_gem_vma *vma)
kfree(vma);
}
-/**
+/*
* If close is true, this also closes the VMA (releasing the allocated
* iova range) in addition to removing the iommu mapping. In the eviction
* case (!close), we keep the iova allocated, but only remove the iommu
@@ -773,7 +773,7 @@ void msm_gem_purge(struct drm_gem_object *obj)
0, (loff_t)-1);
}
-/**
+/*
* Unpin the backing pages and make them available to be swapped out.
*/
void msm_gem_evict(struct drm_gem_object *obj)
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses
2021-06-02 14:32 ` [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones
@ 2021-06-04 0:49 ` Dmitry Baryshkov
0 siblings, 0 replies; 45+ messages in thread
From: Dmitry Baryshkov @ 2021-06-04 0:49 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Christian König, linaro-mm-sig, Sean Paul, linux-media
On 02/06/2021 17:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/msm_gem.c:364: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/gpu/drm/msm/msm_gem.c:763: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index 56df86e5f7400..15434deb19334 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -372,7 +372,7 @@ static void del_vma(struct msm_gem_vma *vma)
> kfree(vma);
> }
>
> -/**
> +/*
> * If close is true, this also closes the VMA (releasing the allocated
> * iova range) in addition to removing the iommu mapping. In the eviction
> * case (!close), we keep the iova allocated, but only remove the iommu
> @@ -773,7 +773,7 @@ void msm_gem_purge(struct drm_gem_object *obj)
> 0, (loff_t)-1);
> }
>
> -/**
> +/*
> * Unpin the backing pages and make them available to be swapped out.
> */
> void msm_gem_evict(struct drm_gem_object *obj)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (11 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 17:32 ` [Freedreno] " abhinavk
2021-06-02 23:52 ` Stephen Boyd
2021-06-02 14:32 ` [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones
` (13 subsequent siblings)
26 siblings, 2 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Stephen Boyd, Sean Paul, Chandan Uddaraju
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Function parameter or member 'dp_catalog' not described in 'dp_catalog_aux_reset'
drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Excess function parameter 'aux' description in 'dp_catalog_aux_reset'
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c
index f4f53f23e331e..9ba75b994595d 100644
--- a/drivers/gpu/drm/msm/dp/dp_catalog.c
+++ b/drivers/gpu/drm/msm/dp/dp_catalog.c
@@ -193,7 +193,7 @@ int dp_catalog_aux_clear_hw_interrupts(struct dp_catalog *dp_catalog)
/**
* dp_catalog_aux_reset() - reset AUX controller
*
- * @aux: DP catalog structure
+ * @dp_catalog: DP catalog structure
*
* return: void
*
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [Freedreno] [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
@ 2021-06-02 17:32 ` abhinavk
2021-06-02 23:52 ` Stephen Boyd
1 sibling, 0 replies; 45+ messages in thread
From: abhinavk @ 2021-06-02 17:32 UTC (permalink / raw)
To: Lee Jones
Cc: Sean Paul, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Stephen Boyd, freedreno, Chandan Uddaraju
On 2021-06-02 07:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Function parameter
> or member 'dp_catalog' not described in 'dp_catalog_aux_reset'
> drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Excess function
> parameter 'aux' description in 'dp_catalog_aux_reset'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c
> b/drivers/gpu/drm/msm/dp/dp_catalog.c
> index f4f53f23e331e..9ba75b994595d 100644
> --- a/drivers/gpu/drm/msm/dp/dp_catalog.c
> +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c
> @@ -193,7 +193,7 @@ int dp_catalog_aux_clear_hw_interrupts(struct
> dp_catalog *dp_catalog)
> /**
> * dp_catalog_aux_reset() - reset AUX controller
> *
> - * @aux: DP catalog structure
> + * @dp_catalog: DP catalog structure
> *
> * return: void
> *
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
2021-06-02 17:32 ` [Freedreno] " abhinavk
@ 2021-06-02 23:52 ` Stephen Boyd
1 sibling, 0 replies; 45+ messages in thread
From: Stephen Boyd @ 2021-06-02 23:52 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Sean Paul, Chandan Uddaraju
Quoting Lee Jones (2021-06-02 07:32:47)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Function parameter or member 'dp_catalog' not described in 'dp_catalog_aux_reset'
> drivers/gpu/drm/msm/dp/dp_catalog.c:206: warning: Excess function parameter 'aux' description in 'dp_catalog_aux_reset'
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (12 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 13/26] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-04 0:51 ` Dmitry Baryshkov
2021-06-02 14:32 ` [RESEND 15/26] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static Lee Jones
` (12 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Kuogee Hsieh, Sean Paul, Chandan Uddaraju
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead
drivers/gpu/drm/msm/dp/dp_link.c:573: warning: expecting prototype for dp_parse_phy_test_params(). Prototype was for dp_link_parse_phy_test_params() instead
drivers/gpu/drm/msm/dp/dp_link.c:975: warning: expecting prototype for dp_link_process_downstream_port_status_change(). Prototype was for dp_link_process_ds_port_status_change() instead
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/msm/dp/dp_link.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
index be986da78c4a5..1099604bd1c86 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -364,7 +364,7 @@ static int dp_link_parse_timing_params3(struct dp_link_private *link,
}
/**
- * dp_parse_video_pattern_params() - parses video pattern parameters from DPCD
+ * dp_link_parse_video_pattern_params() - parses video pattern parameters from DPCD
* @link: Display Port Driver data
*
* Returns 0 if it successfully parses the video link pattern and the link
@@ -563,7 +563,7 @@ static int dp_link_parse_link_training_params(struct dp_link_private *link)
}
/**
- * dp_parse_phy_test_params() - parses the phy link parameters
+ * dp_link_parse_phy_test_params() - parses the phy link parameters
* @link: Display Port Driver data
*
* Parses the DPCD (Byte 0x248) for the DP PHY link pattern that is being
@@ -961,7 +961,7 @@ static int dp_link_process_link_status_update(struct dp_link_private *link)
}
/**
- * dp_link_process_downstream_port_status_change() - process port status changes
+ * dp_link_process_ds_port_status_change() - process port status changes
* @link: Display Port Driver data
*
* This function will handle downstream port updates that are initiated by
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot
2021-06-02 14:32 ` [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones
@ 2021-06-04 0:51 ` Dmitry Baryshkov
0 siblings, 0 replies; 45+ messages in thread
From: Dmitry Baryshkov @ 2021-06-04 0:51 UTC (permalink / raw)
To: Lee Jones
Cc: freedreno, David Airlie, linux-arm-msm, linux-kernel, dri-devel,
Kuogee Hsieh, Sean Paul, Chandan Uddaraju
On 02/06/2021 17:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead
> drivers/gpu/drm/msm/dp/dp_link.c:573: warning: expecting prototype for dp_parse_phy_test_params(). Prototype was for dp_link_parse_phy_test_params() instead
> drivers/gpu/drm/msm/dp/dp_link.c:975: warning: expecting prototype for dp_link_process_downstream_port_status_change(). Prototype was for dp_link_process_ds_port_status_change() instead
>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Kuogee Hsieh <khsieh@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index be986da78c4a5..1099604bd1c86 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -364,7 +364,7 @@ static int dp_link_parse_timing_params3(struct dp_link_private *link,
> }
>
> /**
> - * dp_parse_video_pattern_params() - parses video pattern parameters from DPCD
> + * dp_link_parse_video_pattern_params() - parses video pattern parameters from DPCD
> * @link: Display Port Driver data
> *
> * Returns 0 if it successfully parses the video link pattern and the link
> @@ -563,7 +563,7 @@ static int dp_link_parse_link_training_params(struct dp_link_private *link)
> }
>
> /**
> - * dp_parse_phy_test_params() - parses the phy link parameters
> + * dp_link_parse_phy_test_params() - parses the phy link parameters
> * @link: Display Port Driver data
> *
> * Parses the DPCD (Byte 0x248) for the DP PHY link pattern that is being
> @@ -961,7 +961,7 @@ static int dp_link_process_link_status_update(struct dp_link_private *link)
> }
>
> /**
> - * dp_link_process_downstream_port_status_change() - process port status changes
> + * dp_link_process_ds_port_status_change() - process port status changes
> * @link: Display Port Driver data
> *
> * This function will handle downstream port updates that are initiated by
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 15/26] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (13 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
` (11 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: David Airlie, nouveau, Alistair Popple, linux-kernel, dri-devel,
Ben Skeggs
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:50:1: warning: no previous prototype for ‘tu102_mc_intr_unarm’ [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:62:1: warning: no previous prototype for ‘tu102_mc_intr_rearm’ [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c:74:1: warning: no previous prototype for ‘tu102_mc_intr_mask’ [-Wmissing-prototypes]
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c
index 58db83ebadc5f..a96084b34a788 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/tu102.c
@@ -46,7 +46,7 @@ tu102_mc_intr_update(struct tu102_mc *mc)
nvkm_wr32(device, 0xb81610, 0x6);
}
-void
+static void
tu102_mc_intr_unarm(struct nvkm_mc *base)
{
struct tu102_mc *mc = tu102_mc(base);
@@ -58,7 +58,7 @@ tu102_mc_intr_unarm(struct nvkm_mc *base)
spin_unlock_irqrestore(&mc->lock, flags);
}
-void
+static void
tu102_mc_intr_rearm(struct nvkm_mc *base)
{
struct tu102_mc *mc = tu102_mc(base);
@@ -70,7 +70,7 @@ tu102_mc_intr_rearm(struct nvkm_mc *base)
spin_unlock_irqrestore(&mc->lock, flags);
}
-void
+static void
tu102_mc_intr_mask(struct nvkm_mc *base, u32 mask, u32 intr)
{
struct tu102_mc *mc = tu102_mc(base);
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (14 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 15/26] drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference static Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:46 ` Harry Wentland
2021-06-02 16:23 ` Alex Deucher
2021-06-02 14:32 ` [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones
` (10 subsequent siblings)
26 siblings, 2 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Leo Li, Mauro Rossi, linux-kernel, amd-gfx, David Airlie,
dri-devel, Alex Deucher, Christian König
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28:
drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: warning: initialized field overwritten [-Woverride-init]
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: note: (near initialization for ‘xfm_regs[0].DCFE_MEM_LIGHT_SLEEP_CNTL’)
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43: warning: initialized field overwritten [-Woverride-init]
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Mauro Rossi <issor.oruam@gmail.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
index cbce194ec7b82..e98b5d4141739 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
@@ -166,8 +166,7 @@
SRI(SCL_F_SHARP_CONTROL, SCL, id)
#define XFM_COMMON_REG_LIST_DCE60(id) \
- XFM_COMMON_REG_LIST_DCE60_BASE(id), \
- SRI(DCFE_MEM_LIGHT_SLEEP_CNTL, CRTC, id)
+ XFM_COMMON_REG_LIST_DCE60_BASE(id)
#endif
#define XFM_SF(reg_name, field_name, post_fix)\
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
@ 2021-06-02 14:46 ` Harry Wentland
2021-06-02 16:23 ` Alex Deucher
1 sibling, 0 replies; 45+ messages in thread
From: Harry Wentland @ 2021-06-02 14:46 UTC (permalink / raw)
To: Lee Jones
Cc: Leo Li, Mauro Rossi, linux-kernel, amd-gfx, David Airlie,
dri-devel, Alex Deucher, Christian König
On 2021-06-02 10:32 a.m., Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’
> In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28:
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: warning: initialized field overwritten [-Woverride-init]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: note: (near initialization for ‘xfm_regs[0].DCFE_MEM_LIGHT_SLEEP_CNTL’)
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43: warning: initialized field overwritten [-Woverride-init]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mauro Rossi <issor.oruam@gmail.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Thanks for the fix.
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> index cbce194ec7b82..e98b5d4141739 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> @@ -166,8 +166,7 @@
> SRI(SCL_F_SHARP_CONTROL, SCL, id)
>
> #define XFM_COMMON_REG_LIST_DCE60(id) \
> - XFM_COMMON_REG_LIST_DCE60_BASE(id), \
> - SRI(DCFE_MEM_LIGHT_SLEEP_CNTL, CRTC, id)
> + XFM_COMMON_REG_LIST_DCE60_BASE(id)
> #endif
>
> #define XFM_SF(reg_name, field_name, post_fix)\
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
2021-06-02 14:46 ` Harry Wentland
@ 2021-06-02 16:23 ` Alex Deucher
2021-06-02 17:37 ` Lee Jones
1 sibling, 1 reply; 45+ messages in thread
From: Alex Deucher @ 2021-06-02 16:23 UTC (permalink / raw)
To: Lee Jones
Cc: Leo Li, Mauro Rossi, LKML, Maling list - DRI developers,
David Airlie, amd-gfx list, Alex Deucher, Christian König
On Wed, Jun 2, 2021 at 10:33 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’
> In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28:
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: warning: initialized field overwritten [-Woverride-init]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: note: (near initialization for ‘xfm_regs[0].DCFE_MEM_LIGHT_SLEEP_CNTL’)
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43: warning: initialized field overwritten [-Woverride-init]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mauro Rossi <issor.oruam@gmail.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> index cbce194ec7b82..e98b5d4141739 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> @@ -166,8 +166,7 @@
> SRI(SCL_F_SHARP_CONTROL, SCL, id)
>
> #define XFM_COMMON_REG_LIST_DCE60(id) \
> - XFM_COMMON_REG_LIST_DCE60_BASE(id), \
> - SRI(DCFE_MEM_LIGHT_SLEEP_CNTL, CRTC, id)
> + XFM_COMMON_REG_LIST_DCE60_BASE(id)
I believe DCFE_MEM_LIGHT_SLEEP_CNTL should be kept here and it should
be removed from
XFM_COMMON_REG_LIST_DCE60_BASE() to align with other asics.
Alex
> #endif
>
> #define XFM_SF(reg_name, field_name, post_fix)\
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
2021-06-02 16:23 ` Alex Deucher
@ 2021-06-02 17:37 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 17:37 UTC (permalink / raw)
To: Alex Deucher
Cc: Leo Li, Mauro Rossi, LKML, Maling list - DRI developers,
David Airlie, amd-gfx list, Alex Deucher, Christian König
On Wed, 02 Jun 2021, Alex Deucher wrote:
> On Wed, Jun 2, 2021 at 10:33 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’
> > In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:28:
> > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: warning: initialized field overwritten [-Woverride-init]
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:568:43: note: (near initialization for ‘xfm_regs[0].DCFE_MEM_LIGHT_SLEEP_CNTL’)
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:14: note: in expansion of macro ‘mmCRTC0_DCFE_MEM_LIGHT_SLEEP_CNTL’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.h:170:2: note: in expansion of macro ‘SRI’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:183:3: note: in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: in expansion of macro ‘transform_regs’
> > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43: warning: initialized field overwritten [-Woverride-init]
> >
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Leo Li <sunpeng.li@amd.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Mauro Rossi <issor.oruam@gmail.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> > index cbce194ec7b82..e98b5d4141739 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h
> > @@ -166,8 +166,7 @@
> > SRI(SCL_F_SHARP_CONTROL, SCL, id)
> >
> > #define XFM_COMMON_REG_LIST_DCE60(id) \
> > - XFM_COMMON_REG_LIST_DCE60_BASE(id), \
> > - SRI(DCFE_MEM_LIGHT_SLEEP_CNTL, CRTC, id)
> > + XFM_COMMON_REG_LIST_DCE60_BASE(id)
>
> I believe DCFE_MEM_LIGHT_SLEEP_CNTL should be kept here and it should
> be removed from
> XFM_COMMON_REG_LIST_DCE60_BASE() to align with other asics.
Ack. Sorry for missing this.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (15 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL, Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 16:20 ` Laurent Pinchart
2021-06-02 14:32 ` [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones
` (9 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Hyun Kwon, David Airlie, Michal Simek, dri-devel, linux-kernel,
Laurent Pinchart, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 109d627968ac0..ca1161ec9e16f 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -91,7 +91,7 @@ struct zynqmp_disp_format {
};
/**
- * enum zynqmp_disp_id - Layer identifier
+ * enum zynqmp_disp_layer_id - Layer identifier
* @ZYNQMP_DISP_LAYER_VID: Video layer
* @ZYNQMP_DISP_LAYER_GFX: Graphics layer
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id'
2021-06-02 14:32 ` [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones
@ 2021-06-02 16:20 ` Laurent Pinchart
2021-06-03 11:30 ` Daniel Vetter
0 siblings, 1 reply; 45+ messages in thread
From: Laurent Pinchart @ 2021-06-02 16:20 UTC (permalink / raw)
To: Lee Jones
Cc: Hyun Kwon, David Airlie, linux-kernel, dri-devel, Michal Simek,
linux-arm-kernel
Hi Lee,
Thank you for the patch.
On Wed, Jun 02, 2021 at 03:32:51PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead
>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 109d627968ac0..ca1161ec9e16f 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -91,7 +91,7 @@ struct zynqmp_disp_format {
> };
>
> /**
> - * enum zynqmp_disp_id - Layer identifier
> + * enum zynqmp_disp_layer_id - Layer identifier
> * @ZYNQMP_DISP_LAYER_VID: Video layer
> * @ZYNQMP_DISP_LAYER_GFX: Graphics layer
> */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id'
2021-06-02 16:20 ` Laurent Pinchart
@ 2021-06-03 11:30 ` Daniel Vetter
0 siblings, 0 replies; 45+ messages in thread
From: Daniel Vetter @ 2021-06-03 11:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Hyun Kwon, David Airlie, linux-kernel, dri-devel, Michal Simek,
Lee Jones, linux-arm-kernel
On Wed, Jun 02, 2021 at 07:20:35PM +0300, Laurent Pinchart wrote:
> Hi Lee,
>
> Thank you for the patch.
>
> On Wed, Jun 02, 2021 at 03:32:51PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/xlnx/zynqmp_disp.c:101: warning: expecting prototype for enum zynqmp_disp_id. Prototype was for enum zynqmp_disp_layer_id instead
> >
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I'm assuming you'll merge these two for xlnx somehow?
-Daniel
>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 109d627968ac0..ca1161ec9e16f 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -91,7 +91,7 @@ struct zynqmp_disp_format {
> > };
> >
> > /**
> > - * enum zynqmp_disp_id - Layer identifier
> > + * enum zynqmp_disp_layer_id - Layer identifier
> > * @ZYNQMP_DISP_LAYER_VID: Video layer
> > * @ZYNQMP_DISP_LAYER_GFX: Graphics layer
> > */
>
> --
> Regards,
>
> Laurent Pinchart
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (16 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 17/26] drm/xlnx/zynqmp_disp: Fix incorrectly named enum 'zynqmp_disp_layer_id' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 16:23 ` Laurent Pinchart
2021-06-02 14:32 ` [RESEND 19/26] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones
` (8 subsequent siblings)
26 siblings, 1 reply; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Hyun Kwon, David Airlie, Michal Simek, dri-devel, linux-kernel,
Laurent Pinchart, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 82430ca9b9133..a1055d5055eab 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)
}
/**
- * zynqmp_dp_link_train - Train the link
+ * zynqmp_dp_train - Train the link
* @dp: DisplayPort IP core structure
*
* Return: 0 if all trains are done successfully, or corresponding error code.
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
2021-06-02 14:32 ` [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones
@ 2021-06-02 16:23 ` Laurent Pinchart
2021-06-02 17:38 ` Lee Jones
0 siblings, 1 reply; 45+ messages in thread
From: Laurent Pinchart @ 2021-06-02 16:23 UTC (permalink / raw)
To: Lee Jones
Cc: Hyun Kwon, David Airlie, linux-kernel, dri-devel, Michal Simek,
linux-arm-kernel
Hi Lee,
Thank you for the patch.
On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead
>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 82430ca9b9133..a1055d5055eab 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)
> }
>
> /**
> - * zynqmp_dp_link_train - Train the link
> + * zynqmp_dp_train - Train the link
The driver has other functions related to link training that start with
the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to
zynqmp_dp_link_train(). Bonus points if the same patch could rename
zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-)
> * @dp: DisplayPort IP core structure
> *
> * Return: 0 if all trains are done successfully, or corresponding error code.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
2021-06-02 16:23 ` Laurent Pinchart
@ 2021-06-02 17:38 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 17:38 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Hyun Kwon, David Airlie, linux-kernel, dri-devel, Michal Simek,
linux-arm-kernel
On Wed, 02 Jun 2021, Laurent Pinchart wrote:
> Hi Lee,
>
> Thank you for the patch.
>
> On Wed, Jun 02, 2021 at 03:32:52PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/xlnx/zynqmp_dp.c:806: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead
> >
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > index 82430ca9b9133..a1055d5055eab 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > @@ -797,7 +797,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp)
> > }
> >
> > /**
> > - * zynqmp_dp_link_train - Train the link
> > + * zynqmp_dp_train - Train the link
>
> The driver has other functions related to link training that start with
> the zynqmp_dp_link_train_* prefix. I'd prefer renaming this function to
> zynqmp_dp_link_train(). Bonus points if the same patch could rename
> zynqmp_dp_train_loop() to zynqmp_dp_link_train_loop() too :-)
Doesn't have much to do with this patch though? :)
Happy to help though. Can I fix subsequently?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread
* [RESEND 19/26] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (17 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 18/26] drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 20/26] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones
` (7 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: David Airlie, linux-kernel, dri-devel, Huang Rui, Christian Koenig
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_pages' not described in 'ttm_tt_mgr_init'
drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member 'num_dma32_pages' not described in 'ttm_tt_mgr_init'
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index 539e0232cb3b4..682c840c9a517 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -415,7 +415,7 @@ DEFINE_SHOW_ATTRIBUTE(ttm_tt_debugfs_shrink);
#endif
-/**
+/*
* ttm_tt_mgr_init - register with the MM shrinker
*
* Register with the MM shrinker for swapping out BOs.
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 20/26] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (18 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 19/26] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 21/26] drm/panel/panel-sitronix-st7701: " Lee Jones
` (6 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: David Airlie, linux-kernel, dri-devel, Thierry Reding, Sam Ravnborg
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c:33: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
index 5e9ccefb88f62..2229f1af2ca8c 100644
--- a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
+++ b/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
@@ -29,7 +29,7 @@
* DEALINGS IN THE SOFTWARE.
*/
-/**
+/*
* Raspberry Pi 7" touchscreen panel driver.
*
* The 7" touchscreen consists of a DPI LCD panel, a Toshiba
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 21/26] drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (19 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 20/26] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 22/26] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format Lee Jones
` (5 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: David Airlie, linux-kernel, dri-devel, Thierry Reding,
Jagan Teki, Sam Ravnborg
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/panel/panel-sitronix-st7701.c:42: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
index 4d2a149b202cb..320a2a8fd4592 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7701.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
@@ -38,7 +38,7 @@
#define DSI_CMD2_BK1_SPD2 0xC2 /* Source EQ2 Setting */
#define DSI_CMD2_BK1_MIPISET1 0xD0 /* MIPI Setting 1 */
-/**
+/*
* Command2 with BK function selection.
*
* BIT[4, 0]: [CN2, BKXSEL]
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 22/26] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (20 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 21/26] drm/panel/panel-sitronix-st7701: " Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 23/26] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' Lee Jones
` (4 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: Ben Widawsky, David Airlie, linux-kernel, dri-devel,
linaro-mm-sig, Christian König, linux-media
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/vgem/vgem_drv.c:47: warning: expecting prototype for This is vgem, a (non-hardware(). Prototype was for DRIVER_NAME() instead
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Adam Jackson <ajax@redhat.com>
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index a0e75f1d5d016..bf38a7e319d14 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -25,7 +25,7 @@
* Ben Widawsky <ben@bwidawsk.net>
*/
-/**
+/*
* This is vgem, a (non-hardware-backed) GEM service. This is used by Mesa's
* software renderer and the X server for efficient buffer sharing.
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 23/26] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (21 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 22/26] drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc format Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()' Lee Jones
` (3 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: linux-samsung-soc, Joonyoung Shim, Krzysztof Kozlowski,
David Airlie, Seung-Woo Kim, linux-kernel, dri-devel,
Kyungmin Park, Akshu Agarwal, Ajay Kumar, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/exynos/exynos7_drm_decon.c:355: warning: expecting prototype for shadow_protect_win(). Prototype was for decon_shadow_protect_win() instead
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Akshu Agarwal <akshua@gmail.com>
Cc: Ajay Kumar <ajaykumar.rs@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index 431c5d32f9a47..9b5e6f94e5585 100644
--- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
@@ -344,7 +344,7 @@ static void decon_win_set_colkey(struct decon_context *ctx, unsigned int win)
}
/**
- * shadow_protect_win() - disable updating values from shadow registers at vsync
+ * decon_shadow_protect_win() - disable updating values from shadow registers at vsync
*
* @ctx: display and enhancement controller context
* @win: window to protect registers for
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()'
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (22 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 23/26] drm/exynos/exynos7_drm_decon: Fix incorrect naming of 'decon_shadow_protect_win()' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:32 ` [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers Lee Jones
` (2 subsequent siblings)
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones
Cc: linux-samsung-soc, Joonyoung Shim, Krzysztof Kozlowski,
David Airlie, Seung-Woo Kim, linux-kernel, dri-devel,
Kyungmin Park, linux-arm-kernel, Marek Szyprowski
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/exynos/exynos_drm_ipp.c:105: warning: expecting prototype for exynos_drm_ipp_ioctl_get_res_ioctl(). Prototype was for exynos_drm_ipp_get_res_ioctl() instead
drivers/gpu/drm/exynos/exynos_drm_ipp.c:153: warning: expecting prototype for exynos_drm_ipp_ioctl_get_caps(). Prototype was for exynos_drm_ipp_get_caps_ioctl() instead
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
index 4f2b7551b2515..9ae8689353579 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
@@ -88,7 +88,7 @@ void exynos_drm_ipp_unregister(struct device *dev,
}
/**
- * exynos_drm_ipp_ioctl_get_res_ioctl - enumerate all ipp modules
+ * exynos_drm_ipp_get_res_ioctl - enumerate all ipp modules
* @dev: DRM device
* @data: ioctl data
* @file_priv: DRM file info
@@ -136,7 +136,7 @@ static inline struct exynos_drm_ipp *__ipp_get(uint32_t id)
}
/**
- * exynos_drm_ipp_ioctl_get_caps - get ipp module capabilities and formats
+ * exynos_drm_ipp_get_caps_ioctl - get ipp module capabilities and formats
* @dev: DRM device
* @data: ioctl data
* @file_priv: DRM file info
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (23 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 24/26] drm/exynos/exynos_drm_ipp: Fix documentation for 'exynos_drm_ipp_get_{caps, res}_ioctl()' Lee Jones
@ 2021-06-02 14:32 ` Lee Jones
2021-06-02 14:33 ` [RESEND 26/26] drm/vboxvideo/modesetting: Provide function names for prototype headers Lee Jones
2021-06-03 11:34 ` [RESEND 00/26] Rid W=1 warnings from GPU Daniel Vetter
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:32 UTC (permalink / raw)
To: lee.jones; +Cc: David Airlie, Hans de Goede, dri-devel, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/vboxvideo/hgsmi_base.c:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/vboxvideo/hgsmi_base.c:42: warning: expecting prototype for Notify the host of HGSMI(). Prototype was for hgsmi_send_caps_info() instead
drivers/gpu/drm/vboxvideo/hgsmi_base.c:74: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/vboxvideo/hgsmi_base.c:102: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/vboxvideo/hgsmi_base.c:174: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/vboxvideo/hgsmi_base.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/hgsmi_base.c b/drivers/gpu/drm/vboxvideo/hgsmi_base.c
index 361d3193258ea..8c041d7ce4f1b 100644
--- a/drivers/gpu/drm/vboxvideo/hgsmi_base.c
+++ b/drivers/gpu/drm/vboxvideo/hgsmi_base.c
@@ -9,7 +9,8 @@
#include "hgsmi_ch_setup.h"
/**
- * Inform the host of the location of the host flags in VRAM via an HGSMI cmd.
+ * hgsmi_report_flags_location - Inform the host of the location of
+ * the host flags in VRAM via an HGSMI cmd.
* Return: 0 or negative errno value.
* @ctx: The context of the guest heap to use.
* @location: The offset chosen for the flags within guest VRAM.
@@ -33,7 +34,8 @@ int hgsmi_report_flags_location(struct gen_pool *ctx, u32 location)
}
/**
- * Notify the host of HGSMI-related guest capabilities via an HGSMI command.
+ * hgsmi_send_caps_info - Notify the host of HGSMI-related guest capabilities
+ * via an HGSMI command.
* Return: 0 or negative errno value.
* @ctx: The context of the guest heap to use.
* @caps: The capabilities to report, see vbva_caps.
@@ -71,7 +73,8 @@ int hgsmi_test_query_conf(struct gen_pool *ctx)
}
/**
- * Query the host for an HGSMI configuration parameter via an HGSMI command.
+ * hgsmi_query_conf - Query the host for an HGSMI configuration
+ * parameter via an HGSMI command.
* Return: 0 or negative errno value.
* @ctx: The context containing the heap used.
* @index: The index of the parameter to query.
@@ -99,7 +102,8 @@ int hgsmi_query_conf(struct gen_pool *ctx, u32 index, u32 *value_ret)
}
/**
- * Pass the host a new mouse pointer shape via an HGSMI command.
+ * hgsmi_update_pointer_shape - Pass the host a new mouse pointer shape
+ * via an HGSMI command.
* Return: 0 or negative errno value.
* @ctx: The context containing the heap to be used.
* @flags: Cursor flags.
@@ -171,9 +175,10 @@ int hgsmi_update_pointer_shape(struct gen_pool *ctx, u32 flags,
}
/**
- * Report the guest cursor position. The host may wish to use this information
- * to re-position its own cursor (though this is currently unlikely). The
- * current host cursor position is returned.
+ * hgsmi_cursor_position - Report the guest cursor position. The host may
+ * wish to use this information to re-position its
+ * own cursor (though this is currently unlikely).
+ * The current host cursor position is returned.
* Return: 0 or negative errno value.
* @ctx: The context containing the heap used.
* @report_position: Are we reporting a position?
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* [RESEND 26/26] drm/vboxvideo/modesetting: Provide function names for prototype headers
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (24 preceding siblings ...)
2021-06-02 14:32 ` [RESEND 25/26] drm/vboxvideo/hgsmi_base: Place function names into headers Lee Jones
@ 2021-06-02 14:33 ` Lee Jones
2021-06-03 11:34 ` [RESEND 00/26] Rid W=1 warnings from GPU Daniel Vetter
26 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-02 14:33 UTC (permalink / raw)
To: lee.jones; +Cc: David Airlie, Hans de Goede, dri-devel, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/vboxvideo/modesetting.c:11: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/vboxvideo/modesetting.c:54: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/vboxvideo/modesetting.c:87: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/vboxvideo/modesetting.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/modesetting.c b/drivers/gpu/drm/vboxvideo/modesetting.c
index 7580b90023792..10b32d986b956 100644
--- a/drivers/gpu/drm/vboxvideo/modesetting.c
+++ b/drivers/gpu/drm/vboxvideo/modesetting.c
@@ -8,9 +8,11 @@
#include "hgsmi_channels.h"
/**
- * Set a video mode via an HGSMI request. The views must have been
- * initialised first using @a VBoxHGSMISendViewInfo and if the mode is being
- * set on the first display then it must be set first using registers.
+ * hgsmi_process_display_info - Set a video mode via an HGSMI request.
+ * The views must have been initialised first
+ * using @a VBoxHGSMISendViewInfo and if the mode
+ * is being set on the first display then it must
+ * be set first using registers.
* @ctx: The context containing the heap to use.
* @display: The screen number.
* @origin_x: The horizontal displacement relative to the first scrn.
@@ -51,10 +53,12 @@ void hgsmi_process_display_info(struct gen_pool *ctx, u32 display,
}
/**
- * Report the rectangle relative to which absolute pointer events should be
- * expressed. This information remains valid until the next VBVA resize event
- * for any screen, at which time it is reset to the bounding rectangle of all
- * virtual screens.
+ * hgsmi_update_input_mapping - Report the rectangle relative to which absolute
+ * pointer events should be expressed. This
+ * information remains valid until the next VBVA
+ * resize event for any screen, at which time it is
+ * reset to the bounding rectangle of all virtual
+ * screens.
* Return: 0 or negative errno value.
* @ctx: The context containing the heap to use.
* @origin_x: Upper left X co-ordinate relative to the first screen.
@@ -84,7 +88,7 @@ int hgsmi_update_input_mapping(struct gen_pool *ctx, s32 origin_x, s32 origin_y,
}
/**
- * Get most recent video mode hints.
+ * hgsmi_get_mode_hints - Get most recent video mode hints.
* Return: 0 or negative errno value.
* @ctx: The context containing the heap to use.
* @screens: The number of screens to query hints for, starting at 0.
--
2.31.1
^ permalink raw reply related [flat|nested] 45+ messages in thread* Re: [RESEND 00/26] Rid W=1 warnings from GPU
2021-06-02 14:32 [RESEND 00/26] Rid W=1 warnings from GPU Lee Jones
` (25 preceding siblings ...)
2021-06-02 14:33 ` [RESEND 26/26] drm/vboxvideo/modesetting: Provide function names for prototype headers Lee Jones
@ 2021-06-03 11:34 ` Daniel Vetter
2021-06-03 11:52 ` Lee Jones
26 siblings, 1 reply; 45+ messages in thread
From: Daniel Vetter @ 2021-06-03 11:34 UTC (permalink / raw)
To: Lee Jones
Cc: David Airlie, nouveau, Mauro Rossi, dri-devel, Huang Rui,
Fabien Dessenne, Benjamin Gaignard, AngeloGioacchino Del Regno,
Kuogee Hsieh, Sam Ravnborg, Ajay Kumar, Chandan Uddaraju,
Marek Szyprowski, Ben Widawsky, linux-samsung-soc,
Joonyoung Shim, Krzysztof Kozlowski, Vincent Abriou,
Alistair Popple, Michal Simek, amd-gfx, Ben Skeggs, Jagan Teki,
Thierry Reding, Chun-Kuang Hu, Leo Li, linux-arm-msm,
Stephen Boyd, Hans de Goede, Akshu Agarwal, Matthias Brugger,
Sean Paul, linux-arm-kernel, Krishna Manikandan, Hyun Kwon,
Seung-Woo Kim, linux-kernel, Kyungmin Park, linaro-mm-sig,
Alex Deucher, linux-mediatek, linux-media, freedreno,
Christian Koenig, Laurent Pinchart
On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote:
> Some off these patches have been knocking around for a while.
>
> Who will hoover them up please?
>
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (26):
> drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header
> drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant
> kernel-doc header
> drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header
> drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc
> header
> drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc
> headers
> drm/sti/sti_hda: Provide missing function names
> drm/sti/sti_tvout: Provide a bunch of missing function names
> drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'
> drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable
> 'cmd_enc'
> drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc
> abuses
> drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
> drm/msm/msm_gem: Demote kernel-doc abuses
> drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
> drm/msm/dp/dp_link: Fix some potential doc-rot
> drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference
> static
> drm/amd/display/dc/dce/dce_transform: Remove superfluous
> re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
> drm/xlnx/zynqmp_disp: Fix incorrectly named enum
> 'zynqmp_disp_layer_id'
> drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
> drm/ttm/ttm_tt: Demote non-conformant kernel-doc header
> drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse
> drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse
> drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc
> format
> drm/exynos/exynos7_drm_decon: Fix incorrect naming of
> 'decon_shadow_protect_win()'
> drm/exynos/exynos_drm_ipp: Fix documentation for
> 'exynos_drm_ipp_get_{caps,res}_ioctl()'
> drm/vboxvideo/hgsmi_base: Place function names into headers
> drm/vboxvideo/modesetting: Provide function names for prototype
> headers
Except for msm (Rob Clark promised on irc he'll pick them up for 5.14
soon) and amd (Alex is on top of things I think) I picked them all up and
merged into drm-misc-next.
Thanks, Daniel
>
> .../drm/amd/display/dc/dce/dce_transform.h | 3 +-
> drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +-
> drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 +--
> drivers/gpu/drm/mediatek/mtk_disp_color.c | 3 +-
> drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +--
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +-
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +--
> .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---
> .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +++++++++----------
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 +--
> drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
> drivers/gpu/drm/msm/dp/dp_link.c | 6 ++--
> drivers/gpu/drm/msm/msm_gem.c | 4 +--
> .../gpu/drm/nouveau/nvkm/subdev/mc/tu102.c | 6 ++--
> .../drm/panel/panel-raspberrypi-touchscreen.c | 2 +-
> drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +-
> drivers/gpu/drm/sti/sti_hda.c | 6 ++--
> drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 4 +--
> drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
> drivers/gpu/drm/sti/sti_tvout.c | 18 +++++------
> drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
> drivers/gpu/drm/vboxvideo/hgsmi_base.c | 19 +++++++----
> drivers/gpu/drm/vboxvideo/modesetting.c | 20 +++++++-----
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 26 files changed, 80 insertions(+), 82 deletions(-)
>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: Ajay Kumar <ajaykumar.rs@samsung.com>
> Cc: Akshu Agarwal <akshua@gmail.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Alistair Popple <apopple@nvidia.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Fabien Dessenne <fabien.dessenne@st.com>
> Cc: freedreno@lists.freedesktop.org
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Cc: Krishna Manikandan <mkrishn@codeaurora.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Kuogee Hsieh <khsieh@codeaurora.org>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Mauro Rossi <issor.oruam@gmail.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: nouveau@lists.freedesktop.org
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> --
> 2.31.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [RESEND 00/26] Rid W=1 warnings from GPU
2021-06-03 11:34 ` [RESEND 00/26] Rid W=1 warnings from GPU Daniel Vetter
@ 2021-06-03 11:52 ` Lee Jones
0 siblings, 0 replies; 45+ messages in thread
From: Lee Jones @ 2021-06-03 11:52 UTC (permalink / raw)
To: linux-kernel, Adam Jackson, Ajay Kumar, Akshu Agarwal,
Alex Deucher, Alistair Popple, amd-gfx,
AngeloGioacchino Del Regno, Benjamin Gaignard, Ben Skeggs,
Ben Widawsky, Chandan Uddaraju, Christian Koenig, Chun-Kuang Hu,
David Airlie, dri-devel, Eric Anholt, Fabien Dessenne, freedreno,
Hans de Goede, Harry Wentland, Huang Rui, Hyun Kwon, Inki Dae,
Jagan Teki, Joonyoung Shim, Krishna Manikandan,
Krzysztof Kozlowski, Kuogee Hsieh, Kyungmin Park,
Laurent Pinchart, Leo Li, linaro-mm-sig, linux-arm-kernel,
linux-arm-msm, linux-mediatek, linux-media, linux-samsung-soc,
Marek Szyprowski, Matthias Brugger, Mauro Rossi, Michal Simek,
nouveau, Philipp Zabel, Rob Clark, Sam Ravnborg, Sean Paul,
Seung-Woo Kim, Stephen Boyd, Sumit Semwal, Thierry Reding,
Vincent Abriou
On Thu, 03 Jun 2021, Daniel Vetter wrote:
> On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote:
> > Some off these patches have been knocking around for a while.
> >
> > Who will hoover them up please?
> >
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (26):
> > drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header
> > drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant
> > kernel-doc header
> > drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header
> > drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc
> > header
> > drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc
> > headers
> > drm/sti/sti_hda: Provide missing function names
> > drm/sti/sti_tvout: Provide a bunch of missing function names
> > drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'
> > drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable
> > 'cmd_enc'
> > drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc
> > abuses
> > drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
> > drm/msm/msm_gem: Demote kernel-doc abuses
> > drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
> > drm/msm/dp/dp_link: Fix some potential doc-rot
> > drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference
> > static
> > drm/amd/display/dc/dce/dce_transform: Remove superfluous
> > re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
> > drm/xlnx/zynqmp_disp: Fix incorrectly named enum
> > 'zynqmp_disp_layer_id'
> > drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
> > drm/ttm/ttm_tt: Demote non-conformant kernel-doc header
> > drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse
> > drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse
> > drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc
> > format
> > drm/exynos/exynos7_drm_decon: Fix incorrect naming of
> > 'decon_shadow_protect_win()'
> > drm/exynos/exynos_drm_ipp: Fix documentation for
> > 'exynos_drm_ipp_get_{caps,res}_ioctl()'
> > drm/vboxvideo/hgsmi_base: Place function names into headers
> > drm/vboxvideo/modesetting: Provide function names for prototype
> > headers
>
> Except for msm (Rob Clark promised on irc he'll pick them up for 5.14
> soon) and amd (Alex is on top of things I think) I picked them all up and
> merged into drm-misc-next.
Superstar! Thanks Daniel.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 45+ messages in thread