From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Andrzej Hajda <a.hajda@samsung.com>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Philippe CORNU <philippe.cornu@st.com>,
Yannick FERTRE <yannick.fertre@st.com>,
linux-rockchip@lists.infradead.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Wed, 01 Jul 2020 23:32:18 +0300 [thread overview]
Message-ID: <87imf7j7sd.fsf@collabora.com> (raw)
In-Reply-To: <6400388.H4HLtoO0Qf@diego>
Hi Heiko,
On Wed, 01 Jul 2020, Heiko Stübner <heiko@sntech.de> wrote:
> Hi Adrian,
>
> Am Dienstag, 9. Juni 2020, 19:49:48 CEST schrieb Adrian Ratiu:
>> [Re-submitting to cc dri-devel, sorry about the noise] Hello
>> all, v9 cleanly applies on top of latest next-20200609 tree.
>
> at least it doesn't apply on top of current drm-misc-next for me
> which I really don't understand.
>
> Like patch 2/11 does
>
> @@ -31,6 +31,7 @@
> #include <drm/drm_probe_helper.h>
> .
> #define HWVER_131<----><------><------>0x31333100<---->/* IP
> version 1.31 */
> +#define HWVER_130<----><------><------>0x31333000<---->/* IP
> version 1.30 */ .
> #define DSI_VERSION<--><------><------>0x00 #define
> VERSION<------><------><------><------>GENMASK(31, 8)
>
> where the file currently looks like
>
> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h>
> #include <drm/drm_crtc.h> #include <drm/drm_mipi_dsi.h> #include
> <drm/drm_modes.h> #include <drm/drm_of.h> #include
> <drm/drm_print.h>
>
> #define HWVER_131 0x31333100 /* IP
> version 1.31 */
>
> #define DSI_VERSION 0x00 #define VERSION
> GENMASK(31, 8)
>
> even in Linux-next
>
> So I guess ideally rebase on top of drm-misc-next
I will send a rebase on top of drm-misc-next soon (with the last
DTS nitpick fixed and the latest acks and reviewed-by tags added).
In the meantime I also found someone within Collabora who has a RK
with a DSI panel and found a bug (likely clock is not enabled
early enough to access the cfg registers to get the version for
regmap).
I'm super happy this is getting tested on RK, thank you!
>
>
> Thanks
> Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-07-01 20:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 17:49 [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 01/11] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 02/11] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 03/11] drm: bridge: dw_mipi_dsi: add dsi v1.01 support Adrian Ratiu
2020-06-10 12:20 ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 04/11] drm: bridge: dw_mipi_dsi: remove bind/unbind API Adrian Ratiu
2020-06-10 12:21 ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 05/11] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Adrian Ratiu
2020-06-12 21:11 ` Rob Herring
2020-06-09 17:49 ` [PATCH v9 06/11] ARM: dts: imx6qdl: add missing mipi dsi properties Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 07/11] drm: imx: Add i.MX 6 MIPI DSI host platform driver Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 08/11] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 09/11] drm: bridge: dw-mipi-dsi: split low power cfg register into fields Adrian Ratiu
2020-06-10 12:21 ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 10/11] drm: bridge: dw-mipi-dsi: fix bad register field offsets Adrian Ratiu
2020-06-10 12:22 ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 11/11] Documentation: gpu: todo: Add dw-mipi-dsi consolidation plan Adrian Ratiu
2020-06-29 8:47 ` [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver Neil Armstrong
2020-07-01 6:35 ` Adrian Ratiu
2020-07-01 7:50 ` Neil Armstrong
2020-08-15 13:05 ` Ezequiel Garcia
2020-08-24 9:47 ` Neil Armstrong
2020-09-15 13:05 ` Neil Armstrong
2020-10-23 15:32 ` Adrian Ratiu
2020-07-01 12:50 ` Heiko Stübner
2020-07-01 20:32 ` Adrian Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imf7j7sd.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=philippe.cornu@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).