From: Neil Armstrong <narmstrong@baylibre.com>
To: Marek Vasut <marex@denx.de>, dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, ch@denx.de,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Sam Ravnborg <sam@ravnborg.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
Date: Thu, 22 Apr 2021 10:38:40 +0200 [thread overview]
Message-ID: <9ffbea6e-c341-4a43-3c9e-0b177cfe98d5@baylibre.com> (raw)
In-Reply-To: <20210421223122.112736-1-marex@denx.de>
On 22/04/2021 00:31, Marek Vasut wrote:
> Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: Add compatible string for SN65DSI84, since this is now tested on it
> ---
> .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> new file mode 100644
> index 000000000000..42d11b46a1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + Texas Instruments SN65DSI83 1x Single-link MIPI DSI
> + to 1x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi83
> + Texas Instruments SN65DSI84 1x Single-link MIPI DSI
> + to 1x Dual-link or 2x Single-link LVDS
> + https://www.ti.com/lit/gpn/sn65dsi84
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,sn65dsi83
> + - const: ti,sn65dsi84
> +
> + reg:
> + const: 0x2d
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO specifier for bridge_en pin (active high).
> +
> + ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + port@0:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for MIPI DSI input
> +
> + properties:
> + reg:
> + const: 0
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
> + data-lanes:
> + description: array of physical DSI data lane indexes.
> +
> + required:
> + - reg
> +
> + port@1:
> + type: object
> + additionalProperties: false
> +
> + description:
> + Video port for LVDS output (panel or bridge).
> +
> + properties:
> + reg:
> + const: 1
> +
> + endpoint:
> + type: object
> + additionalProperties: false
> + properties:
> + remote-endpoint: true
Similar to Jagan's serie, would be great to add bindings for the dual-link LVDS even if not supported
by the driver (the driver can fails with a verbose error).
Neil
> +
> + required:
> + - reg
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@2d {
> + compatible = "ti,sn65dsi83";
> + reg = <0x2d>;
> +
> + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + endpoint {
> + remote-endpoint = <&dsi0_out>;
> + data-lanes = <1 2 3 4>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + endpoint {
> + remote-endpoint = <&panel_in_lvds>;
> + };
> + };
> + };
> + };
> + };
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-22 8:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 22:31 [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Marek Vasut
2021-04-21 22:31 ` [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver Marek Vasut
2021-04-23 16:03 ` Loic Poulain
2021-04-28 7:51 ` Frieder Schrempf
2021-04-28 8:13 ` Frieder Schrempf
2021-04-28 9:26 ` Loic Poulain
2021-04-28 9:24 ` Neil Armstrong
2021-04-28 9:49 ` Jagan Teki
2021-04-28 14:18 ` Marek Vasut
2021-04-28 14:16 ` Marek Vasut
2021-04-29 16:27 ` Frieder Schrempf
2021-04-30 8:34 ` Neil Armstrong
2021-04-21 22:56 ` [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings Laurent Pinchart
2021-04-22 8:38 ` Neil Armstrong [this message]
2021-04-22 16:16 ` Marek Vasut
2021-04-22 8:43 ` Jagan Teki
2021-04-22 16:22 ` Marek Vasut
2021-04-28 7:56 ` Frieder Schrempf
2021-04-28 14:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ffbea6e-c341-4a43-3c9e-0b177cfe98d5@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=ch@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).