From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Holland <samuel@sholland.org>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
Stephan Gerhold <stephan@gerhold.net>,
Jonas Karlman <jonas@kwiboo.se>, Torsten Duwe <duwe@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
arm-linux <linux-arm-kernel@lists.infradead.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support
Date: Thu, 20 Feb 2020 13:37:40 -0800 [thread overview]
Message-ID: <CA+E=qVcNuYDHaz1WEbDqosEdwqtpte7hzL405LOw0rmraWCzWw@mail.gmail.com> (raw)
In-Reply-To: <20200220135929.GF4998@pendragon.ideasonboard.com>
On Thu, Feb 20, 2020 at 5:59 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Vasily,
Hi Laurent,
>
> Thank you for the patch.
>
> On Thu, Feb 20, 2020 at 12:35:07AM -0800, Vasily Khoruzhick wrote:
> > This commit adds support for the NewEast Optoelectronics CO., LTD
> > WJFH116008A 11.6" 1920x1080 TFT LCD panel.
> >
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 47 ++++++++++++++++++++++++++++
> > 1 file changed, 47 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index e14c14ac62b5..aa04afaf3d26 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2224,6 +2224,50 @@ static const struct panel_desc netron_dy_e231732 = {
> > .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > };
> >
> > +static const struct drm_display_mode neweast_wjfh116008a_modes[] = {
> > +{
> > + .clock = 138500,
> > + .hdisplay = 1920,
> > + .hsync_start = 1920 + 48,
> > + .hsync_end = 1920 + 48 + 32,
> > + .htotal = 1920 + 48 + 32 + 80,
> > + .vdisplay = 1080,
> > + .vsync_start = 1080 + 3,
> > + .vsync_end = 1080 + 3 + 5,
> > + .vtotal = 1080 + 3 + 5 + 23,
> > + .vrefresh = 60,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> > +}, {
> > + .clock = 110920,
> > + .hdisplay = 1920,
> > + .hsync_start = 1920 + 48,
> > + .hsync_end = 1920 + 48 + 32,
> > + .htotal = 1920 + 48 + 32 + 80,
> > + .vdisplay = 1080,
> > + .vsync_start = 1080 + 3,
> > + .vsync_end = 1080 + 3 + 5,
> > + .vtotal = 1080 + 3 + 5 + 23,
> > + .vrefresh = 48,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> > +} };
>
> This should be indented one step to the right, see boe_nv101wxmn51_modes
> for instance.
Will do.
> The only different between the two modes is the clock, leading to
> different refresh rates. Are only those two clock frequencies supported,
> or does the panel support anything in-between as well ? In the latter
> case, would it make sense to use display_timing instead of
> drm_display_mode ? See dlc_dlc0700yzg_1_timing for an example.
These are coming from EDID. The datasheet [1] says typical frequency
is 138.5MHz and min/max are not specified, so I'm not sure whether it
supports anything in between. I did check that both modes work though.
[1] http://files.pine64.org/doc/datasheet/pinebook/11.6inches-1080P-IPS-LCD-Panel-spec-WJFH116008A.pdf
> > +
> > +static const struct panel_desc neweast_wjfh116008a = {
> > + .modes = neweast_wjfh116008a_modes,
> > + .num_modes = 2,
> > + .bpc = 6,
> > + .size = {
> > + .width = 260,
> > + .height = 150,
> > + },
> > + .delay = {
> > + .prepare = 110,
> > + .enable = 20,
> > + .unprepare = 500,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .connector_type = DRM_MODE_CONNECTOR_eDP,
> > +};
> > +
> > static const struct drm_display_mode newhaven_nhd_43_480272ef_atxl_mode = {
> > .clock = 9000,
> > .hdisplay = 480,
> > @@ -3399,6 +3443,9 @@ static const struct of_device_id platform_of_match[] = {
> > }, {
> > .compatible = "netron-dy,e231732",
> > .data = &netron_dy_e231732,
> > + }, {
> > + .compatible = "neweast,wjfh116008a",
> > + .data = &neweast_wjfh116008a,
> > }, {
> > .compatible = "newhaven,nhd-4.3-480272ef-atxl",
> > .data = &newhaven_nhd_43_480272ef_atxl,
>
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-20 21:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:35 [PATCH 0/6] Add LCD support for Pine64 Pinebook 1080p Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick
2020-02-20 13:46 ` Laurent Pinchart
2020-02-21 8:32 ` Neil Armstrong
2020-02-21 11:05 ` Torsten Duwe
2020-02-20 8:35 ` [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe() Vasily Khoruzhick
2020-02-20 13:52 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix Vasily Khoruzhick
2020-02-20 9:35 ` Sam Ravnborg
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 13:56 ` Laurent Pinchart
2020-02-20 21:21 ` Sam Ravnborg
2020-02-20 21:36 ` Vasily Khoruzhick
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 4/6] dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible Vasily Khoruzhick
2020-02-20 13:54 ` Laurent Pinchart
2020-02-20 8:35 ` [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support Vasily Khoruzhick
2020-02-20 13:59 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick [this message]
2020-02-20 8:35 ` [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook Vasily Khoruzhick
2020-02-20 14:17 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E=qVcNuYDHaz1WEbDqosEdwqtpte7hzL405LOw0rmraWCzWw@mail.gmail.com' \
--to=anarsoul@gmail.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duwe@suse.de \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=sfr@canb.auug.org.au \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).