From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Holland <samuel@sholland.org>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
Stephan Gerhold <stephan@gerhold.net>,
Jonas Karlman <jonas@kwiboo.se>, Torsten Duwe <duwe@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime@cerno.tech>,
arm-linux <linux-arm-kernel@lists.infradead.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook
Date: Thu, 20 Feb 2020 13:37:53 -0800 [thread overview]
Message-ID: <CA+E=qVe7vMwK3m-AfTiK+mL=9+rD7dNWjYSXBLgZZnMU1zPeSg@mail.gmail.com> (raw)
In-Reply-To: <20200220141725.GG4998@pendragon.ideasonboard.com>
On Thu, Feb 20, 2020 at 6:17 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Vasily,
Hi Laurent,
> Thank you for the patch.
>
> On Thu, Feb 20, 2020 at 12:35:08AM -0800, Vasily Khoruzhick wrote:
> > From: Icenowy Zheng <icenowy@aosc.io>
> >
> > Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and
> > eDP panel input. The bridge is controlled via I2C that's connected to
> > R_I2C bus.
> >
> > Enable all this hardware in device tree.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> > .../dts/allwinner/sun50i-a64-pinebook.dts | 69 ++++++++++++++++++-
> > 1 file changed, 68 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > index c06c540e6c08..f5633f550d8a 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts
> > @@ -48,6 +48,18 @@ lid_switch {
> > };
> > };
> >
> > + panel_edp: panel-edp {
> > + compatible = "neweast,wjfh116008a";
> > + backlight = <&backlight>;
> > + power-supply = <®_dc1sw>;
> > +
> > + port {
> > + panel_edp_in: endpoint {
> > + remote-endpoint = <&anx6345_out_edp>;
> > + };
> > + };
> > + };
> > +
> > reg_vbklt: vbklt {
> > compatible = "regulator-fixed";
> > regulator-name = "vbklt";
> > @@ -109,6 +121,10 @@ &dai {
> > status = "okay";
> > };
> >
> > +&de {
> > + status = "okay";
> > +};
> > +
> > &ehci0 {
> > phys = <&usbphy 0>;
> > phy-names = "usb";
> > @@ -119,6 +135,10 @@ &ehci1 {
> > status = "okay";
> > };
> >
> > +&mixer0 {
> > + status = "okay";
> > +};
> > +
> > &mmc0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&mmc0_pins>;
> > @@ -177,12 +197,45 @@ &pwm {
> > status = "okay";
> > };
> >
> > -/* The ANX6345 eDP-bridge is on r_i2c */
> > &r_i2c {
> > clock-frequency = <100000>;
> > pinctrl-names = "default";
> > pinctrl-0 = <&r_i2c_pl89_pins>;
> > status = "okay";
> > +
> > + anx6345: anx6345@38 {
> > + compatible = "analogix,anx6345";
> > + reg = <0x38>;
> > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */
> > + dvdd25-supply = <®_dldo2>;
> > + dvdd12-supply = <®_fldo1>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + anx6345_in: port@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > + anx6345_in_tcon0: endpoint@0 {
> > + reg = <0>;
> > + remote-endpoint = <&tcon0_out_anx6345>;
> > + };
>
> As there's a single endpoint, you can drop the reg property, the @0
> suffix, and the #address-cells and #size-cells property in the port@0
> node (but not in the ports node).
Will do
> > + };
> > +
> > + anx6345_out: port@1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > +
> > + anx6345_out_edp: endpoint@0 {
> > + reg = <0>;
> > + remote-endpoint = <&panel_edp_in>;
> > + };
>
> Same here.
Will do
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks for reviewing the series!
>
> > + };
> > + };
> > + };
> > };
> >
> > &r_pio {
> > @@ -357,6 +410,20 @@ &sound {
> > "MIC2", "Internal Microphone Right";
> > };
> >
> > +&tcon0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&lcd_rgb666_pins>;
> > +
> > + status = "okay";
> > +};
> > +
> > +&tcon0_out {
> > + tcon0_out_anx6345: endpoint@0 {
> > + reg = <0>;
> > + remote-endpoint = <&anx6345_in_tcon0>;
> > + };
> > +};
> > +
> > &uart0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&uart0_pb_pins>;
>
> --
> Regards,
>
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-20 21:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:35 [PATCH 0/6] Add LCD support for Pine64 Pinebook 1080p Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators Vasily Khoruzhick
2020-02-20 13:46 ` Laurent Pinchart
2020-02-21 8:32 ` Neil Armstrong
2020-02-21 11:05 ` Torsten Duwe
2020-02-20 8:35 ` [PATCH 2/6] drm/bridge: anx6345: Clean up error handling in probe() Vasily Khoruzhick
2020-02-20 13:52 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix Vasily Khoruzhick
2020-02-20 9:35 ` Sam Ravnborg
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 13:56 ` Laurent Pinchart
2020-02-20 21:21 ` Sam Ravnborg
2020-02-20 21:36 ` Vasily Khoruzhick
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 4/6] dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A compatible Vasily Khoruzhick
2020-02-20 13:54 ` Laurent Pinchart
2020-02-20 8:35 ` [PATCH 5/6] drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A panel support Vasily Khoruzhick
2020-02-20 13:59 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick
2020-02-20 8:35 ` [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook Vasily Khoruzhick
2020-02-20 14:17 ` Laurent Pinchart
2020-02-20 21:37 ` Vasily Khoruzhick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+E=qVe7vMwK3m-AfTiK+mL=9+rD7dNWjYSXBLgZZnMU1zPeSg@mail.gmail.com' \
--to=anarsoul@gmail.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duwe@suse.de \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=sfr@canb.auug.org.au \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).