From: Doug Anderson <dianders@chromium.org>
To: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Cc: quic_kalyant <quic_kalyant@quicinc.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Abhinav Kumar \(QUIC\)" <quic_abhinavk@quicinc.com>,
quic_vproddut <quic_vproddut@quicinc.com>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Stephen Boyd <swboyd@chromium.org>, Sean Paul <sean@poorly.run>,
Sean Paul <seanpaul@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
quic_aravindh@quicinc.com,
"Kuogee Hsieh \(QUIC\)" <quic_khsieh@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus
Date: Thu, 31 Mar 2022 16:22:00 -0700 [thread overview]
Message-ID: <CAD=FV=X+QvjwoT2zGP82KW4kD0oMUY6ZgCizSikNX_Uj8dNDqA@mail.gmail.com> (raw)
In-Reply-To: <1648656179-10347-2-git-send-email-quic_sbillaka@quicinc.com>
Hi,
On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti
<quic_sbillaka@quicinc.com> wrote:
>
> @@ -1547,6 +1593,10 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
>
> dp_display->encoder = encoder;
>
> + ret = dp_display_get_next_bridge(dp_display);
> + if (ret)
> + return ret;
It feels weird to me that this is in a function called "modeset_init",
though I certainly don't know the structure of the MSM display code
well enough to fully comment. My expectation would have been that
devm_of_dp_aux_populate_ep_devices() would have been called from your
probe routine and then you would have returned -EPROBE_DEFER from your
probe if you were unable to find the panel afterwards.
Huh, but I guess you _are_ getting called (indirectly) from
dpu_kms_hw_init() and I can't imagine AUX transfers working before
that function is called, so maybe I should just accept that it's
complicated and let those who understand this driver better confirm
that it's OK. ;-)
> @@ -140,5 +140,6 @@ struct dp_parser {
> * can be parsed using this module.
> */
> struct dp_parser *dp_parser_get(struct platform_device *pdev);
> +int dp_parser_find_next_bridge(struct dp_parser *parser);
Everything else in this file is described w/ kerneldoc. Shouldn't your
function also have a kerneldoc comment?
next prev parent reply other threads:[~2022-03-31 23:22 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 16:02 [PATCH v6 0/8] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-03-30 16:02 ` [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-03-30 23:19 ` Dmitry Baryshkov
2022-03-31 0:33 ` Doug Anderson
2022-03-31 23:22 ` Doug Anderson [this message]
2022-04-02 10:37 ` Dmitry Baryshkov
2022-04-02 17:06 ` Doug Anderson
2022-04-02 20:26 ` Dmitry Baryshkov
2022-04-04 20:53 ` Doug Anderson
2022-04-05 12:53 ` Dmitry Baryshkov
2022-04-05 17:02 ` Doug Anderson
2022-04-05 17:36 ` Dmitry Baryshkov
2022-04-05 18:11 ` Doug Anderson
2022-04-07 14:19 ` Sankeerth Billakanti (QUIC)
2022-04-07 17:07 ` Doug Anderson
2022-04-07 20:11 ` Abhinav Kumar
2022-04-07 20:47 ` Doug Anderson
2022-04-07 22:03 ` Abhinav Kumar
2022-04-07 23:34 ` Doug Anderson
2022-04-07 23:46 ` Dmitry Baryshkov
2022-04-08 0:21 ` Doug Anderson
2022-04-08 12:19 ` Dmitry Baryshkov
2022-04-08 13:43 ` Doug Anderson
2022-04-08 14:58 ` Dmitry Baryshkov
2022-04-08 17:23 ` Abhinav Kumar
2022-04-07 23:35 ` Dmitry Baryshkov
2022-04-08 0:20 ` Doug Anderson
2022-04-08 12:13 ` Dmitry Baryshkov
2022-04-08 13:56 ` Doug Anderson
2022-04-08 14:17 ` Dmitry Baryshkov
2022-03-30 16:02 ` [PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-03-31 23:22 ` Doug Anderson
2022-04-04 12:43 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-03-31 23:22 ` Doug Anderson
2022-04-04 12:56 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts Sankeerth Billakanti
2022-03-30 22:16 ` Dmitry Baryshkov
2022-03-31 5:53 ` Sankeerth Billakanti (QUIC)
2022-03-31 10:10 ` Dmitry Baryshkov
2022-03-31 11:04 ` Sankeerth Billakanti
2022-03-31 11:06 ` Dmitry Baryshkov
2022-04-04 17:56 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson
2022-04-08 16:14 ` Dmitry Baryshkov
2022-04-08 17:12 ` Sankeerth Billakanti
2022-04-08 18:02 ` Dmitry Baryshkov
2022-03-30 16:02 ` [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson
2022-04-04 13:52 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:13 ` Dmitry Baryshkov
2022-04-07 12:40 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd Sankeerth Billakanti
2022-03-31 23:23 ` Doug Anderson
2022-04-04 18:32 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:15 ` Dmitry Baryshkov
2022-04-07 12:41 ` Sankeerth Billakanti (QUIC)
2022-03-30 16:02 ` [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp Sankeerth Billakanti
2022-03-30 22:08 ` Dmitry Baryshkov
2022-03-31 6:02 ` Sankeerth Billakanti (QUIC)
2022-03-31 23:24 ` Doug Anderson
2022-04-04 18:20 ` Sankeerth Billakanti (QUIC)
2022-04-04 21:29 ` Dmitry Baryshkov
2022-04-07 14:05 ` Sankeerth Billakanti (QUIC)
2022-04-08 12:08 ` Dmitry Baryshkov
2022-04-08 15:50 ` Sankeerth Billakanti
2022-04-08 16:47 ` Dmitry Baryshkov
2022-04-08 17:38 ` Sankeerth Billakanti
2022-04-08 18:06 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X+QvjwoT2zGP82KW4kD0oMUY6ZgCizSikNX_Uj8dNDqA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).