From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Douglas Anderson" <dianders@chromium.org>,
"Liu Shixin" <liushixin2@huawei.com>,
"Rob Clark" <robdclark@chromium.org>,
"Vinod Polimera" <quic_vpolimer@quicinc.com>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
"Matt Turner" <mattst88@gmail.com>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
intel-gfx@lists.freedesktop.org,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Sean Paul" <sean@poorly.run>,
"open list" <linux-kernel@vger.kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v10 00/15] dma-fence: Deadline awareness
Date: Thu, 16 Mar 2023 14:22:47 -0700 [thread overview]
Message-ID: <CAF6AEGs1A-3vHtCCam+LfweBNG76TPrpsn8u+RzZ8=sq18yrNg@mail.gmail.com> (raw)
In-Reply-To: <20230308155322.344664-1-robdclark@gmail.com>
On Wed, Mar 8, 2023 at 7:53 AM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> This series adds a deadline hint to fences, so realtime deadlines
> such as vblank can be communicated to the fence signaller for power/
> frequency management decisions.
>
> This is partially inspired by a trick i915 does, but implemented
> via dma-fence for a couple of reasons:
>
> 1) To continue to be able to use the atomic helpers
> 2) To support cases where display and gpu are different drivers
>
> This iteration adds a dma-fence ioctl to set a deadline (both to
> support igt-tests, and compositors which delay decisions about which
> client buffer to display), and a sw_sync ioctl to read back the
> deadline. IGT tests utilizing these can be found at:
>
> https://gitlab.freedesktop.org/robclark/igt-gpu-tools/-/commits/fence-deadline
>
jfwiw, mesa side of this:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21973
BR,
-R
>
> v1: https://patchwork.freedesktop.org/series/93035/
> v2: Move filtering out of later deadlines to fence implementation
> to avoid increasing the size of dma_fence
> v3: Add support in fence-array and fence-chain; Add some uabi to
> support igt tests and userspace compositors.
> v4: Rebase, address various comments, and add syncobj deadline
> support, and sync_file EPOLLPRI based on experience with perf/
> freq issues with clvk compute workloads on i915 (anv)
> v5: Clarify that this is a hint as opposed to a more hard deadline
> guarantee, switch to using u64 ns values in UABI (still absolute
> CLOCK_MONOTONIC values), drop syncobj related cap and driver
> feature flag in favor of allowing count_handles==0 for probing
> kernel support.
> v6: Re-work vblank helper to calculate time of _start_ of vblank,
> and work correctly if the last vblank event was more than a
> frame ago. Add (mostly unrelated) drm/msm patch which also
> uses the vblank helper. Use dma_fence_chain_contained(). More
> verbose syncobj UABI comments. Drop DMA_FENCE_FLAG_HAS_DEADLINE_BIT.
> v7: Fix kbuild complaints about vblank helper. Add more docs.
> v8: Add patch to surface sync_file UAPI, and more docs updates.
> v9: Drop (E)POLLPRI support.. I still like it, but not essential and
> it can always be revived later. Fix doc build warning.
> v10: Update 11/15 to handle multiple CRTCs
>
> Rob Clark (15):
> dma-buf/dma-fence: Add deadline awareness
> dma-buf/fence-array: Add fence deadline support
> dma-buf/fence-chain: Add fence deadline support
> dma-buf/dma-resv: Add a way to set fence deadline
> dma-buf/sync_file: Surface sync-file uABI
> dma-buf/sync_file: Add SET_DEADLINE ioctl
> dma-buf/sw_sync: Add fence deadline support
> drm/scheduler: Add fence deadline support
> drm/syncobj: Add deadline support for syncobj waits
> drm/vblank: Add helper to get next vblank time
> drm/atomic-helper: Set fence deadline for vblank
> drm/msm: Add deadline based boost support
> drm/msm: Add wait-boost support
> drm/msm/atomic: Switch to vblank_start helper
> drm/i915: Add deadline based boost support
>
> Rob Clark (15):
> dma-buf/dma-fence: Add deadline awareness
> dma-buf/fence-array: Add fence deadline support
> dma-buf/fence-chain: Add fence deadline support
> dma-buf/dma-resv: Add a way to set fence deadline
> dma-buf/sync_file: Surface sync-file uABI
> dma-buf/sync_file: Add SET_DEADLINE ioctl
> dma-buf/sw_sync: Add fence deadline support
> drm/scheduler: Add fence deadline support
> drm/syncobj: Add deadline support for syncobj waits
> drm/vblank: Add helper to get next vblank time
> drm/atomic-helper: Set fence deadline for vblank
> drm/msm: Add deadline based boost support
> drm/msm: Add wait-boost support
> drm/msm/atomic: Switch to vblank_start helper
> drm/i915: Add deadline based boost support
>
> Documentation/driver-api/dma-buf.rst | 16 ++++-
> drivers/dma-buf/dma-fence-array.c | 11 ++++
> drivers/dma-buf/dma-fence-chain.c | 12 ++++
> drivers/dma-buf/dma-fence.c | 60 ++++++++++++++++++
> drivers/dma-buf/dma-resv.c | 22 +++++++
> drivers/dma-buf/sw_sync.c | 81 +++++++++++++++++++++++++
> drivers/dma-buf/sync_debug.h | 2 +
> drivers/dma-buf/sync_file.c | 19 ++++++
> drivers/gpu/drm/drm_atomic_helper.c | 37 +++++++++++
> drivers/gpu/drm/drm_syncobj.c | 64 +++++++++++++++----
> drivers/gpu/drm/drm_vblank.c | 53 +++++++++++++---
> drivers/gpu/drm/i915/i915_request.c | 20 ++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 -----
> drivers/gpu/drm/msm/msm_atomic.c | 8 ++-
> drivers/gpu/drm/msm/msm_drv.c | 12 ++--
> drivers/gpu/drm/msm/msm_fence.c | 74 ++++++++++++++++++++++
> drivers/gpu/drm/msm/msm_fence.h | 20 ++++++
> drivers/gpu/drm/msm/msm_gem.c | 5 ++
> drivers/gpu/drm/msm/msm_kms.h | 8 ---
> drivers/gpu/drm/scheduler/sched_fence.c | 46 ++++++++++++++
> drivers/gpu/drm/scheduler/sched_main.c | 2 +-
> include/drm/drm_vblank.h | 1 +
> include/drm/gpu_scheduler.h | 17 ++++++
> include/linux/dma-fence.h | 22 +++++++
> include/linux/dma-resv.h | 2 +
> include/uapi/drm/drm.h | 17 ++++++
> include/uapi/drm/msm_drm.h | 14 ++++-
> include/uapi/linux/sync_file.h | 59 +++++++++++-------
> 28 files changed, 640 insertions(+), 79 deletions(-)
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-16 21:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:52 [PATCH v10 00/15] dma-fence: Deadline awareness Rob Clark
2023-03-08 15:52 ` [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness Rob Clark
2023-03-10 15:45 ` Jonas Ådahl
2023-03-10 17:38 ` Rob Clark
2023-03-15 13:53 ` Jonas Ådahl
2023-03-15 16:19 ` Rob Clark
2023-03-16 9:26 ` Jonas Ådahl
2023-03-16 16:28 ` Rob Clark
2023-03-16 22:22 ` Sebastian Wick
2023-03-16 22:59 ` Rob Clark
2023-03-17 15:07 ` Sebastian Wick
2023-03-17 9:09 ` Pekka Paalanen
2023-03-17 9:17 ` Pekka Paalanen
2023-03-17 9:59 ` Pekka Paalanen
2023-03-17 9:10 ` Michel Dänzer
2023-03-17 10:23 ` Jonas Ådahl
2023-03-17 15:59 ` Rob Clark
2023-03-21 13:24 ` Jonas Ådahl
2023-03-21 14:34 ` Rob Clark
2023-03-08 15:52 ` [PATCH v10 02/15] dma-buf/fence-array: Add fence deadline support Rob Clark
2023-03-08 15:52 ` [PATCH v10 03/15] dma-buf/fence-chain: " Rob Clark
2023-03-08 15:52 ` [PATCH v10 04/15] dma-buf/dma-resv: Add a way to set fence deadline Rob Clark
2023-03-08 15:52 ` [PATCH v10 05/15] dma-buf/sync_file: Surface sync-file uABI Rob Clark
2023-03-08 15:52 ` [PATCH v10 06/15] dma-buf/sync_file: Add SET_DEADLINE ioctl Rob Clark
2023-03-08 15:52 ` [PATCH v10 07/15] dma-buf/sw_sync: Add fence deadline support Rob Clark
2023-03-28 13:57 ` Tvrtko Ursulin
2023-03-08 15:52 ` [PATCH v10 08/15] drm/scheduler: " Rob Clark
2023-03-08 15:53 ` [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits Rob Clark
2023-03-17 19:08 ` [Intel-gfx] " Faith Ekstrand
2023-03-17 19:38 ` Rob Clark
2023-03-18 16:07 ` Rob Clark
2023-03-28 14:24 ` Tvrtko Ursulin
2023-03-08 15:53 ` [PATCH v10 10/15] drm/vblank: Add helper to get next vblank time Rob Clark
2023-03-08 15:53 ` [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank Rob Clark
2023-03-31 20:44 ` Nathan Chancellor
2023-03-31 22:14 ` Rob Clark
2023-03-31 23:30 ` Nathan Chancellor
2023-04-01 15:39 ` Rob Clark
2023-04-04 17:22 ` Dmitry Baryshkov
2023-04-04 19:16 ` Daniel Vetter
2023-04-04 21:53 ` Dmitry Baryshkov
2023-04-05 7:58 ` Daniel Vetter
2023-03-08 15:53 ` [PATCH v10 12/15] drm/msm: Add deadline based boost support Rob Clark
2023-03-08 15:53 ` [PATCH v10 13/15] drm/msm: Add wait-boost support Rob Clark
2023-03-08 15:53 ` [PATCH v10 14/15] drm/msm/atomic: Switch to vblank_start helper Rob Clark
2023-03-08 15:53 ` [PATCH v10 15/15] drm/i915: Add deadline based boost support Rob Clark
2023-03-09 10:21 ` [PATCH v10 00/15] dma-fence: Deadline awareness Pekka Paalanen
2023-03-16 21:22 ` Rob Clark [this message]
2023-03-27 19:05 ` Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6AEGs1A-3vHtCCam+LfweBNG76TPrpsn8u+RzZ8=sq18yrNg@mail.gmail.com' \
--to=robdclark@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=luben.tuikov@amd.com \
--cc=mattst88@gmail.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@chromium.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).