* [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific
@ 2020-03-30 19:15 Pankaj Bharadiya
2020-03-30 19:27 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Pankaj Bharadiya @ 2020-03-30 19:15 UTC (permalink / raw)
To: jani.nikula, daniel, intel-gfx, dri-devel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Jonathan Corbet
Cc: pankaj.laxminarayan.bharadiya
With below commit, we have new struct drm_device based WARN* macros,
which include device specific information in the backtrace.
commit dc1a73e50f9c63d4dd928df538082200467dc4b1
Author: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Date: Wed Jan 15 09:14:45 2020 +0530
drm/print: introduce new struct drm_device based WARN* macros
Majority of the i915 WARN* are already converted to use struct
drm_device specific drm_WARN* calls.Add new todo entry for
pending conversions.
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
Documentation/gpu/todo.rst | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 37a3a023c114..0cb32df89784 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -575,6 +575,18 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
Contact: Harry Wentland, Alex Deucher
+Make i915 WARN* Calls struct drm_device Specific
+------------------------------------------------
+
+struct drm_device specific drm_WARN* macros include device information in the
+backtrace, so we know what device the warnings originate from. Convert all the
+calls of WARN* with drm_WARN* calls in i915. While at it, remove WARN* which
+are not truly valid.
+
+Contact: Jani Nikula
+
+Level: Starter
+
Bootsplash
==========
@@ -595,7 +607,7 @@ Level: Advanced
Outside DRM
===========
-Convert fbdev drivers to DRM
+Convert fbdev drivers to
----------------------------
There are plenty of fbdev drivers for older hardware. Some hwardware has
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific
2020-03-30 19:15 [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific Pankaj Bharadiya
@ 2020-03-30 19:27 ` Sam Ravnborg
2020-03-30 19:29 ` Laxminarayan Bharadiya, Pankaj
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2020-03-30 19:27 UTC (permalink / raw)
To: Pankaj Bharadiya
Cc: Thomas Zimmermann, Jonathan Corbet, David Airlie, intel-gfx, dri-devel
Hi Pankaj.
On Tue, Mar 31, 2020 at 12:45:24AM +0530, Pankaj Bharadiya wrote:
> With below commit, we have new struct drm_device based WARN* macros,
> which include device specific information in the backtrace.
>
> commit dc1a73e50f9c63d4dd928df538082200467dc4b1
> Author: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> Date: Wed Jan 15 09:14:45 2020 +0530
>
> drm/print: introduce new struct drm_device based WARN* macros
>
> Majority of the i915 WARN* are already converted to use struct
> drm_device specific drm_WARN* calls.Add new todo entry for
Add space after '.'
> pending conversions.
>
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
> Documentation/gpu/todo.rst | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 37a3a023c114..0cb32df89784 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -575,6 +575,18 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
>
> Contact: Harry Wentland, Alex Deucher
>
> +Make i915 WARN* Calls struct drm_device Specific
> +------------------------------------------------
> +
> +struct drm_device specific drm_WARN* macros include device information in the
> +backtrace, so we know what device the warnings originate from. Convert all the
> +calls of WARN* with drm_WARN* calls in i915. While at it, remove WARN* which
> +are not truly valid.
> +
> +Contact: Jani Nikula
> +
> +Level: Starter
> +
> Bootsplash
> ==========
>
> @@ -595,7 +607,7 @@ Level: Advanced
> Outside DRM
> ===========
>
> -Convert fbdev drivers to DRM
> +Convert fbdev drivers to
Unrelated change?
Please fix and re-submit.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific
2020-03-30 19:27 ` Sam Ravnborg
@ 2020-03-30 19:29 ` Laxminarayan Bharadiya, Pankaj
0 siblings, 0 replies; 3+ messages in thread
From: Laxminarayan Bharadiya, Pankaj @ 2020-03-30 19:29 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Thomas Zimmermann, Jonathan Corbet, David Airlie, intel-gfx, dri-devel
> -----Original Message-----
> From: Sam Ravnborg <sam@ravnborg.org>
> Sent: 31 March 2020 00:57
> To: Laxminarayan Bharadiya, Pankaj
> <pankaj.laxminarayan.bharadiya@intel.com>
> Cc: jani.nikula@linux.intel.com; daniel@ffwll.ch; intel-
> gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>;
> Thomas Zimmermann <tzimmermann@suse.de>; David Airlie <airlied@linux.ie>;
> Jonathan Corbet <corbet@lwn.net>
> Subject: Re: [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device
> specific
>
> Hi Pankaj.
>
> On Tue, Mar 31, 2020 at 12:45:24AM +0530, Pankaj Bharadiya wrote:
> > With below commit, we have new struct drm_device based WARN* macros,
> > which include device specific information in the backtrace.
> >
> > commit dc1a73e50f9c63d4dd928df538082200467dc4b1
> > Author: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> > Date: Wed Jan 15 09:14:45 2020 +0530
> >
> > drm/print: introduce new struct drm_device based WARN* macros
> >
> > Majority of the i915 WARN* are already converted to use struct
> > drm_device specific drm_WARN* calls.Add new todo entry for
> Add space after '.'
>
> > pending conversions.
> >
> > Signed-off-by: Pankaj Bharadiya
> > <pankaj.laxminarayan.bharadiya@intel.com>
> > ---
> > Documentation/gpu/todo.rst | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> > index 37a3a023c114..0cb32df89784 100644
> > --- a/Documentation/gpu/todo.rst
> > +++ b/Documentation/gpu/todo.rst
> > @@ -575,6 +575,18 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
> >
> > Contact: Harry Wentland, Alex Deucher
> >
> > +Make i915 WARN* Calls struct drm_device Specific
> > +------------------------------------------------
> > +
> > +struct drm_device specific drm_WARN* macros include device
> > +information in the backtrace, so we know what device the warnings
> > +originate from. Convert all the calls of WARN* with drm_WARN* calls
> > +in i915. While at it, remove WARN* which are not truly valid.
> > +
> > +Contact: Jani Nikula
> > +
> > +Level: Starter
> > +
> > Bootsplash
> > ==========
> >
> > @@ -595,7 +607,7 @@ Level: Advanced
> > Outside DRM
> > ===========
> >
> > -Convert fbdev drivers to DRM
> > +Convert fbdev drivers to
> Unrelated change?
>
> Please fix and re-submit.
Ah, my bad. Thanks for pointing out.
Thanks,
Pankaj
>
> Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-30 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 19:15 [PATCH] drm/todo: Add todo to make i915 WARN* calls drm device specific Pankaj Bharadiya
2020-03-30 19:27 ` Sam Ravnborg
2020-03-30 19:29 ` Laxminarayan Bharadiya, Pankaj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).