* [PATCH v2 0/2] drm/msm/dsi: Add support for DSI PHY on QCM2290
@ 2022-09-24 8:51 Dmitry Baryshkov
2022-09-24 8:51 ` [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy Dmitry Baryshkov
2022-09-24 8:51 ` [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 Dmitry Baryshkov
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2022-09-24 8:51 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul,
Abhinav Kumar, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel,
Stephen Boyd, freedreno
The QCM2290 platform uses 14nm DSI PHY. As the configuration is not
fully compatible with the main qcom,dsi-phy-14nm, a separate compatible
is added.
V1 was not sent to freedreno@, so it nearly got missed by me.
Changes since v1:
- Rebased on top of msm-next, fixed DSI PHY config to follow upstream
changes.
- Changed compatible to follow agreed scheme
('qcom,qcm2290-dsi-phy-14nm').
- Updated commit messages.
Loic Poulain (2):
dt-bindings: display/msm: Add QCM2290 DSI phy
drm/msm/dsi: Add phy configuration for QCM2290
.../bindings/display/msm/dsi-phy-14nm.yaml | 1 +
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++
drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 +
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 17 +++++++++++++++++
4 files changed, 21 insertions(+)
--
2.35.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy 2022-09-24 8:51 [PATCH v2 0/2] drm/msm/dsi: Add support for DSI PHY on QCM2290 Dmitry Baryshkov @ 2022-09-24 8:51 ` Dmitry Baryshkov 2022-09-24 9:12 ` Krzysztof Kozlowski 2022-09-24 8:51 ` [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 Dmitry Baryshkov 1 sibling, 1 reply; 7+ messages in thread From: Dmitry Baryshkov @ 2022-09-24 8:51 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno From: Loic Poulain <loic.poulain@linaro.org> QCM2290 platform uses the 14nm DSI PHY driver. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> [DB: changed compat to follow the agreed scheme] Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml index bc3d0b4063c7..088a03ed5f80 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml @@ -17,6 +17,7 @@ properties: - qcom,dsi-phy-14nm - qcom,dsi-phy-14nm-660 - qcom,dsi-phy-14nm-8953 + - qcom,qcm2290-dsi-phy-14nm reg: items: -- 2.35.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy 2022-09-24 8:51 ` [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy Dmitry Baryshkov @ 2022-09-24 9:12 ` Krzysztof Kozlowski 2022-09-24 9:15 ` Dmitry Baryshkov 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-24 9:12 UTC (permalink / raw) To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno On 24/09/2022 10:51, Dmitry Baryshkov wrote: > From: Loic Poulain <loic.poulain@linaro.org> > > QCM2290 platform uses the 14nm DSI PHY driver. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > [DB: changed compat to follow the agreed scheme] Bjorn asked to keep consistency in other case: https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > index bc3d0b4063c7..088a03ed5f80 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > @@ -17,6 +17,7 @@ properties: > - qcom,dsi-phy-14nm > - qcom,dsi-phy-14nm-660 > - qcom,dsi-phy-14nm-8953 > + - qcom,qcm2290-dsi-phy-14nm Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy 2022-09-24 9:12 ` Krzysztof Kozlowski @ 2022-09-24 9:15 ` Dmitry Baryshkov 2022-09-25 7:46 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Baryshkov @ 2022-09-24 9:15 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno On 24/09/2022 12:12, Krzysztof Kozlowski wrote: > On 24/09/2022 10:51, Dmitry Baryshkov wrote: >> From: Loic Poulain <loic.poulain@linaro.org> >> >> QCM2290 platform uses the 14nm DSI PHY driver. >> >> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> >> [DB: changed compat to follow the agreed scheme] > > Bjorn asked to keep consistency in other case: > https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ Ack. Should I use qcom,dsi-phy-14nm-2290 or qcom,dsi-phy-14nm-qcm2290? Note we already have "qcom,sc7280-dsi-phy-10nm". > >> --- >> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> index bc3d0b4063c7..088a03ed5f80 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> @@ -17,6 +17,7 @@ properties: >> - qcom,dsi-phy-14nm >> - qcom,dsi-phy-14nm-660 >> - qcom,dsi-phy-14nm-8953 >> + - qcom,qcm2290-dsi-phy-14nm > Best regards, > Krzysztof > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy 2022-09-24 9:15 ` Dmitry Baryshkov @ 2022-09-25 7:46 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-25 7:46 UTC (permalink / raw) To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno On 24/09/2022 11:15, Dmitry Baryshkov wrote: > On 24/09/2022 12:12, Krzysztof Kozlowski wrote: >> On 24/09/2022 10:51, Dmitry Baryshkov wrote: >>> From: Loic Poulain <loic.poulain@linaro.org> >>> >>> QCM2290 platform uses the 14nm DSI PHY driver. >>> >>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> >>> [DB: changed compat to follow the agreed scheme] >> >> Bjorn asked to keep consistency in other case: >> https://lore.kernel.org/all/20220829210408.gxbv6szxfwiiwrbv@builder.lan/ > > Ack. Should I use qcom,dsi-phy-14nm-2290 or qcom,dsi-phy-14nm-qcm2290? Ugh, no clue, but existing pattern would indicate without qcm. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 2022-09-24 8:51 [PATCH v2 0/2] drm/msm/dsi: Add support for DSI PHY on QCM2290 Dmitry Baryshkov 2022-09-24 8:51 ` [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy Dmitry Baryshkov @ 2022-09-24 8:51 ` Dmitry Baryshkov 2022-09-24 14:44 ` Konrad Dybcio 1 sibling, 1 reply; 7+ messages in thread From: Dmitry Baryshkov @ 2022-09-24 8:51 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno From: Loic Poulain <loic.poulain@linaro.org> The QCM2290 SoC a the 14nm (V2.0) single DSI phy. The platform is not fully compatible with the standard 14nm PHY, so it requires a separate compatible and config entry. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> [DB: changed compat to follow the agreed scheme, rebased and updated commit msg] Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 17 +++++++++++++++++ 3 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 7fc0975cb869..724d5fa0788a 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -553,6 +553,8 @@ static const struct of_device_id dsi_phy_dt_match[] = { .data = &dsi_phy_14nm_660_cfgs }, { .compatible = "qcom,dsi-phy-14nm-8953", .data = &dsi_phy_14nm_8953_cfgs }, + { .compatible = "qcom,qcm2290-dsi-phy-14nm", + .data = &dsi_phy_14nm_2290_cfgs }, #endif #ifdef CONFIG_DRM_MSM_DSI_10NM_PHY { .compatible = "qcom,dsi-phy-10nm", diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h index 60a99c6525b2..1096afedd616 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h @@ -50,6 +50,7 @@ extern const struct msm_dsi_phy_cfg dsi_phy_20nm_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_28nm_8960_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_14nm_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs; +extern const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_10nm_cfgs; extern const struct msm_dsi_phy_cfg dsi_phy_10nm_8998_cfgs; diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c index 0f8f4ca46429..9f488adea7f5 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -1081,3 +1081,20 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { .io_start = { 0x1a94400, 0x1a96400 }, .num_dsi_phy = 2, }; + +const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs = { + .has_phy_lane = true, + .regulator_data = dsi_phy_14nm_17mA_regulators, + .num_regulators = ARRAY_SIZE(dsi_phy_14nm_17mA_regulators), + .ops = { + .enable = dsi_14nm_phy_enable, + .disable = dsi_14nm_phy_disable, + .pll_init = dsi_pll_14nm_init, + .save_pll_state = dsi_14nm_pll_save_state, + .restore_pll_state = dsi_14nm_pll_restore_state, + }, + .min_pll_rate = VCO_MIN_RATE, + .max_pll_rate = VCO_MAX_RATE, + .io_start = { 0x5e94400 }, + .num_dsi_phy = 1, +}; -- 2.35.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 2022-09-24 8:51 ` [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 Dmitry Baryshkov @ 2022-09-24 14:44 ` Konrad Dybcio 0 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2022-09-24 14:44 UTC (permalink / raw) To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring, Krzysztof Kozlowski Cc: devicetree, Loic Poulain, David Airlie, linux-arm-msm, dri-devel, Stephen Boyd, freedreno On 24.09.2022 10:51, Dmitry Baryshkov wrote: > From: Loic Poulain <loic.poulain@linaro.org> > > The QCM2290 SoC a the 14nm (V2.0) single DSI phy. The platform is not > fully compatible with the standard 14nm PHY, so it requires a separate > compatible and config entry. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > [DB: changed compat to follow the agreed scheme, rebased and updated commit msg] > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 17 +++++++++++++++++ > 3 files changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 7fc0975cb869..724d5fa0788a 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -553,6 +553,8 @@ static const struct of_device_id dsi_phy_dt_match[] = { > .data = &dsi_phy_14nm_660_cfgs }, > { .compatible = "qcom,dsi-phy-14nm-8953", > .data = &dsi_phy_14nm_8953_cfgs }, > + { .compatible = "qcom,qcm2290-dsi-phy-14nm", > + .data = &dsi_phy_14nm_2290_cfgs }, > #endif > #ifdef CONFIG_DRM_MSM_DSI_10NM_PHY > { .compatible = "qcom,dsi-phy-10nm", > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > index 60a99c6525b2..1096afedd616 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > @@ -50,6 +50,7 @@ extern const struct msm_dsi_phy_cfg dsi_phy_20nm_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_28nm_8960_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_14nm_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs; > +extern const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_10nm_cfgs; > extern const struct msm_dsi_phy_cfg dsi_phy_10nm_8998_cfgs; > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > index 0f8f4ca46429..9f488adea7f5 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c > @@ -1081,3 +1081,20 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_8953_cfgs = { > .io_start = { 0x1a94400, 0x1a96400 }, > .num_dsi_phy = 2, > }; > + > +const struct msm_dsi_phy_cfg dsi_phy_14nm_2290_cfgs = { > + .has_phy_lane = true, > + .regulator_data = dsi_phy_14nm_17mA_regulators, > + .num_regulators = ARRAY_SIZE(dsi_phy_14nm_17mA_regulators), > + .ops = { > + .enable = dsi_14nm_phy_enable, > + .disable = dsi_14nm_phy_disable, > + .pll_init = dsi_pll_14nm_init, > + .save_pll_state = dsi_14nm_pll_save_state, > + .restore_pll_state = dsi_14nm_pll_restore_state, > + }, > + .min_pll_rate = VCO_MIN_RATE, > + .max_pll_rate = VCO_MAX_RATE, > + .io_start = { 0x5e94400 }, > + .num_dsi_phy = 1, > +}; ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-25 7:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-24 8:51 [PATCH v2 0/2] drm/msm/dsi: Add support for DSI PHY on QCM2290 Dmitry Baryshkov 2022-09-24 8:51 ` [PATCH v2 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy Dmitry Baryshkov 2022-09-24 9:12 ` Krzysztof Kozlowski 2022-09-24 9:15 ` Dmitry Baryshkov 2022-09-25 7:46 ` Krzysztof Kozlowski 2022-09-24 8:51 ` [PATCH v2 2/2] drm/msm/dsi: Add phy configuration for QCM2290 Dmitry Baryshkov 2022-09-24 14:44 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).