dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/dp_mst: make build_clear_payload_id_table return void
@ 2020-03-21 22:29 Maya Rashish
  2020-03-31 20:59 ` Lyude Paul
  0 siblings, 1 reply; 2+ messages in thread
From: Maya Rashish @ 2020-03-21 22:29 UTC (permalink / raw)
  To: dri-devel

Nothing uses the always-0 return value.

Signed-off-by: Maya Rashish <coypu@sdf.org>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 4b255e25e4a1..398da29ba1bd 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1060,13 +1060,12 @@ static void build_link_address(struct drm_dp_sideband_msg_tx *msg)
 	drm_dp_encode_sideband_req(&req, msg);
 }
 
-static int build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg)
+static void build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg)
 {
 	struct drm_dp_sideband_msg_req_body req;
 
 	req.req_type = DP_CLEAR_PAYLOAD_ID_TABLE;
 	drm_dp_encode_sideband_req(&req, msg);
-	return 0;
 }
 
 static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg,
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/dp_mst: make build_clear_payload_id_table return void
  2020-03-21 22:29 [PATCH] drm/dp_mst: make build_clear_payload_id_table return void Maya Rashish
@ 2020-03-31 20:59 ` Lyude Paul
  0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2020-03-31 20:59 UTC (permalink / raw)
  To: Maya Rashish, dri-devel

Reviewed-by: Lyude Paul <lyude@redhat.com>

I'll go ahead and push it to drm-misc-next, thanks!

On Sat, 2020-03-21 at 22:29 +0000, Maya Rashish wrote:
> Nothing uses the always-0 return value.
> 
> Signed-off-by: Maya Rashish <coypu@sdf.org>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 4b255e25e4a1..398da29ba1bd 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1060,13 +1060,12 @@ static void build_link_address(struct
> drm_dp_sideband_msg_tx *msg)
>  	drm_dp_encode_sideband_req(&req, msg);
>  }
>  
> -static int build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg)
> +static void build_clear_payload_id_table(struct drm_dp_sideband_msg_tx
> *msg)
>  {
>  	struct drm_dp_sideband_msg_req_body req;
>  
>  	req.req_type = DP_CLEAR_PAYLOAD_ID_TABLE;
>  	drm_dp_encode_sideband_req(&req, msg);
> -	return 0;
>  }
>  
>  static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg,
-- 
Cheers,
	Lyude Paul (she/her)
	Associate Software Engineer at Red Hat

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-31 20:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-21 22:29 [PATCH] drm/dp_mst: make build_clear_payload_id_table return void Maya Rashish
2020-03-31 20:59 ` Lyude Paul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).