driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: zhengbin <zhengbin13@huawei.com>
To: <gregkh@linuxfoundation.org>, <eric@anholt.net>,
	<wahrenst@gmx.net>, <abbotti@mev.co.uk>,
	<hsweeten@visionengravers.com>, <devel@driverdev.osuosl.org>
Cc: zhengbin13@huawei.com
Subject: [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status'
Date: Tue, 8 Oct 2019 13:38:57 +0800	[thread overview]
Message-ID: <1570513142-60177-2-git-send-email-zhengbin13@huawei.com> (raw)
In-Reply-To: <1570513142-60177-1-git-send-email-zhengbin13@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c: In function audio_vchi_callback:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c:99:6: warning: variable status set but not used [-Wunused-but-set-variable]

It is not used since commit 23b028c871e1 ("staging:
bcm2835-audio: initial staging submission")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
index c6f9cf1..8a94c5b 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -96,13 +96,12 @@ static void audio_vchi_callback(void *param,
 	struct bcm2835_audio_instance *instance = param;
 	struct vc_audio_msg m;
 	int msg_len;
-	int status;

 	if (reason != VCHI_CALLBACK_MSG_AVAILABLE)
 		return;

-	status = vchi_msg_dequeue(instance->vchi_handle,
-				  &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
+	vchi_msg_dequeue(instance->vchi_handle,
+			 &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
 	if (m.type == VC_AUDIO_MSG_TYPE_RESULT) {
 		instance->result = m.result.success;
 		complete(&instance->msg_avail_comp);
--
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-10-08  5:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
2019-10-08  5:38 ` zhengbin [this message]
2019-10-08  6:04   ` [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status' Dan Carpenter
2019-10-08  5:38 ` [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' zhengbin
2019-10-08  6:06   ` Dan Carpenter
2019-10-08  6:08     ` Dan Carpenter
2019-10-08  5:38 ` [PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk' zhengbin
2019-10-08  5:39 ` [PATCH 4/6] staging: comedi: Remove set but not used variable 'data' zhengbin
2019-10-08  5:39 ` [PATCH 5/6] staging: comedi: Remove set but not used variable 'hi' zhengbin
2019-10-08  5:39 ` [PATCH 6/6] staging: comedi: Remove set but not used variable 'aref' zhengbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1570513142-60177-2-git-send-email-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric@anholt.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).