driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: devel@driverdev.osuosl.org, eric@anholt.net,
	gregkh@linuxfoundation.org, abbotti@mev.co.uk, wahrenst@gmx.net
Subject: Re: [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'
Date: Tue, 8 Oct 2019 09:06:11 +0300	[thread overview]
Message-ID: <20191008060610.GB12948@kadam> (raw)
In-Reply-To: <1570513142-60177-3-git-send-email-zhengbin13@huawei.com>

On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 9722692..e0230f4 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter *pModeParam,
>  int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
>  {
>  	struct pll_value pll;
> -	unsigned int uiActualPixelClk;
> 
>  	pll.input_freq = DEFAULT_INPUT_CLOCK;
>  	pll.clock_type = clock;
> 
> -	uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, &pll);
> +	sm750_calc_pll_value(parm->pixel_clock, &pll);

Get rid of this function as well.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-10-08  6:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  5:38 [PATCH 0/6] staging: Remove a bounch set of set but not used variables zhengbin
2019-10-08  5:38 ` [PATCH 1/6] staging: bcm2835-audio: Remove set but not used variable 'status' zhengbin
2019-10-08  6:04   ` Dan Carpenter
2019-10-08  5:38 ` [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk' zhengbin
2019-10-08  6:06   ` Dan Carpenter [this message]
2019-10-08  6:08     ` Dan Carpenter
2019-10-08  5:38 ` [PATCH 3/6] staging: sm750fb: Remove set but not used variable 'actual_mx_clk' zhengbin
2019-10-08  5:39 ` [PATCH 4/6] staging: comedi: Remove set but not used variable 'data' zhengbin
2019-10-08  5:39 ` [PATCH 5/6] staging: comedi: Remove set but not used variable 'hi' zhengbin
2019-10-08  5:39 ` [PATCH 6/6] staging: comedi: Remove set but not used variable 'aref' zhengbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008060610.GB12948@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric@anholt.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=wahrenst@gmx.net \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).