* [PATCH] staging: media: make use of devm_platform_ioremap_resource
@ 2019-10-08 6:55 hariprasad, Kelam, hariprasad.kelam
2019-10-16 9:53 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: hariprasad, Kelam, hariprasad.kelam @ 2019-10-08 6:55 UTC (permalink / raw)
Cc: devel, Hariprasad Kelam, Greg Kroah-Hartman, linux-kernel,
Laurent Pinchart, Mauro Carvalho Chehab, linux-media
From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
fix below issue reported by coccicheck
drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use
devm_platform_ioremap_resource for iss -> regs [ res ]
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index 1a966cb..6fb60b5 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -908,11 +908,7 @@ static int iss_map_mem_resource(struct platform_device *pdev,
struct iss_device *iss,
enum iss_mem_resources res)
{
- struct resource *mem;
-
- mem = platform_get_resource(pdev, IORESOURCE_MEM, res);
-
- iss->regs[res] = devm_ioremap_resource(iss->dev, mem);
+ iss->regs[res] = devm_platform_ioremap_resource(pdev, res);
return PTR_ERR_OR_ZERO(iss->regs[res]);
}
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: make use of devm_platform_ioremap_resource
2019-10-08 6:55 [PATCH] staging: media: make use of devm_platform_ioremap_resource hariprasad, Kelam, hariprasad.kelam
@ 2019-10-16 9:53 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2019-10-16 9:53 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: devel, Greg Kroah-Hartman, Mauro Carvalho Chehab, linux-kernel,
linux-media
Hello Hariprasad,
Thank you for the patch.
As the patch only touches the omap4iss driver, you could have made the
subject line a bit more specific, for instance "staging: media:
omap4iss: Use devm_platform_ioremap_resource". No big deal though.
On Tue, Oct 08, 2019 at 12:25:51PM +0530, hariprasadKelamhariprasad.kelam@gmail.com wrote:
> From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> fix below issue reported by coccicheck
> drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use
> devm_platform_ioremap_resource for iss -> regs [ res ]
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
The change looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree for v5.5.
> ---
> drivers/staging/media/omap4iss/iss.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index 1a966cb..6fb60b5 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -908,11 +908,7 @@ static int iss_map_mem_resource(struct platform_device *pdev,
> struct iss_device *iss,
> enum iss_mem_resources res)
> {
> - struct resource *mem;
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, res);
> -
> - iss->regs[res] = devm_ioremap_resource(iss->dev, mem);
> + iss->regs[res] = devm_platform_ioremap_resource(pdev, res);
>
> return PTR_ERR_OR_ZERO(iss->regs[res]);
> }
--
Regards,
Laurent Pinchart
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 6:55 [PATCH] staging: media: make use of devm_platform_ioremap_resource hariprasad, Kelam, hariprasad.kelam
2019-10-16 9:53 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).