From: <Christian.Gromm@microchip.com>
To: <gregkh@linuxfoundation.org>
Cc: driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH RFC 2/6] staging: most: rename core.h to most.h
Date: Mon, 9 Dec 2019 13:25:17 +0000 [thread overview]
Message-ID: <1575897968.2957.4.camel@microchip.com> (raw)
In-Reply-To: <20191206143528.GA32126@kroah.com>
On Fr, 2019-12-06 at 15:35 +0100, Greg KH wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wrote:
> >
> > This patch renames the core header file core.h to most.h. The
> > intention
> > behind this is to have a meaningful name once this file is moved to
> > the
> > /include/linux directory.
> Does everything in this .h file have to be exposed to the whole
> kernel?
> Are there any things in here that are local only to the most "core"
> code?
>
> If this whole thing is public, you might want to clean up your naming
> of
> some structures:
Yes, those structs are needed by modules registering with the core.
Do you want me to reroll v2 of this set with these changes or to wait
for more comments to come?
thanks,
Chris
>
> >
> > +enum mbo_status_flags {
> enum most_buffer_status_flags?
>
>
> >
> > +struct mbo {
> struct most_buffer_object?
>
> >
> > +struct core_component {
> struct most_core_component?
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-12-09 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 15:51 [PATCH RFC 0/6] staging: most: move core module out of staging area Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 1/6] staging: most: fix improper SPDX-License comment style Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 2/6] staging: most: rename core.h to most.h Christian Gromm
2019-12-06 14:35 ` Greg KH
2019-12-09 13:25 ` Christian.Gromm [this message]
2019-12-10 9:42 ` Greg KH
2019-11-25 15:51 ` [PATCH RFC 3/6] staging: most: use angle brackets in include path Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 4/6] staging: most: move core files out of the staging area Christian Gromm
2019-12-06 14:35 ` Greg KH
2019-11-25 15:51 ` [PATCH RFC 5/6] staging: most: Documentation: update ABI description Christian Gromm
2019-11-25 15:51 ` [PATCH RFC 6/6] staging: most: Documentation: move ABI description files out of staging area Christian Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575897968.2957.4.camel@microchip.com \
--to=christian.gromm@microchip.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).