driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Christian Gromm <christian.gromm@microchip.com>
To: <gregkh@linuxfoundation.org>
Cc: Christian Gromm <christian.gromm@microchip.com>,
	driverdev-devel@linuxdriverproject.org,
	linux-usb@vger.kernel.org
Subject: [PATCH 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS
Date: Thu, 14 May 2020 15:46:28 +0200	[thread overview]
Message-ID: <1589463989-30029-7-git-send-email-christian.gromm@microchip.com> (raw)
In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com>

This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups
instead of defining them manually.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/most/usb/usb.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
index 882f59e..a26e9b1 100644
--- a/drivers/staging/most/usb/usb.c
+++ b/drivers/staging/most/usb/usb.c
@@ -1000,14 +1000,7 @@ static struct attribute *dci_attrs[] = {
 	NULL,
 };
 
-static struct attribute_group dci_attr_group = {
-	.attrs = dci_attrs,
-};
-
-static const struct attribute_group *dci_attr_groups[] = {
-	&dci_attr_group,
-	NULL,
-};
+ATTRIBUTE_GROUPS(dci);
 
 static void release_dci(struct device *dev)
 {
@@ -1160,7 +1153,7 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id)
 
 		mdev->dci->dev.init_name = "dci";
 		mdev->dci->dev.parent = get_device(mdev->iface.dev);
-		mdev->dci->dev.groups = dci_attr_groups;
+		mdev->dci->dev.groups = dci_groups;
 		mdev->dci->dev.release = release_dci;
 		if (device_register(&mdev->dci->dev)) {
 			mutex_unlock(&mdev->io_mutex);
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2020-05-14 13:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 13:46 [PATCH 0/7] staging: most: usb: fix issues found in code audit Christian Gromm
2020-05-14 13:46 ` [PATCH 1/7] staging: most: usb: use dev_*() functions to print messages Christian Gromm
2020-05-14 13:46 ` [PATCH 2/7] staging: most: usb: remove reference to USB error codes Christian Gromm
2020-05-14 14:05   ` Greg KH
2020-05-14 13:46 ` [PATCH 3/7] staging: most: usb: check number of reported endpoints Christian Gromm
2020-05-14 14:06   ` Greg KH
2020-05-14 16:56     ` Christian.Gromm
2020-05-14 13:46 ` [PATCH 4/7] staging: most: usb: use dev_dbg function Christian Gromm
2020-05-14 13:46 ` [PATCH 5/7] staging: most: fix typo in Kconfig Christian Gromm
2020-05-14 13:46 ` Christian Gromm [this message]
2020-05-14 13:46 ` [PATCH 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver Christian Gromm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589463989-30029-7-git-send-email-christian.gromm@microchip.com \
    --to=christian.gromm@microchip.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).