Re: [PATCH] staging: rtl8723bs: core: Drop condition with no effect

Re: [PATCH] staging: rtl8723bs: core: Drop condition with no effect

[Dan Carpenter]

On Sun, Sep 22, 2019 at 08:55:56AM +0530, Saurav Girepunje wrote:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index c6565b0e502c..3f2f9b12cb61 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
>  
>  		cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
>  		if (cmd_process_time > 1000) {
> -			if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
> -				DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 1 sec\n",
> -					ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> -				/* rtw_warn_on(1); */
> -			} else if (pcmd->cmdcode == GEN_CMD_CODE(_Set_MLME_EVT)) {
>  				DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
>  					ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
>  				/* rtw_warn_on(1); */

This is indented too far now.  You may was well delete the /* rtw_warn_on(1); */
line as well.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel