* Re: [PATCH] staging: rtl8723bs: os_dep: Remove unused variable
[not found] <20190922125156.GA31623@saurav>
@ 2019-09-23 14:38 ` Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-09-23 14:38 UTC (permalink / raw)
To: Saurav Girepunje
Cc: , devel, puranjay12, gregkh, linux-kernel, mamtashukla555,
saurav.girepunje, nishkadg.linux, benniciemanuel78,
shobhitkukreti
On Sun, Sep 22, 2019 at 06:22:00PM +0530, Saurav Girepunje wrote:
> Remove unused variable ret from functions rtw_mp_ioctl_hdl,
> rtw_get_ap_info, rtw_mp_efuse_set, rtw_tdls, rtw_tdls_get .
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 90c2997256b7..a51009963295 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2433,8 +2433,7 @@ static int rtw_drvext_hdl(struct net_device *dev, struct iw_request_info *info,
> static int rtw_mp_ioctl_hdl(struct net_device *dev, struct iw_request_info *info,
> union iwreq_data *wrqu, char *extra)
> {
> - int ret = 0;
> - return ret;
> + return 0;
Someone already sent a better patch which just deletes the whole
function.
https://marc.info/?l=linux-kernel&m=156879878226402&w=2
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-23 14:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190922125156.GA31623@saurav>
2019-09-23 14:38 ` [PATCH] staging: rtl8723bs: os_dep: Remove unused variable Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).