* [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file
@ 2019-09-25 7:25 Jerry Lin
2019-09-25 7:33 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Jerry Lin @ 2019-09-25 7:25 UTC (permalink / raw)
To: Jens Frederich, Daniel Drake, Jon Nettleton, Greg Kroah-Hartman,
devel, linux-kernel, Jerry Lin
To allow simultaneous support for XO-1 and XO-1.5.
This module require GPIO_CS5535 (for 1.0) and ACPI (for 1.5) now.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Jerry Lin <wahahab11@gmail.com>
---
drivers/staging/olpc_dcon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
index 4ae271f..c2429e4 100644
--- a/drivers/staging/olpc_dcon/Kconfig
+++ b/drivers/staging/olpc_dcon/Kconfig
@@ -3,7 +3,7 @@ config FB_OLPC_DCON
tristate "One Laptop Per Child Display CONtroller support"
depends on OLPC && FB
depends on I2C
- depends on (GPIO_CS5535 || ACPI)
+ depends on (GPIO_CS5535 && ACPI)
select BACKLIGHT_CLASS_DEVICE
help
In order to support very low power operation, the XO laptop uses a
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file
2019-09-25 7:25 [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file Jerry Lin
@ 2019-09-25 7:33 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-09-25 7:33 UTC (permalink / raw)
To: Jerry Lin
Cc: devel, Daniel Drake, Jens Frederich, Greg Kroah-Hartman,
Jon Nettleton, linux-kernel
On Wed, Sep 25, 2019 at 03:25:33PM +0800, Jerry Lin wrote:
> To allow simultaneous support for XO-1 and XO-1.5.
> This module require GPIO_CS5535 (for 1.0) and ACPI (for 1.5) now.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Jerry Lin <wahahab11@gmail.com>
> ---
> drivers/staging/olpc_dcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
> index 4ae271f..c2429e4 100644
> --- a/drivers/staging/olpc_dcon/Kconfig
> +++ b/drivers/staging/olpc_dcon/Kconfig
> @@ -3,7 +3,7 @@ config FB_OLPC_DCON
> tristate "One Laptop Per Child Display CONtroller support"
> depends on OLPC && FB
> depends on I2C
> - depends on (GPIO_CS5535 || ACPI)
> + depends on (GPIO_CS5535 && ACPI)
Please, remove the parentheses as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-25 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 7:25 [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file Jerry Lin
2019-09-25 7:33 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).