* [PATCH] staging: comedi: Fix camelcase check warning
@ 2019-10-06 18:44 Jules Irenge
2019-10-06 19:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-10-06 18:44 UTC (permalink / raw)
To: outreachy; +Cc: devel, Jules Irenge, gregkh, linux-kernel, abbotti, olsonse
Capitalize unit_ma to fix camelcase check warning.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/comedi/comedi.h | 4 ++--
drivers/staging/comedi/comedidev.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 09a940066c0e..df770043b37d 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -674,7 +674,7 @@ struct comedi_rangeinfo {
* linear (for the purpose of describing the range), with sample value %0
* mapping to @min, and the 'maxdata' sample value mapping to @max.
*
- * The currently defined units are %UNIT_volt (%0), %UNIT_mA (%1), and
+ * The currently defined units are %UNIT_volt (%0), %UNIT_MA (%1), and
* %UNIT_none (%2). The @min and @max values are the physical range multiplied
* by 1e6, so a @max value of %1000000 (with %UNIT_volt) represents a maximal
* value of 1 volt.
@@ -909,7 +909,7 @@ struct comedi_bufinfo {
#define RF_EXTERNAL 0x100
#define UNIT_volt 0
-#define UNIT_mA 1
+#define UNIT_MA 1
#define UNIT_none 2
#define COMEDI_MIN_SPEED 0xffffffffu
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 0dff1ac057cd..54c091866777 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
#define RANGE(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
+#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
#define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
#define UNI_RANGE(a) {0, (a) * 1e6, 0}
--
2.21.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: Fix camelcase check warning
2019-10-06 18:44 [PATCH] staging: comedi: Fix camelcase check warning Jules Irenge
@ 2019-10-06 19:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-10-06 19:08 UTC (permalink / raw)
To: Jules Irenge; +Cc: devel, abbotti, outreachy, linux-kernel, olsonse
On Sun, Oct 06, 2019 at 07:44:53PM +0100, Jules Irenge wrote:
> Capitalize unit_ma to fix camelcase check warning.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/comedi/comedi.h | 4 ++--
> drivers/staging/comedi/comedidev.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 09a940066c0e..df770043b37d 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -674,7 +674,7 @@ struct comedi_rangeinfo {
> * linear (for the purpose of describing the range), with sample value %0
> * mapping to @min, and the 'maxdata' sample value mapping to @max.
> *
> - * The currently defined units are %UNIT_volt (%0), %UNIT_mA (%1), and
> + * The currently defined units are %UNIT_volt (%0), %UNIT_MA (%1), and
> * %UNIT_none (%2). The @min and @max values are the physical range multiplied
> * by 1e6, so a @max value of %1000000 (with %UNIT_volt) represents a maximal
> * value of 1 volt.
> @@ -909,7 +909,7 @@ struct comedi_bufinfo {
> #define RF_EXTERNAL 0x100
>
> #define UNIT_volt 0
> -#define UNIT_mA 1
> +#define UNIT_MA 1
Sorry, but "mA" is a unit of measurement of power, and needs to stay
as-is.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-06 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-06 18:44 [PATCH] staging: comedi: Fix camelcase check warning Jules Irenge
2019-10-06 19:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).