* [PATCH] staging:rtl8723bs: removed unwanted if..else condition
@ 2019-10-16 14:07 Aliasgar Surti
2019-10-16 14:59 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Aliasgar Surti @ 2019-10-16 14:07 UTC (permalink / raw)
To: gregkh, devel; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
There is use of if..elseif..else condition which has same logic
in all three blocks.
Removed if..else block and placed log message instead that.
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index e6fea96..fc1d243 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
if (cmd_process_time > 1000) {
- if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
- DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 1 sec\n",
- ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
- /* rtw_warn_on(1); */
- } else if (pcmd->cmdcode == GEN_CMD_CODE(_Set_MLME_EVT)) {
- DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
- ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
- /* rtw_warn_on(1); */
- } else {
- DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
- ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
- /* rtw_warn_on(1); */
- }
+ DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
+ ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
+ cmd_process_time);
}
/* call callback function for post-processed */
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:rtl8723bs: removed unwanted if..else condition
2019-10-16 14:07 [PATCH] staging:rtl8723bs: removed unwanted if..else condition Aliasgar Surti
@ 2019-10-16 14:59 ` Dan Carpenter
2019-10-17 14:10 ` Aliasgar Surti
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-10-16 14:59 UTC (permalink / raw)
To: Aliasgar Surti; +Cc: devel, gregkh
On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote:
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
>
> cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
> if (cmd_process_time > 1000) {
> - if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
> - DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 1 sec\n",
> - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> - /* rtw_warn_on(1); */
> - } else if (pcmd->cmdcode == GEN_CMD_CODE(_Set_MLME_EVT)) {
> - DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
> - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> - /* rtw_warn_on(1); */
> - } else {
> - DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
> - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> - /* rtw_warn_on(1); */
> - }
> + DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
> + ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
> + cmd_process_time);
This last line is aligned to the wrong parenthesis. It should be:
DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
cmd_process_time);
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:rtl8723bs: removed unwanted if..else condition
2019-10-16 14:59 ` Dan Carpenter
@ 2019-10-17 14:10 ` Aliasgar Surti
0 siblings, 0 replies; 3+ messages in thread
From: Aliasgar Surti @ 2019-10-17 14:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: devel, gregkh
On Wed, Oct 16, 2019 at 05:59:50PM +0300, Dan Carpenter wrote:
> On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote:
> > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> > @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
> >
> > cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
> > if (cmd_process_time > 1000) {
> > - if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
> > - DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 1 sec\n",
> > - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> > - /* rtw_warn_on(1); */
> > - } else if (pcmd->cmdcode == GEN_CMD_CODE(_Set_MLME_EVT)) {
> > - DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
> > - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> > - /* rtw_warn_on(1); */
> > - } else {
> > - DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 1 sec\n",
> > - ADPT_ARG(pcmd->padapter), pcmd->cmdcode, cmd_process_time);
> > - /* rtw_warn_on(1); */
> > - }
> > + DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
> > + ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
> > + cmd_process_time);
>
> This last line is aligned to the wrong parenthesis. It should be:
>
> DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
> ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
> cmd_process_time);
My bad. I will correct this and send v2.
Thanks,
Aliasgar
>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 14:07 [PATCH] staging:rtl8723bs: removed unwanted if..else condition Aliasgar Surti
2019-10-16 14:59 ` Dan Carpenter
2019-10-17 14:10 ` Aliasgar Surti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).