* [PATCH] staging: octeon: fix missing a blank line after declaration
@ 2019-11-07 14:13 Valery Ivanov
2019-11-07 14:22 ` Greg Kroah-Hartman
2019-11-07 16:12 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Valery Ivanov @ 2019-11-07 14:13 UTC (permalink / raw)
To: devel, linux-kernel
Cc: Valery Ivanov, Greg Kroah-Hartman, devel, Matthew Wilcox (Oracle),
Wambui Karuga
This patch fixes "WARNING: Missing a blank line after declarations"
Issue found by checkpatch.pl
Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
---
drivers/staging/octeon/octeon-stubs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index d53bd801f440..ed9d44ff148b 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1375,6 +1375,7 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
int port)
{
union cvmx_gmxx_rxx_rx_inbnd r;
+
r.u64 = 0;
return r;
}
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: octeon: fix missing a blank line after declaration
2019-11-07 14:13 [PATCH] staging: octeon: fix missing a blank line after declaration Valery Ivanov
@ 2019-11-07 14:22 ` Greg Kroah-Hartman
2019-11-07 16:12 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-11-07 14:22 UTC (permalink / raw)
To: Valery Ivanov
Cc: devel, devel, linux-kernel, Matthew Wilcox (Oracle), Wambui Karuga
On Thu, Nov 07, 2019 at 02:13:22PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
Why the huge indentation?
Please fix that up and send a v2.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: octeon: fix missing a blank line after declaration
2019-11-07 14:13 [PATCH] staging: octeon: fix missing a blank line after declaration Valery Ivanov
2019-11-07 14:22 ` Greg Kroah-Hartman
@ 2019-11-07 16:12 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-11-07 16:12 UTC (permalink / raw)
To: Valery Ivanov
Cc: devel, devel, Greg Kroah-Hartman, linux-kernel,
Matthew Wilcox (Oracle),
Wambui Karuga
On Thu, Nov 07, 2019 at 02:13:22PM +0000, Valery Ivanov wrote:
> This patch fixes "WARNING: Missing a blank line after declarations"
> Issue found by checkpatch.pl
I think maybe you are cutting and pasting from git log output or
something? Anyway, please don't indent your commit message like this.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-07 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 14:13 [PATCH] staging: octeon: fix missing a blank line after declaration Valery Ivanov
2019-11-07 14:22 ` Greg Kroah-Hartman
2019-11-07 16:12 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).