From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, John Joseph <jnjoseph@google.com>,
linux-kernel@vger.kernel.org, Simon Que <sque@chromium.org>,
rspringer@google.com, Valery Ivanov <ivalery111@gmail.com>,
toddpoynor@google.com
Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
Date: Thu, 7 Nov 2019 16:09:16 +0100 [thread overview]
Message-ID: <20191107150916.GB154681@kroah.com> (raw)
In-Reply-To: <e3ee9e75d7c25e2d25b74fd1d4709f8dacb79efc.camel@perches.com>
On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote:
> On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> > This patch fix the function signature for trace_gasket_ioctl_page_table_data
> > to avoid the checkpatch.pl warning:
> >
> > CHECK: Lines should not end with a '('
> >
> > Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
>
> All of this stuff is no-op and could just as easily be removed
> completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.
>
> Is the actual trace #include file supposed to be available somewhere?
>
> #ifdef GASKET_KERNEL_TRACE_SUPPORT
> #define CREATE_TRACE_POINTS
> #include <trace/events/gasket_ioctl.h>
> #else
> #define trace_gasket_ioctl_entry(x, ...)
> #define trace_gasket_ioctl_exit(x)
> #define trace_gasket_ioctl_integer_data(x)
> #define trace_gasket_ioctl_eventfd_data(x, ...)
> #define trace_gasket_ioctl_page_table_data(x, ...)
> #define trace_gasket_ioctl_config_coherent_allocator(x, ...)
> #endif
>
> trace file not found...
I'm thinking the whole gasket driver should be deleted as there has not
been any effort done to fix it up and get it out of staging. I'll give
it until 5.5 before I drop it...
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-07 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:08 [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Valery Ivanov
2019-11-06 19:12 ` Joe Perches
2019-11-07 15:09 ` Greg KH [this message]
2019-11-07 15:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107150916.GB154681@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=ivalery111@gmail.com \
--cc=jnjoseph@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sque@chromium.org \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).