From: Dan Carpenter <dan.carpenter@oracle.com>
To: Giovanni Gherdovich <bobdc9664@seznam.cz>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] staging: octeon: indent with tabs instead of spaces
Date: Mon, 18 Nov 2019 22:01:28 +0300 [thread overview]
Message-ID: <20191118190018.GA5604@kadam> (raw)
In-Reply-To: <20191118183852.3699-1-bobdc9664@seznam.cz>
On Mon, Nov 18, 2019 at 07:38:52PM +0100, Giovanni Gherdovich wrote:
> Remove a coding style error from the Octeon driver's tree and keep
> checkpatch.pl a little quieter.
>
> Being a white-spaces patch the chances of breakage are minimal; we don't
> have the hardware to run this driver so we built it with COMPILE_TEST
> enabled on an x86 machine.
Next time put this sort of comment under the --- cut off line so that we
sound like we're bursting with confidence in the permanent git log. ;)
>
> Signed-off-by: Giovanni Gherdovich <bobdc9664@seznam.cz>
> ---
^^^
> drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-18 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 18:38 [PATCH] staging: octeon: indent with tabs instead of spaces Giovanni Gherdovich
2019-11-18 19:01 ` Dan Carpenter [this message]
2020-07-22 17:19 [PATCH] staging: octeon: Indent " Muhammad Usama Anjum
2020-07-22 19:56 ` Joe Perches
2020-07-24 10:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118190018.GA5604@kadam \
--to=dan.carpenter@oracle.com \
--cc=aaro.koskinen@iki.fi \
--cc=bobdc9664@seznam.cz \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).