From: Dan Carpenter <dan.carpenter@oracle.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Subject: Re: [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.
Date: Fri, 3 Jan 2020 14:09:51 +0300 [thread overview]
Message-ID: <20200103110950.GE3911@kadam> (raw)
In-Reply-To: <072ec0b3-425f-277e-130c-1e3a116c90d6@gmail.com>
On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> The driver standard error returns remove bool false conditions.
>
> Cc: stable <stable@vger.kernel.org> # v5.3+
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")
The other part of that bug was fixed silently in commit 987d864a2363
("staging: vt6656: manage error path during device initialization").
I'm quite embarrassed that I didn't catch these during review... It's
the obvious bug right? "You have reversed the return values but not
updated any of the callers." *Egg on my face*.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-01-03 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 21:15 [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers Malcolm Priestley
2020-01-03 11:09 ` Dan Carpenter [this message]
2020-01-06 22:02 ` Quentin Deslandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103110950.GE3911@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=quentin.deslandes@itdev.co.uk \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).