[PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

[PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

[Malcolm Priestley]

The driver standard error returns remove bool false conditions.

Cc: stable <stable@vger.kernel.org> # v5.3+
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 4ac85ecb0921..4a5d741f94f5 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -949,7 +949,7 @@ static const struct ieee80211_ops vnt_mac_ops = {
 
 int vnt_init(struct vnt_private *priv)
 {
-	if (!(vnt_init_registers(priv)))
+	if (vnt_init_registers(priv))
 		return -EAGAIN;
 
 	SET_IEEE80211_PERM_ADDR(priv->hw, priv->permanent_net_addr);
-- 
2.24.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

[Dan Carpenter]

On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> The driver standard error returns remove bool false conditions.
> 
> Cc: stable <stable@vger.kernel.org> # v5.3+
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>

Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")

The other part of that bug was fixed silently in commit 987d864a2363
("staging: vt6656: manage error path during device initialization").
I'm quite embarrassed that I didn't catch these during review...  It's
the obvious bug right?  "You have reversed the return values but not
updated any of the callers."  *Egg on my face*.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

[Quentin Deslandes]

On 01/03/20 14:09:51, Dan Carpenter wrote:
> On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> > The driver standard error returns remove bool false conditions.
> > 
> > Cc: stable <stable@vger.kernel.org> # v5.3+
> > Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> 
> Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")
> 
> The other part of that bug was fixed silently in commit 987d864a2363
> ("staging: vt6656: manage error path during device initialization").
> I'm quite embarrassed that I didn't catch these during review...  It's
> the obvious bug right?  "You have reversed the return values but not
> updated any of the callers."  *Egg on my face*.
> 
> regards,
> dan carpenter
> 

That one is ugly, my bad.

The fix looks good to me, and as Dan said the other part has already
been fixed.

Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>

Regards,
Quentin Deslandes
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel