From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matej Dujava <mdujava@kocurkovo.cz>
Cc: devel@driverdev.osuosl.org,
Forest Bond <forest@alittletooquiet.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
Date: Fri, 15 May 2020 15:48:59 +0200 [thread overview]
Message-ID: <20200515134859.GA2112248@kroah.com> (raw)
In-Reply-To: <1589397351-24655-3-git-send-email-mdujava@kocurkovo.cz>
On Wed, May 13, 2020 at 09:15:51PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put
> obj-$(CONFIG_X) at the beginning of the file. This order of variables is
> used in other drives, so this will make vt665x Makefiles fit into the
> pattern.
>
> Indentation is fixed in vt6655/Makefile.
>
> Order of variable declaration is changed in vt6656/Makefile.
>
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
> v1: Initial patch
> v2: This patch was split from original bigger patch
> v3: Added more info about what and why it's removed
>
> drivers/staging/vt6655/Makefile | 24 ++++++++++++------------
> drivers/staging/vt6656/Makefile | 4 ++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
> index e70357ec0af8..eda08a1516ab 100644
> --- a/drivers/staging/vt6655/Makefile
> +++ b/drivers/staging/vt6655/Makefile
> @@ -1,15 +1,15 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -vt6655_stage-y += device_main.o \
> - card.o \
> - channel.o \
> - mac.o \
> - baseband.o \
> - rxtx.o \
> - dpc.o \
> - power.o \
> - srom.o \
> - key.o \
> - rf.o
> -
> obj-$(CONFIG_VT6655) += vt6655_stage.o
> +
> +vt6655_stage-y += device_main.o \
> + card.o \
> + channel.o \
> + mac.o \
> + baseband.o \
> + rxtx.o \
> + dpc.o \
> + power.o \
> + srom.o \
> + key.o \
> + rf.o
> diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
> index f696a9d7a143..aac323d6a684 100644
> --- a/drivers/staging/vt6656/Makefile
> +++ b/drivers/staging/vt6656/Makefile
> @@ -1,5 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
>
> +obj-$(CONFIG_VT6656) += vt6656_stage.o
> +
> vt6656_stage-y += main_usb.o \
> card.o \
> mac.o \
> @@ -11,5 +13,3 @@ vt6656_stage-y += main_usb.o \
> rf.o \
> usbpipe.o \
> channel.o
> -
> -obj-$(CONFIG_VT6656) += vt6656_stage.o
I still fail to understand the need for this patch at all. It doesn't
clean anything up, nor change anything. There is no rule that this has
to be in one order or the other, and in fact, I like the order that the
files currently have :)
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-15 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 19:15 [PATCH v3 0/2] staging: vt6656: vt6655: cleaning Makefile Matej Dujava
2020-05-13 19:15 ` [PATCH v3 1/2] staging: vt6656: vt6655: removing unused macros definition Makefiles Matej Dujava
2020-05-13 19:15 ` [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions Matej Dujava
2020-05-15 13:48 ` Greg Kroah-Hartman [this message]
2020-05-15 14:55 ` Matej Dujava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515134859.GA2112248@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mdujava@kocurkovo.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).