From: Nicolas Boichat <drinkcat@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Peter Chen <peter.chen@nxp.com>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Rafael Aquini <aquini@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Todor Tomov <todor.too@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Howells <dhowells@redhat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Will Deacon <will@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Kees Cook <keescook@chromium.org>,
devel@driverdev.osuosl.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Nicolas Boichat <drinkcat@chromium.org>,
Jayshri Pawar <jpawar@cadence.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Andy Gross <agross@kernel.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-media@vger.kernel.org, Pawel Laszczak <pawell@cadence.com>,
Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Chao Yu <chao@kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Roger Quadros <rogerq@ti.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Colin Ian King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Divya Indi <divya.indi@oracle.com>
Subject: [PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only
Date: Sat, 27 Jun 2020 15:03:06 +0800 [thread overview]
Message-ID: <20200627070307.516803-4-drinkcat@chromium.org> (raw)
In-Reply-To: <20200627070307.516803-1-drinkcat@chromium.org>
trace_printk should not be used in production code. Since
tracing interrupts is presumably latency sensitive, pr_dbg is
not appropriate, so guard the call with a preprocessor symbol
that can be defined for debugging purpose.
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 2 ++
drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
index 174a36be6f5d866..0c57171fae4f9e9 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
@@ -936,8 +936,10 @@ static irqreturn_t vfe_isr(int irq, void *dev)
vfe->ops->isr_read(vfe, &value0, &value1);
+#ifdef CAMSS_VFE_TRACE_IRQ
trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
value0, value1);
+#endif
if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
vfe->isr_ops.reset_ack(vfe);
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
index 0dca8bf9281e774..307675925e5c779 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
@@ -1058,8 +1058,10 @@ static irqreturn_t vfe_isr(int irq, void *dev)
vfe->ops->isr_read(vfe, &value0, &value1);
+#ifdef CAMSS_VFE_TRACE_IRQ
trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
value0, value1);
+#endif
if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
vfe->isr_ops.reset_ack(vfe);
--
2.27.0.212.ge8ba1cc988-goog
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-06-27 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 7:03 [PATCH 0/4] Detect and remove trace_printk Nicolas Boichat
2020-06-27 7:03 ` [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg Nicolas Boichat
2020-06-29 3:31 ` Peter Chen
2020-07-23 13:17 ` Felipe Balbi
2020-07-24 0:17 ` Nicolas Boichat
2020-07-24 7:53 ` Felipe Balbi
2020-06-27 7:03 ` [PATCH 2/4] media: atomisp: Replace trace_printk by pr_info Nicolas Boichat
2020-06-27 7:03 ` Nicolas Boichat [this message]
2020-06-27 7:03 ` [PATCH v2 4/4] kernel/trace: Add TRACING_ALLOW_PRINTK config option Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627070307.516803-4-drinkcat@chromium.org \
--to=drinkcat@chromium.org \
--cc=adobriyan@gmail.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chao@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=divya.indi@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gpiccoli@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jaegeuk@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jpawar@cadence.com \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rodrigo.vivi@intel.com \
--cc=rogerq@ti.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=todor.too@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=will@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).