From: Felipe Balbi <balbi@kernel.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Peter Chen <peter.chen@nxp.com>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Rafael Aquini <aquini@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Todor Tomov <todor.too@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Howells <dhowells@redhat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Will Deacon <will@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Kees Cook <keescook@chromium.org>,
devel@driverdev.osuosl.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jayshri Pawar <jpawar@cadence.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Andy Gross <agross@kernel.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Daniel Vetter <daniel@ffwll.ch>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Chao Yu <chao@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Roger Quadros <rogerq@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-usb@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Colin Ian King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Divya Indi <divya.indi@oracle.com>
Subject: Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg
Date: Fri, 24 Jul 2020 10:53:36 +0300 [thread overview]
Message-ID: <87365hnybj.fsf@kernel.org> (raw)
In-Reply-To: <CANMq1KDugXcmvrGOJzcvWvbzScPDsQVuJ4gSDXTJan+FY1H3Ew@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1888 bytes --]
Nicolas Boichat <drinkcat@chromium.org> writes:
> On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Nicolas Boichat <drinkcat@chromium.org> writes:
>>
>> > trace_printk should not be used in production code, replace it
>> > call with dev_dbg.
>> >
>> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>> >
>> > ---
>> >
>> > Unclear why a trace_printk was used in the first place, it's
>> > possible that some rate-limiting is necessary here.
>> >
>> > drivers/usb/cdns3/gadget.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>> > index 5e24c2e57c0d8c8..c303ab7c62d1651 100644
>> > --- a/drivers/usb/cdns3/gadget.c
>> > +++ b/drivers/usb/cdns3/gadget.c
>> > @@ -421,7 +421,7 @@ static int cdns3_start_all_request(struct cdns3_device *priv_dev,
>> > if ((priv_req->flags & REQUEST_INTERNAL) ||
>> > (priv_ep->flags & EP_TDLCHK_EN) ||
>> > priv_ep->use_streams) {
>> > - trace_printk("Blocking external request\n");
>> > + dev_dbg(priv_dev->dev, "Blocking external request\n");
>>
>> Instead, I would suggest adding a proper trace event here; one that
>> includes "priv_ep->flags" in the output.
>
> The patch was already merged by Greg
> (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/cdns3/gadget.c?id=b3a5ce874c2619c9b8a6c5bbcfefdb95e0227600),
> but feel free to do that as a follow-up CL.
>
> Looks like Peter -- the main author, is ok with dev_dbg (also,
> apologies for missing the R-b tag when I sent a v2 -- which is the one
> that was merged by Greg).
That's okay, we can get a proper trace event for v5.10. Maybe Pawel or
Roger would like to take the effort?
--
balbi
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-24 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 7:03 [PATCH 0/4] Detect and remove trace_printk Nicolas Boichat
2020-06-27 7:03 ` [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg Nicolas Boichat
2020-06-29 3:31 ` Peter Chen
2020-07-23 13:17 ` Felipe Balbi
2020-07-24 0:17 ` Nicolas Boichat
2020-07-24 7:53 ` Felipe Balbi [this message]
2020-06-27 7:03 ` [PATCH 2/4] media: atomisp: Replace trace_printk by pr_info Nicolas Boichat
2020-06-27 7:03 ` [PATCH 3/4] media: camss: vfe: Use trace_printk for debugging only Nicolas Boichat
2020-06-27 7:03 ` [PATCH v2 4/4] kernel/trace: Add TRACING_ALLOW_PRINTK config option Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87365hnybj.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=adobriyan@gmail.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=chao@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=divya.indi@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=gpiccoli@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jaegeuk@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jpawar@cadence.com \
--cc=keescook@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rodrigo.vivi@intel.com \
--cc=rogerq@ti.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=todor.too@gmail.com \
--cc=tomas.winkler@intel.com \
--cc=will@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).