[PATCH] Staging: rtl8188eu: core: Fix coding style issue

[PATCH] Staging: rtl8188eu: core: Fix coding style issue

[Anoop1507]

From: Anoop S <anoop.skumar1507@gmail.com>

This fixes the following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string.

Signed-off-by: Anoop S <anoop.skumar1507@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index 435c0fbec54a..ece5291ce7c0 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
 				res = _FAIL;
 			}
 		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("rtw_tkip_decrypt: stainfo==NULL!!!\n"));
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
 			res = _FAIL;
 		}
 	}
-- 
2.27.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: rtl8188eu: core: Fix coding style issue

[Greg KH]

On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> From: Anoop S <anoop.skumar1507@gmail.com>
> 
> This fixes the following checkpatch.pl warning
> WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string.
> 
> Signed-off-by: Anoop S <anoop.skumar1507@gmail.com>

It would be great to have your full name here, is that how you sign
legal documents?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: rtl8188eu: core: Fix coding style issue

[Anoop S]

On Sun, Jul 19, 2020 at 11:24:37AM +0200, Greg KH wrote:
> On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> > From: Anoop S <anoop.skumar1507@gmail.com>
> > 
> > This fixes the following checkpatch.pl warning
> > WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this function's name, in a string.
> > 
> > Signed-off-by: Anoop S <anoop.skumar1507@gmail.com>
> 
> It would be great to have your full name here, is that how you sign
> legal documents?
> 
> thanks,
> 
> greg k-h

Hi ,

My full name is Anoop S .

Thanks for reviewing, this my first kernel patch .
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel