* [PATCH] change slave occurence to secondary everywhere
@ 2020-07-23 14:58 Rohit K Bharadwaj
2020-07-23 15:09 ` Greg KH
2020-07-24 14:06 ` Dan Carpenter
0 siblings, 2 replies; 7+ messages in thread
From: Rohit K Bharadwaj @ 2020-07-23 14:58 UTC (permalink / raw)
To: marvin24, gregkh, p.zabel; +Cc: linux-tegra, Rohit K Bharadwaj, devel, ac100
Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
---
drivers/staging/nvec/nvec.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
return IRQ_HANDLED;
}
-static void tegra_init_i2c_slave(struct nvec_chip *nvec)
+static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
{
u32 val;
@@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
}
#ifdef CONFIG_PM_SLEEP
-static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
+static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
{
disable_irq(nvec->irq);
writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
@@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, nvec);
nvec->dev = dev;
- if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
+ if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
dev_err(dev, "no i2c address specified");
return -ENODEV;
}
@@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
}
disable_irq(nvec->irq);
- tegra_init_i2c_slave(nvec);
+ tegra_init_i2c_secondary(nvec);
/* enable event reporting */
nvec_toggle_global_events(nvec, true);
@@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
if (!err)
nvec_msg_free(nvec, msg);
- nvec_disable_i2c_slave(nvec);
+ nvec_disable_i2c_secondary(nvec);
return 0;
}
@@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
struct nvec_chip *nvec = dev_get_drvdata(dev);
dev_dbg(nvec->dev, "resuming\n");
- tegra_init_i2c_slave(nvec);
+ tegra_init_i2c_secondary(nvec);
nvec_toggle_global_events(nvec, true);
return 0;
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] change slave occurence to secondary everywhere
2020-07-23 14:58 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
@ 2020-07-23 15:09 ` Greg KH
2020-07-24 14:06 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2020-07-23 15:09 UTC (permalink / raw)
To: Rohit K Bharadwaj; +Cc: linux-tegra, devel, ac100, p.zabel
On Thu, Jul 23, 2020 at 08:28:11PM +0530, Rohit K Bharadwaj wrote:
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
I can't take patches without any changelog text :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] change slave occurence to secondary everywhere
2020-07-23 14:58 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 15:09 ` Greg KH
@ 2020-07-24 14:06 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2020-07-24 14:06 UTC (permalink / raw)
To: Rohit K Bharadwaj; +Cc: devel, gregkh, marvin24, p.zabel, linux-tegra, ac100
On Thu, Jul 23, 2020 at 08:28:11PM +0530, Rohit K Bharadwaj wrote:
> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
> {
> disable_irq(nvec->irq);
> writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, nvec);
> nvec->dev = dev;
>
> - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> + if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
This change will break the driver.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] change slave occurence to secondary everywhere
@ 2020-07-23 15:15 Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
2020-07-24 14:07 ` Dan Carpenter
0 siblings, 2 replies; 7+ messages in thread
From: Rohit K Bharadwaj @ 2020-07-23 15:15 UTC (permalink / raw)
To: marvin24, gregkh, p.zabel; +Cc: linux-tegra, Rohit K Bharadwaj, devel, ac100
changed usage of slave (deprecated) to secondary
Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
---
drivers/staging/nvec/nvec.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
return IRQ_HANDLED;
}
-static void tegra_init_i2c_slave(struct nvec_chip *nvec)
+static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
{
u32 val;
@@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
}
#ifdef CONFIG_PM_SLEEP
-static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
+static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
{
disable_irq(nvec->irq);
writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
@@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, nvec);
nvec->dev = dev;
- if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
+ if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
dev_err(dev, "no i2c address specified");
return -ENODEV;
}
@@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
}
disable_irq(nvec->irq);
- tegra_init_i2c_slave(nvec);
+ tegra_init_i2c_secondary(nvec);
/* enable event reporting */
nvec_toggle_global_events(nvec, true);
@@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev)
if (!err)
nvec_msg_free(nvec, msg);
- nvec_disable_i2c_slave(nvec);
+ nvec_disable_i2c_secondary(nvec);
return 0;
}
@@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev)
struct nvec_chip *nvec = dev_get_drvdata(dev);
dev_dbg(nvec->dev, "resuming\n");
- tegra_init_i2c_slave(nvec);
+ tegra_init_i2c_secondary(nvec);
nvec_toggle_global_events(nvec, true);
return 0;
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] change slave occurence to secondary everywhere
2020-07-23 15:15 Rohit K Bharadwaj
@ 2020-07-23 17:06 ` Greg KH
2020-07-24 4:55 ` Rohit Bharadwaj
2020-07-24 14:07 ` Dan Carpenter
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2020-07-23 17:06 UTC (permalink / raw)
To: Rohit K Bharadwaj; +Cc: linux-tegra, devel, ac100, p.zabel
On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Odd subject line, you should follow the other patches for this driver:
staging: nvec: one_line_description_here
Also, you need to version your patches, this was v2, right? Put below
the --- line what you changed for each version.
v3?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] change slave occurence to secondary everywhere
2020-07-23 17:06 ` Greg KH
@ 2020-07-24 4:55 ` Rohit Bharadwaj
0 siblings, 0 replies; 7+ messages in thread
From: Rohit Bharadwaj @ 2020-07-24 4:55 UTC (permalink / raw)
To: Greg KH; +Cc: linux-tegra, devel, ac100, p.zabel
On 23/07/20 10:36 pm, Greg KH wrote:
> On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
>> changed usage of slave (deprecated) to secondary
>>
>> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
>> ---
>> drivers/staging/nvec/nvec.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Odd subject line, you should follow the other patches for this driver:
> staging: nvec: one_line_description_here
>
> Also, you need to version your patches, this was v2, right? Put below
> the --- line what you changed for each version.
>
> v3?
>
> thanks,
>
> greg k-h
>
Thank you so much for the suggestions sir, I have made all the necessary changes and have submitted the patch again, I apologize for any inconvenience caused from my side.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] change slave occurence to secondary everywhere
2020-07-23 15:15 Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
@ 2020-07-24 14:07 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2020-07-24 14:07 UTC (permalink / raw)
To: Rohit K Bharadwaj; +Cc: devel, gregkh, marvin24, p.zabel, linux-tegra, ac100
The patch prefix isn't right.
On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
>
> Signed-off-by: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 360ec0407740..5d7b66719a39 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> return IRQ_HANDLED;
> }
>
> -static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec)
> {
> u32 val;
>
> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec)
> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec)
> {
> disable_irq(nvec->irq);
> writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG);
> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, nvec);
> nvec->dev = dev;
>
> - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> + if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
Be careful not to break the driver.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-24 14:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 14:58 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 15:09 ` Greg KH
2020-07-24 14:06 ` Dan Carpenter
2020-07-23 15:15 Rohit K Bharadwaj
2020-07-23 17:06 ` Greg KH
2020-07-24 4:55 ` Rohit Bharadwaj
2020-07-24 14:07 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).